From: Conor Dooley <conor@kernel.org>
To: jingbao qiu <qiujingbao.dlmu@gmail.com>
Cc: a.zummo@towertech.it, alexandre.belloni@bootlin.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, chao.wei@sophgo.com,
unicorn_wang@outlook.com, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
linux-rtc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, dlan@gentoo.org
Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC
Date: Sun, 17 Dec 2023 20:46:54 +0000 [thread overview]
Message-ID: <20231217-swept-uncorrupt-92ac058dba4b@spud> (raw)
In-Reply-To: <CAJRtX8TQ02swRqzNfPHPrcS-MU=pBN_atjV2PFsAyJeNBF8kgA@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1336 bytes --]
On Sun, Dec 17, 2023 at 09:16:39PM +0800, jingbao qiu wrote:
> On Sun, Dec 17, 2023 at 8:26 PM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Sun, Dec 17, 2023 at 07:09:50PM +0800, Jingbao Qiu wrote:
> >
> > > + reg:
> > > + items:
> > > + - description: data register
> > > + - description: control register
> >
> > > + rtc@5025000{
> > > + compatible = "sophgo,cv1800-rtc";
> > > + reg = <0x5025000 0x1000>, <0x5026000 0x1000>;
> >
> > Why are these two regions rather than just one, given they are located
> > next to one another?
> > Are they separate on one of the other devices in this family?
> >
> > Thanks,
> > Conor.
> >
>
> I think there are two reasons, the first one is to distinguish
> different logical ,
> REG_ CTRL (base on 0x5025000) controls clock calibration, sleep,and other
> functions, RTC_ CORE (base on 0x5026000) has basic RTC functionality,
> The second is the maximum address used by RTC_CTRL (base on 0x5025000)
> is 0x0ac,which is much smaller than 0x1000. Therefore, the datasheet divides
> it into two parts for introduction, and I also divide it into two
> parts based on this
> introduction.So do you suggest that I merge them together？
If all of the cv1800 series devices have them sequentially, I would just
make them one region.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-17 20:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-17 11:09 [PATCH v2 0/3] riscv: rtc: sophgo: add rtc support for CV1800 Jingbao Qiu
2023-12-17 11:09 ` [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC Jingbao Qiu
2023-12-17 12:26 ` Conor Dooley
2023-12-17 13:16 ` jingbao qiu
2023-12-17 20:46 ` Conor Dooley [this message]
2023-12-18 2:06 ` jingbao qiu
2023-12-18 3:41 ` Inochi Amaoto
2023-12-20 21:36 ` Rob Herring
2023-12-17 11:09 ` [PATCH v2 2/3] rtc: sophgo: add rtc support for Sophgo CV1800 SoC Jingbao Qiu
2023-12-17 22:47 ` kernel test robot
2023-12-17 11:09 ` [PATCH v2 3/3] riscv: dts: sophgo: add rtc dt node for CV1800 Jingbao Qiu
2023-12-17 20:47 ` Conor Dooley
2023-12-18 2:05 ` jingbao qiu
2023-12-18 4:15 ` Inochi Amaoto
2023-12-18 5:40 ` [PATCH v2 0/3] riscv: rtc: sophgo: add rtc support " Jisheng Zhang
2023-12-18 7:11 ` Jingbao Qiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231217-swept-uncorrupt-92ac058dba4b@spud \
--to=conor@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dlan@gentoo.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=qiujingbao.dlmu@gmail.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox