devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
To: andersson@kernel.org, konrad.dybcio@linaro.org, vkoul@kernel.org,
	sboyd@kernel.org, mturquette@baylibre.com, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-arm-msm@vger.kernel.org, linux-phy@lists.infradead.org,
	linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org, quic_cang@quicinc.com,
	Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Subject: [PATCH v2 12/16] arm64: dts: qcom: sm8250: Fix UFS PHY clocks
Date: Mon, 18 Dec 2023 17:37:08 +0530	[thread overview]
Message-ID: <20231218120712.16438-13-manivannan.sadhasivam@linaro.org> (raw)
In-Reply-To: <20231218120712.16438-1-manivannan.sadhasivam@linaro.org>

QMP PHY used in SM8250 requires 3 clocks:

* ref - 19.2MHz reference clock from RPMh
* ref_aux - Auxiliary reference clock from GCC
* qref - QREF clock from GCC

While at it, let's move 'clocks' property before 'clock-names' to match
the style used commonly.

Fixes: b7e2fba06622 ("arm64: dts: qcom: sm8250: Add UFS controller and PHY")
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
 arch/arm64/boot/dts/qcom/sm8250.dtsi | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi
index c1b7f9620ec6..e47c515af6cf 100644
--- a/arch/arm64/boot/dts/qcom/sm8250.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi
@@ -2486,10 +2486,12 @@ ufs_mem_phy: phy@1d87000 {
 			#address-cells = <2>;
 			#size-cells = <2>;
 			ranges;
-			clock-names = "ref",
-				      "ref_aux";
 			clocks = <&rpmhcc RPMH_CXO_CLK>,
-				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
+				 <&gcc GCC_UFS_PHY_PHY_AUX_CLK>,
+				 <&gcc GCC_UFS_1X_CLKREF_EN>;
+			clock-names = "ref",
+				      "ref_aux",
+				      "qref";
 
 			resets = <&ufs_mem_hc 0>;
 			reset-names = "ufsphy";
-- 
2.25.1


  parent reply	other threads:[~2023-12-18 12:08 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-18 12:06 [PATCH v2 00/16] Fix Qcom UFS PHY clocks Manivannan Sadhasivam
2023-12-18 12:06 ` [PATCH v2 01/16] dt-bindings: phy: qmp-ufs: Fix " Manivannan Sadhasivam
2024-01-24  5:44   ` Vinod Koul
2023-12-18 12:06 ` [PATCH v2 02/16] phy: qcom-qmp-ufs: Switch to devm_clk_bulk_get_all() API Manivannan Sadhasivam
2023-12-18 12:06 ` [PATCH v2 03/16] dt-bindings: clock: qcom: Add missing UFS QREF clocks Manivannan Sadhasivam
2023-12-20  7:38   ` Krzysztof Kozlowski
2023-12-18 12:07 ` [PATCH v2 04/16] clk: qcom: gcc-sc8180x: " Manivannan Sadhasivam
2023-12-20  0:39   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 05/16] arm64: dts: qcom: msm8996: Fix UFS PHY clocks Manivannan Sadhasivam
2023-12-20  0:32   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 06/16] arm64: dts: qcom: msm8998: " Manivannan Sadhasivam
2023-12-20  0:32   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 07/16] arm64: dts: qcom: sdm845: " Manivannan Sadhasivam
2023-12-20  0:33   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 08/16] arm64: dts: qcom: sm6115: " Manivannan Sadhasivam
2023-12-20  0:33   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 09/16] arm64: dts: qcom: sm6125: " Manivannan Sadhasivam
2023-12-20  0:33   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 10/16] arm64: dts: qcom: sm6350: " Manivannan Sadhasivam
2023-12-20  0:34   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 11/16] arm64: dts: qcom: sm8150: " Manivannan Sadhasivam
2023-12-20  0:34   ` Konrad Dybcio
2023-12-18 12:07 ` Manivannan Sadhasivam [this message]
2023-12-20  0:34   ` [PATCH v2 12/16] arm64: dts: qcom: sm8250: " Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 13/16] arm64: dts: qcom: sc8180x: " Manivannan Sadhasivam
2023-12-20  0:34   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 14/16] arm64: dts: qcom: sc8280xp: " Manivannan Sadhasivam
2023-12-20  0:35   ` Konrad Dybcio
2023-12-20  8:30     ` Manivannan Sadhasivam
2024-01-03 13:50       ` Konrad Dybcio
2024-01-24  8:46         ` Manivannan Sadhasivam
2023-12-18 12:07 ` [PATCH v2 15/16] arm64: dts: qcom: sm8350: " Manivannan Sadhasivam
2023-12-20  0:35   ` Konrad Dybcio
2023-12-18 12:07 ` [PATCH v2 16/16] arm64: dts: qcom: sm8550: " Manivannan Sadhasivam
2023-12-20  0:36   ` Konrad Dybcio
2023-12-20  3:56   ` Can Guo
2024-02-07 14:01 ` (subset) [PATCH v2 00/16] Fix Qcom " Vinod Koul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218120712.16438-13-manivannan.sadhasivam@linaro.org \
    --to=manivannan.sadhasivam@linaro.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_cang@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).