devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Rob Herring <robh@kernel.org>, Nuno Sa <nuno.sa@analog.com>,
	devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v3 0/8] iio: add new backend framework
Date: Mon, 18 Dec 2023 18:12:43 +0000	[thread overview]
Message-ID: <20231218181243.2b1e17ba@jic23-huawei> (raw)
In-Reply-To: <4531a5b626361a18bba8df640f530fcaeab00e7e.camel@gmail.com>


> > >   
> > > >     
> > > > > > And if there's another consumer in the chain, then a node could 
> > > > > > certainly be both an io-channels consumer and producer.
> > > > > >     
> > > > > 
> > > > > This should also be possible with this architecture. A node can be both
> > > > > a backend
> > > > > (provider) and a consumer and we have an out of tree design that fits
> > > > > this (that
> > > > > I
> > > > > surely want to upstream after the foundations are done).
> > > > >     
> > > > > > The architecture of the drivers seems odd to me. It looks similar to 
> > > > > > making a phy driver handle all the state and protocol with the host 
> > > > > > controller being a backend.    
> > > > > 
> > > > > In this case, it's not really a controller. It's more like an extension
> > > > > of the
> > > > > device
> > > > > because we need a way to handle the high sample rates this ADCs can do.
> > > > > Then we
> > > > > can
> > > > > also do test tones with the backend which is useful for interface tuning
> > > > > (as
> > > > > mentioned above).
> > > > > 
> > > > > To give you a bit more context, I'm adding the generic property because
> > > > > we will
> > > > > have
> > > > > more users for it (from ADI - the next should be the axi-dac core) but
> > > > > STM is
> > > > > also
> > > > > interested in this (likely the next user).
> > > > > 
> > > > > Hope this makes it a bit more clear...    
> > > > 
> > > > Yes, thanks.
> > > > 
> > > > I generally ask for 2 users on new common bindings. I've accepted too 
> > > > many only to have the 2nd user come in a month later and need additions. 
> > > > An ack on the binding from the STM folks would be nice here. And 
> > > > Jonathan too.
> > > >     
> > > 
> > > Olivier, could we get an ack on the bindings patch? Do you also have any
> > > idea about
> > > how long it would take for you to send patches so we have another user of
> > > the schema?
> > > 
> > > On my side, it might very well take a month or so (given we have holidays
> > > nearby) as
> > > the axi-dac core is more complex than the axi-adc. Bah it might take less
> > > than a
> > > month to have the first version of it posted in the lists but I can't make
> > > any
> > > promises.  
> > 
> > For the driver side of things I'd like at least 2, preferably 3 users before
> > merging.
> > We have more flexibility to rework things as any issues will probably be
> > internal
> > interfaces, but I'd rather wait if we are going to have 3 users within another
> > month
> > or 2.
> >   
> 
> Totally fine by me. But how would this look like? Could we have an immutable
> branch where we can send patches about this? Or maybe staging? I'm asking
> because adding more stuff into these series might make it harder to review (the
> axi-dac might have some fun ABI discussion :)). Ideally, we would have this
> merged somewhere and then add users on top of it.

It's fine to post a bunch of series with stated dependencies
(I've gotten 5 series + deep in the past :)

Obviously useful to have a git tree with them all on somewhere though
but if you host that it would be ideal given you are driving this
work in general.

Jonathan

> 
> - Nuno Sá


  reply	other threads:[~2023-12-18 18:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-13 15:02 [PATCH v3 0/8] iio: add new backend framework Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 1/8] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2023-12-13 17:55   ` Rob Herring
2023-12-14 12:27     ` Nuno Sá
2023-12-14 17:05   ` Rob Herring
2023-12-15  7:52     ` Nuno Sá
2023-12-13 15:02 ` [PATCH v3 2/8] dt-bindings: adc: axi-adc: deprecate 'adi,adc-dev' Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 3/8] driver: core: allow modifying device_links flags Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 4/8] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 5/8] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 6/8] iio: add the IIO backend framework Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 7/8] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2023-12-13 15:02 ` [PATCH v3 8/8] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2023-12-14 14:16 ` [PATCH v3 0/8] iio: add new " Rob Herring
2023-12-14 16:05   ` Nuno Sá
2023-12-14 17:03     ` Rob Herring
2023-12-15 15:18       ` Nuno Sá
2023-12-17 14:04         ` Jonathan Cameron
2023-12-18  8:31           ` Nuno Sá
2023-12-18 18:12             ` Jonathan Cameron [this message]
2023-12-20 14:17           ` Rob Herring
2023-12-20 14:56             ` Nuno Sá
2024-01-11 16:44         ` Olivier MOYSAN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231218181243.2b1e17ba@jic23-huawei \
    --to=jic23@kernel.org \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=rafael@kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).