Re: [PATCH v2 1/2] dt-bindings: hwmon: (lm75) Add AMS AS6200 temperature sensor

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

On Tue, Dec 19, 2023 at 11:27:29AM -0500, Abdel Alkuor wrote:
> On Tue, Dec 19, 2023 at 03:18:24PM +0000, Conor Dooley wrote:
> > On Sun, Dec 17, 2023 at 11:52:27PM -0500, Abdel Alkuor wrote:
> > 
> > Do the other devices here have interrupts? If not, you just allowed
> > interrupts for them. You, at the very least, need to add something like:
> > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.yaml b/Documentation/devicetree/bindings/hwmon/lm75.yaml
> > index 63b85a83ac18..d7ce96606400 100644
> > --- a/Documentation/devicetree/bindings/hwmon/lm75.yaml
> > +++ b/Documentation/devicetree/bindings/hwmon/lm75.yaml
> > @@ -56,6 +56,17 @@ required:
> >    - compatible
> >    - reg
> >  
> > +allOf:
> > +  - if:
> > +      not:
> > +        properties:
> > +          compatible:
> > +            contains:
> > +              const: ams,as6200
> > +    then:
> > +      properties:
> > +        interrupts: false
> > +
> >  additionalProperties: false
> >  
> No, not all of them support the interrupt. Just tmp101, tmp102, tmp112, and as6200.
> For now, I'll add the check for ams,as6200.

If multiple devices have the interrupt you should document it for all of
them IMO.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]