devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Bjorn Andersson <quic_bjorande@quicinc.com>
To: Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konrad.dybcio@linaro.org>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>, Rob Herring <robh+dt@kernel.org>,
	"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Taniya Das <quic_tdas@quicinc.com>,
	Ulf Hansson <ulf.hansson@linaro.org>,
	Johan Hovold <johan+linaro@kernel.org>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linux-pm@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	"Bjorn Andersson" <quic_bjorande@quicinc.com>
Subject: [PATCH v2 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler
Date: Thu, 21 Dec 2023 20:39:23 -0800	[thread overview]
Message-ID: <20231220-sa8295p-gpu-v2-2-4763246b72c0@quicinc.com> (raw)
In-Reply-To: <20231220-sa8295p-gpu-v2-0-4763246b72c0@quicinc.com>

The GX GDSC is modelled to aid the GMU in powering down the GPU in the
event that the GPU crashes, so that it can be restarted again. But in
the event that the power-domain is supplied through a dedicated
regulator (in contrast to being a subdomin of another power-domain),
something needs to turn that regulator on, both to make sure things are
powered and to match the operation in gdsc_disable().

Signed-off-by: Bjorn Andersson <quic_bjorande@quicinc.com>
---
 drivers/clk/qcom/gdsc.c | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gdsc.c b/drivers/clk/qcom/gdsc.c
index 5358e28122ab..e7a4068b9f39 100644
--- a/drivers/clk/qcom/gdsc.c
+++ b/drivers/clk/qcom/gdsc.c
@@ -557,7 +557,15 @@ void gdsc_unregister(struct gdsc_desc *desc)
  */
 int gdsc_gx_do_nothing_enable(struct generic_pm_domain *domain)
 {
-	/* Do nothing but give genpd the impression that we were successful */
-	return 0;
+	struct gdsc *sc = domain_to_gdsc(domain);
+	int ret = 0;
+
+	/* Enable the parent supply, when controlled through the regulator framework. */
+	if (sc->rsupply)
+		ret = regulator_enable(sc->rsupply);
+
+	/* Do nothing with the GDSC itself */
+
+	return ret;
 }
 EXPORT_SYMBOL_GPL(gdsc_gx_do_nothing_enable);

-- 
2.25.1


  parent reply	other threads:[~2023-12-22  4:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-22  4:39 [PATCH v2 0/8] arm64: dts: qcom: sa8295p: Enable GPU Bjorn Andersson
2023-12-22  4:39 ` [PATCH v2 1/8] dt-bindings: clock: qcom: Allow VDD_GFX supply to GX Bjorn Andersson
2023-12-22  8:12   ` Krzysztof Kozlowski
2023-12-22 12:07     ` Konrad Dybcio
2023-12-27 20:30     ` Bjorn Andersson
2023-12-29 23:51       ` Konrad Dybcio
2023-12-22  4:39 ` Bjorn Andersson [this message]
2023-12-27  1:07   ` [PATCH v2 2/8] clk: qcom: gdsc: Enable supply reglator in GPU GX handler Konrad Dybcio
2023-12-22  4:39 ` [PATCH v2 3/8] clk: qcom: gpucc-sc8280xp: Add external supply for GX gdsc Bjorn Andersson
2023-12-27  1:07   ` Konrad Dybcio
2024-01-08 18:23     ` Bjorn Andersson
2023-12-22  4:39 ` [PATCH v2 4/8] soc: qcom: rpmhpd: Drop SA8540P gfx.lvl Bjorn Andersson
2023-12-27  1:08   ` Konrad Dybcio
2024-01-03 12:54   ` Ulf Hansson
2023-12-22  4:39 ` [PATCH v2 5/8] arm64: dts: qcom: sa8540p: Drop gfx.lvl as power-domain for gpucc Bjorn Andersson
2023-12-27  1:10   ` Konrad Dybcio
2023-12-22  4:39 ` [PATCH v2 6/8] arm64: dts: qcom: sa8295p-adp: add max20411 Bjorn Andersson
2023-12-27  1:08   ` Konrad Dybcio
2023-12-22  4:39 ` [PATCH v2 7/8] arm64: dts: qcom: sa8295p-adp: Enable GPU Bjorn Andersson
2023-12-22  6:31   ` Dmitry Baryshkov
2023-12-27  1:09   ` Konrad Dybcio
2023-12-27 20:21     ` Bjorn Andersson
2023-12-30 12:22       ` Konrad Dybcio
2023-12-22  4:39 ` [PATCH v2 8/8] arm64: defconfig: Enable MAX20411 regulator driver Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231220-sa8295p-gpu-v2-2-4763246b72c0@quicinc.com \
    --to=quic_bjorande@quicinc.com \
    --cc=andersson@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johan+linaro@kernel.org \
    --cc=konrad.dybcio@linaro.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=quic_tdas@quicinc.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=ulf.hansson@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).