From: Jonathan Cameron <jic23@kernel.org>
To: Mike Looijmans <mike.looijmans@topic.nl>
Cc: Jonathan Cameron <Jonathan.Cameron@Huawei.com>,
devicetree@vger.kernel.org, linux-iio@vger.kernel.org,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver
Date: Wed, 20 Dec 2023 14:00:39 +0000 [thread overview]
Message-ID: <20231220140039.7b50f874@jic23-huawei> (raw)
In-Reply-To: <02cbc31e-ec6e-4b3b-940d-da51567c197b@topic.nl>
> >
> > Should probably also document the gpios as the binding should attempt to be as complete
> > as possible independent of what the driver currently supports.
> >
> > Lots of complex options for this device and the use of those pins, so maybe something
> > that can be left for now - but the patch description should then mention that is intentional.
>
> The device has so many options for connecting stuff... It's indeed possible to
> (also) use it as a GPIO expander and as a clock source and more...
>
> I'll put it in the patch description that the definition is incomplete by design.
>
> The main reason I'm submitting is that this is about the third time I've
> written a driver for this chip, and I'm sure that other companies are writing
> their own as well. I'm hoping this will result in some joint effort to
> properly support it...
>
Fair enough. Incomplete bindings aren't ideal, but definitely better than no bindings
in my view.
Jonathan
prev parent reply other threads:[~2023-12-20 14:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.618139b3-8cb2-4e4c-9283-9e3787c70105@emailsignatures365.codetwo.com>
2023-12-13 9:47 ` [PATCH 1/2] dt-bindings: iio: adc: ti-ads1298: Add driver Mike Looijmans
[not found] ` <1b153bce-a66a-45ee-a5c6-963ea6fb1c82.949ef384-8293-46b8-903f-40a477c056ae.27993507-256d-4b05-88df-c8643e7f1a68@emailsignatures365.codetwo.com>
2023-12-13 9:47 ` [PATCH 2/2] " Mike Looijmans
2023-12-13 14:55 ` Andy Shevchenko
2024-01-31 16:10 ` Mike Looijmans
2024-02-01 11:38 ` Andy Shevchenko
2024-02-04 13:06 ` Jonathan Cameron
2023-12-14 11:06 ` Jonathan Cameron
2024-01-31 16:24 ` Mike Looijmans
2024-02-04 13:32 ` Jonathan Cameron
2023-12-13 16:23 ` [PATCH 1/2] dt-bindings: " Conor Dooley
2023-12-14 10:22 ` Jonathan Cameron
2023-12-20 10:42 ` Mike Looijmans
2023-12-20 13:59 ` Jonathan Cameron
2023-12-14 11:11 ` Jonathan Cameron
2023-12-20 10:58 ` Mike Looijmans
2023-12-20 14:00 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231220140039.7b50f874@jic23-huawei \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@Huawei.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.looijmans@topic.nl \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).