From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCDC6495C1; Wed, 20 Dec 2023 21:36:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="FPnDMo7p" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D32AAC433C8; Wed, 20 Dec 2023 21:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703108192; bh=8fD+g/UALuuFVC/2IctyRtQM4JlqRN9pptw2dt8R384=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=FPnDMo7pNAr/kSeAnISx6iuXuIfsSnkY1fKBKFrT3QgIbqPjQugd/OPucZIcKIpkR VgyhBRqne7a7T2qdpp79bzBdY7TdF+ZnOXIILHpvaHQEqwWRRamFOKNEc9GqZ2GM0G 6k9rmb+DazFqGagtmG/7WXvigSPZfmi46GjfgghdlY3TMHQ+F1VqfMyDXTkSSs3WWY r4eLEgwSuVmi0g9kr0MEkRv3hSPPkqnxB7FaqDQ/BSoxSUJUoyZHwqYE9jlHRMZopE 7NPikncxVjQCVqnkhU/wRWfnHZPYRcKSusq37pLNTsJK5Yk1JkYGa460DVfaGpDxxd UxyFN4JL30JQw== Received: (nullmailer pid 1179044 invoked by uid 1000); Wed, 20 Dec 2023 21:36:29 -0000 Date: Wed, 20 Dec 2023 15:36:29 -0600 From: Rob Herring To: Inochi Amaoto Cc: Conor Dooley , jingbao qiu , a.zummo@towertech.it, alexandre.belloni@bootlin.com, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, chao.wei@sophgo.com, unicorn_wang@outlook.com, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, linux-rtc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dlan@gentoo.org Subject: Re: [PATCH v2 1/3] dt-bindings: rtc: sophgo: add RTC support for Sophgo CV1800 series SoC Message-ID: <20231220213629.GA1177070-robh@kernel.org> References: <20231217-swept-uncorrupt-92ac058dba4b@spud> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Dec 18, 2023 at 11:41:52AM +0800, Inochi Amaoto wrote: > >On Sun, Dec 17, 2023 at 09:16:39PM +0800, jingbao qiu wrote: > >> On Sun, Dec 17, 2023 at 8:26=E2=80=AFPM Conor Dooley w= > >rote: > >> > > >> > On Sun, Dec 17, 2023 at 07:09:50PM +0800, Jingbao Qiu wrote: > >> > > >> > > + reg: > >> > > + items: > >> > > + - description: data register > >> > > + - description: control register > >> > > >> > > + rtc@5025000{ > >> > > + compatible =3D "sophgo,cv1800-rtc"; > >> > > + reg =3D <0x5025000 0x1000>, <0x5026000 0x1000>; > >> > > >> > Why are these two regions rather than just one, given they are located > >> > next to one another? > >> > Are they separate on one of the other devices in this family? > >> > > >> > Thanks, > >> > Conor. > >> > > >>=20 > >> I think there are two reasons, the first one is to distinguish > >> different logical , > >> REG_ CTRL (base on 0x5025000) controls clock calibration, sleep,and other > >> functions, RTC_ CORE (base on 0x5026000) has basic RTC functionality, > >> The second is the maximum address used by RTC_CTRL (base on 0x5025000) > >> is 0x0ac,which is much smaller than 0x1000. Therefore, the datasheet divi= > >des > >> it into two parts for introduction, and I also divide it into two > >> parts based on this > >> introduction.So do you suggest that I merge them together=EF=BC=9F > > > >If all of the cv1800 series devices have them sequentially, I would just > >make them one region. > > > > I agree with using one region. The ctrl and core region are highly > releated. > > Moreover, I suggest using syscon to describe this region, the reboot > device is also in this region. Then the description of the device is incomplete. Please describe the whole block/device. Rob