devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andre Przywara <andre.przywara@arm.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
	Jernej Skrabec <jernej.skrabec@gmail.com>,
	Samuel Holland <samuel@sholland.org>,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-sunxi@lists.linux.dev, Maxime Ripard <mripard@kernel.org>
Subject: Re: [PATCH] dt-bindings: arm: sunxi: sort alphabetically
Date: Thu, 21 Dec 2023 16:29:07 +0000	[thread overview]
Message-ID: <20231221162907.1b609235@donnerap.manchester.arm.com> (raw)
In-Reply-To: <6721cb2f-4498-4d20-9059-257846005905@linaro.org>

On Thu, 21 Dec 2023 16:38:41 +0100
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:

Hi,

(CC:ing Maxime for potential historic context)

> On 21/12/2023 16:07, Andre Przywara wrote:
> > On Thu, 21 Dec 2023 15:45:17 +0100
> > Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
> > 
> > Hi,
> >   
> >> On 21/12/2023 15:06, Andre Przywara wrote:  
> >>> The sunxi.yaml file, holding all known board compatible names for
> >>> devices with Allwinner SoCs, is apparently sorted alphabetically, by the
> >>> "description" entry. However there are a few outliers.
> >>>
> >>> Re-order the entries to get a strict alphabetical ordering, so that:
> >>> $ grep description: sunxi.yaml | sort -fc
> >>> returns empty-handed. There is no change otherwise.
> >>>
> >>> Signed-off-by: Andre Przywara <andre.przywara@arm.com>    
> >>
> >> What was the existing order? Aren't this just shuffling again things?  
> > 
> > It assume the intention was to order "alphabetically by description", but
> > there were some out-of-place entries which apparently slipped through
> > review.
> > 
> > Shall I add a comment at the top to note the order?  
> 
> Some files like this are ordered by compatible, some by class or family
> of devices, so first you need to be sure there is no existing order.

That's what I did, of course:
- there is no order in the compatible strings, not in the most specific
name, nor in the fallback names
- new boards have always been added somewhere in the middle, never at the
end, so it's not "oldest boards first"
- the SoCs used in the boards are all over the place, so it's not sorted
by SoC
- I see no rhyme or reason in the board types: we have tablets, devboards,
TV boxes all mixed up happily.

But: from the 197 listed boards, a movement of 13 boards, often by just one
position, makes the list ordered by description.

So I assumed this was the intention, and fixed the list accordingly. Happy
to stand corrected if the maintainers have a better idea.

Cheers,
Andre

  reply	other threads:[~2023-12-21 16:29 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-21 14:06 [PATCH] dt-bindings: arm: sunxi: sort alphabetically Andre Przywara
2023-12-21 14:45 ` Krzysztof Kozlowski
2023-12-21 15:07   ` Andre Przywara
2023-12-21 15:38     ` Krzysztof Kozlowski
2023-12-21 16:29       ` Andre Przywara [this message]
2023-12-22  8:09         ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231221162907.1b609235@donnerap.manchester.arm.com \
    --to=andre.przywara@arm.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=mripard@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=samuel@sholland.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).