From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E42768FC; Thu, 21 Dec 2023 20:59:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ODAjMawt" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2C7FC433C8; Thu, 21 Dec 2023 20:59:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1703192399; bh=M+RgHeXr3acAWpXB/Z7oGyBX8646M4biQdV6RYlPSGU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ODAjMawtAcLPRa6U4932mGjc8JQ72iM9SZvC/x7JWopB77qQgbcmhxCDCpPvJ7MCh KrtvOw21Nc2hldrMA01qbn1xOPzqjxM3exs3ZH5QphQIUPtPInSDVKOsEJFhN59T04 aY2qTUfr2cWmCf6NmATJthVLcgD0RuhadhH9TQTE1pwCoM0CnY4ORJwnejygjOXiZY GFE2KlWbbiWRqio4375L9QFjnCoLD0WQ7OK3FeUO5TqtMK+sx6a9k8UUw2jZkTxP/D SjyMjWaFVWOgHy2oqKb6ZWyd5SUEctmtrKvC2r0nZzP9axWDNqzLjyiATSr152FYei N5xI3ik81GTTg== Received: (nullmailer pid 82152 invoked by uid 1000); Thu, 21 Dec 2023 20:59:58 -0000 Date: Thu, 21 Dec 2023 14:59:58 -0600 From: Rob Herring To: Christoph Winklhofer Cc: krzysztof.kozlowski@linaro.org, conor+dt@kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] dt-bindings: w1: UART 1-wire bus Message-ID: <20231221205958.GA73493-robh@kernel.org> References: <20231221065049.30703-1-cj.winklhofer@gmail.com> <20231221065049.30703-2-cj.winklhofer@gmail.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231221065049.30703-2-cj.winklhofer@gmail.com> On Thu, Dec 21, 2023 at 07:50:47AM +0100, Christoph Winklhofer wrote: > Add device tree binding for UART 1-wire bus. > > Signed-off-by: Christoph Winklhofer > --- > .../devicetree/bindings/w1/w1-uart.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/w1/w1-uart.yaml > > diff --git a/Documentation/devicetree/bindings/w1/w1-uart.yaml b/Documentation/devicetree/bindings/w1/w1-uart.yaml > new file mode 100644 > index 000000000000..93d83c42c407 > --- /dev/null > +++ b/Documentation/devicetree/bindings/w1/w1-uart.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/w1/w1-uart.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: UART 1-Wire Bus > + > +maintainers: > + - Christoph Winklhofer > + > +description: | > + UART 1-wire bus. Utilizes the UART interface via the Serial Device Bus > + to create the 1-Wire timing patterns. > + > + The UART peripheral must support full-duplex and operate in open-drain > + mode. The timing patterns are generated by a specific combination of > + baud-rate and transmitted byte, which corresponds to a 1-Wire read bit, > + write bit or reset pulse. > + > + The default baud-rate for reset and presence detection is 9600 and for > + a 1-Wire read or write operation 115200. In case the actual baud-rate > + is different from the requested one, the transmitted byte is adapted > + to generate the 1-Wire timing patterns. > + > + https://www.analog.com/en/technical-articles/using-a-uart-to-implement-a-1wire-bus-master.html > + > + > +properties: > + compatible: > + const: w1-uart > + > +required: > + - compatible > + > +additionalProperties: false > + > +examples: > + - | > + serial { > + onewire { Have you tried this in an actual DT? Assuming the UART node has a schema, it should be a warning because child node names are explicit in serial.yaml unfortunately. IOW, you need to add "onewire" to serial.yaml. > + compatible = "w1-uart"; > + }; > + }; > -- > 2.43.0 >