From: Rob Herring <robh@kernel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Moudy Ho <moudy.ho@mediatek.com>,
Chun-Kuang Hu <chunkuang.hu@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
Maxime Ripard <mripard@kernel.org>,
Thomas Zimmermann <tzimmermann@suse.de>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 02/16] dt-bindings: media: mediatek: mdp3: merge the indentical RDMA under display
Date: Thu, 21 Dec 2023 16:29:32 -0600 [thread overview]
Message-ID: <20231221222932.GA196757-robh@kernel.org> (raw)
In-Reply-To: <250fead9-868b-4063-a054-4cb966dc4ba3@linaro.org>
On Thu, Dec 21, 2023 at 10:28:52AM +0100, Krzysztof Kozlowski wrote:
> On 20/12/2023 11:08, Moudy Ho wrote:
> > To simplify maintenance and avoid branches, the identical component
> > should be merged and placed in the path belonging to the MDP
> > (from display/* to media/*).
>
> Combining bindings into one bigger meta-binding makes it usually more
> difficult to maintain and review.
Yeah, but these mediatek blocks appear to be used for both display and
video codec pipelines. So having different bindings was probably wrong
to start with.
Rob
next prev parent reply other threads:[~2023-12-21 22:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 10:08 [PATCH v10 00/16] introduce more MDP3 components in MT8195 Moudy Ho
2023-12-20 10:08 ` [PATCH v10 01/16] dt-bindings: media: mediatek: mdp3: correct RDMA and WROT node with generic names Moudy Ho
2023-12-20 10:08 ` [PATCH v10 02/16] dt-bindings: media: mediatek: mdp3: merge the indentical RDMA under display Moudy Ho
2023-12-21 9:28 ` Krzysztof Kozlowski
2023-12-21 22:29 ` Rob Herring [this message]
2023-12-20 10:08 ` [PATCH v10 03/16] dt-bindings: media: mediatek: mdp3: add config for MT8195 RDMA Moudy Ho
2023-12-20 10:08 ` [PATCH v10 04/16] dt-bindings: media: mediatek: mdp3: add compatible for MT8195 RSZ Moudy Ho
2023-12-20 10:08 ` [PATCH v10 05/16] dt-bindings: media: mediatek: mdp3: add compatible for MT8195 WROT Moudy Ho
2023-12-20 10:08 ` [PATCH v10 06/16] dt-bindings: media: mediatek: mdp3: add component FG for MT8195 Moudy Ho
2023-12-20 10:08 ` [PATCH v10 07/16] dt-bindings: media: mediatek: mdp3: add component HDR " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 08/16] dt-bindings: media: mediatek: mdp3: add component STITCH " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 09/16] dt-bindings: media: mediatek: mdp3: add component TCC " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 10/16] dt-bindings: media: mediatek: mdp3: add component TDSHP " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 11/16] dt-bindings: display: mediatek: aal: add compatible " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 12/16] dt-bindings: display: mediatek: color: " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 13/16] dt-bindings: display: mediatek: merge: " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 14/16] dt-bindings: display: mediatek: ovl: " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 15/16] dt-bindings: display: mediatek: split: " Moudy Ho
2023-12-20 10:08 ` [PATCH v10 16/16] dt-bindings: display: mediatek: padding: " Moudy Ho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221222932.GA196757-robh@kernel.org \
--to=robh@kernel.org \
--cc=airlied@gmail.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=conor+dt@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthias.bgg@gmail.com \
--cc=mchehab@kernel.org \
--cc=moudy.ho@mediatek.com \
--cc=mripard@kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).