From: Rob Herring <robh@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: manivannan.sadhasivam@linaro.org, bhelgaas@google.com,
conor+dt@kernel.org, devicetree@vger.kernel.org,
festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com,
imx@lists.linux.dev, kernel@pengutronix.de,
krzysztof.kozlowski+dt@linaro.org,
krzysztof.kozlowski@linaro.org, kw@linux.com,
l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-imx@nxp.com, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org, lpieralisi@kernel.org,
s.hauer@pengutronix.de, shawnguo@kernel.org
Subject: Re: [PATCH v5 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string
Date: Thu, 21 Dec 2023 16:52:18 -0600 [thread overview]
Message-ID: <20231221225218.GA232422-robh@kernel.org> (raw)
In-Reply-To: <20231220213615.1561528-12-Frank.Li@nxp.com>
On Wed, Dec 20, 2023 at 04:36:10PM -0500, Frank Li wrote:
> From: Richard Zhu <hongxing.zhu@nxp.com>
>
> Add i.MX95 PCIe "fsl,imx95-pcie" compatible string.
> Add "atu" and "app" to reg-names.
>
> Signed-off-by: Richard Zhu <hongxing.zhu@nxp.com>
> ---
>
> Notes:
> Change from v2 to v3
> - Remove krzy's ACK tag
> - Add condition check for imx95, which required more reg-names then old
> platform, so need Krzy review again,
>
> Change from v1 to v2
> - add Krzy's ACK tag
>
> .../bindings/pci/fsl,imx6q-pcie-common.yaml | 1 +
> .../bindings/pci/fsl,imx6q-pcie.yaml | 18 ++++++++++++++++++
> 2 files changed, 19 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> index a284a27c5e873..1b63089ff0aee 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie-common.yaml
> @@ -207,6 +207,7 @@ allOf:
> - fsl,imx6sx-pcie
> - fsl,imx6q-pcie
> - fsl,imx6qp-pcie
> + - fsl,imx95-pcie
> - fsl,imx6sx-pcie-ep
> - fsl,imx6q-pcie-ep
> - fsl,imx6qp-pcie-ep
> diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> index f20d4f0e3cb6c..8633c622bd178 100644
> --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml
> @@ -29,6 +29,7 @@ properties:
> - fsl,imx8mq-pcie
> - fsl,imx8mm-pcie
> - fsl,imx8mp-pcie
> + - fsl,imx95-pcie
>
> clocks:
> minItems: 3
> @@ -80,6 +81,22 @@ required:
> allOf:
> - $ref: /schemas/pci/snps,dw-pcie.yaml#
> - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml#
> + - if:
> + properties:
> + compatible:
> + enum:
> + - fsl,imx95-pcie
> + then:
> + properties:
> + reg:
> + minItems: 4
> + reg-names:
> + items:
> + - const: dbi
> + - const: atu
> + - const: app
> + - const: config
Add new entries to the end. Originally, you had dbi and config. Add ata
and app on the end.
> +
> - if:
> properties:
> compatible:
> @@ -101,6 +118,7 @@ allOf:
> compatible:
> enum:
> - fsl,imx8mq-pcie
> + - fsl,imx95-pcie
> then:
> properties:
> clocks:
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-12-21 22:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-20 21:35 [PATCH v5 00/16] PCI: imx6: Clean up and add imx95 pci support Frank Li
2023-12-20 21:36 ` [PATCH v5 01/16] PCI: imx6: Simplify clock handling by using bulk_clk_*() function Frank Li
2023-12-20 21:36 ` [PATCH v5 02/16] PCI: imx6: Simplify phy handling by using by using IMX6_PCIE_FLAG_HAS_PHY Frank Li
2023-12-20 21:36 ` [PATCH v5 03/16] PCI: imx6: Simplify reset handling by using by using *_FLAG_HAS_*_RESET Frank Li
2023-12-20 21:36 ` [PATCH v5 04/16] dt-bindings: imx6q-pcie: Add linux,pci-domain as required for iMX8MQ Frank Li
2023-12-23 18:40 ` Krzysztof Kozlowski
2023-12-24 4:29 ` Frank Li
2023-12-24 9:02 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 05/16] PCI: imx6: Using "linux,pci-domain" as slot ID Frank Li
2023-12-20 21:36 ` [PATCH v5 06/16] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Frank Li
2023-12-20 21:36 ` [PATCH v5 07/16] PCI: imx6: Simplify configure_type() by using mode_off and mode_mask Frank Li
2023-12-20 21:36 ` [PATCH v5 08/16] PCI: imx6: Simplify switch-case logic by involve init_phy callback Frank Li
2023-12-20 21:36 ` [PATCH v5 09/16] dt-bindings: imx6q-pcie: Clean up irrationality clocks check Frank Li
2023-12-23 18:42 ` Krzysztof Kozlowski
2023-12-24 4:43 ` Frank Li
2023-12-24 9:04 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 10/16] dt-bindings: imx6q-pcie: remove reg and reg-name Frank Li
2023-12-21 22:50 ` Rob Herring
2023-12-23 3:46 ` Frank Li
2023-12-23 18:43 ` Krzysztof Kozlowski
2023-12-24 4:34 ` Frank Li
2023-12-24 9:06 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 11/16] dt-bindings: imx6q-pcie: Add imx95 pcie compatible string Frank Li
2023-12-21 22:52 ` Rob Herring [this message]
2023-12-20 21:36 ` [PATCH v5 12/16] PCI: imx6: Add iMX95 PCIe support Frank Li
2023-12-20 21:36 ` [PATCH v5 13/16] PCI: imx6: Clean up get addr_space code Frank Li
2023-12-20 21:36 ` [PATCH v5 14/16] PCI: imx6: Add epc_features in imx6_pcie_drvdata Frank Li
2023-12-20 21:36 ` [PATCH v5 15/16] dt-bindings: imx6q-pcie: Add iMX95 pcie endpoint compatible string Frank Li
2023-12-23 18:44 ` Krzysztof Kozlowski
2023-12-24 4:47 ` Frank Li
2023-12-24 9:09 ` Krzysztof Kozlowski
2023-12-24 9:07 ` Krzysztof Kozlowski
2023-12-20 21:36 ` [PATCH v5 16/16] PCI: imx6: Add iMX95 Endpoint (EP) function support Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231221225218.GA232422-robh@kernel.org \
--to=robh@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=helgaas@kernel.org \
--cc=hongxing.zhu@nxp.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=kw@linux.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).