From: Shenghao Ding <shenghao-ding@ti.com>
To: <broonie@kernel.org>, <conor+dt@kernel.org>,
<krzysztof.kozlowski@linaro.org>
Cc: <robh+dt@kernel.org>, <andriy.shevchenko@linux.intel.com>,
<kevin-lu@ti.com>, <baojun.xu@ti.com>,
<devicetree@vger.kernel.org>, <lgirdwood@gmail.com>,
<perex@perex.cz>, <pierre-louis.bossart@linux.intel.com>,
<13916275206@139.com>, <linux-sound@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <liam.r.girdwood@intel.com>,
<soyer@irl.hu>, <tiwai@suse.de>, <peeyush@ti.com>,
<navada@ti.com>, Shenghao Ding <shenghao-ding@ti.com>
Subject: [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode
Date: Mon, 25 Dec 2023 13:39:29 +0800 [thread overview]
Message-ID: <20231225053932.1138-3-shenghao-ding@ti.com> (raw)
In-Reply-To: <20231225053932.1138-1-shenghao-ding@ti.com>
Move tas2563 from tas2562 header file to tas2781 header file, because
tas2563 only work in bypass-DSP mode with tas2562 driver. In oder to
enable DSP mode for tas2563, it has been moved to tas2781 driver. As to
the hardware part, such as register setting and DSP firmware, all these
are stored in the binary firmware. What tas2781 drivder dooes is to parse
the firmware and download them to the tas2781 or tas2563, then power on
tas2781 or tas2563. So, tas2781 driver can be resued as tas2563 driver。
Only attention will be paid to downloading corresponding firmware.
Signed-off-by: Shenghao Ding <shenghao-ding@ti.com>
---
Change in v3:
- Move tas2563 to tas2781 driver
- Add more comments on why move tas2563 to tas2781 driver
- Provide rationale in terms of bindings and hardware, not in terms of driver.
Or at least not only.
---
include/sound/tas2781.h | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/include/sound/tas2781.h b/include/sound/tas2781.h
index a6c808b22318..45be543110ac 100644
--- a/include/sound/tas2781.h
+++ b/include/sound/tas2781.h
@@ -1,13 +1,13 @@
/* SPDX-License-Identifier: GPL-2.0 */
//
-// ALSA SoC Texas Instruments TAS2781 Audio Smart Amplifier
+// ALSA SoC Texas Instruments TAS2781/TAS2563 Audio Smart Amplifier
//
// Copyright (C) 2022 - 2023 Texas Instruments Incorporated
// https://www.ti.com
//
-// The TAS2781 driver implements a flexible and configurable
+// The TAS2781/TAS2563 driver implements a flexible and configurable
// algo coefficient setting for one, two, or even multiple
-// TAS2781 chips.
+// TAS2781/TAS2563 chips.
//
// Author: Shenghao Ding <shenghao-ding@ti.com>
// Author: Kevin Lu <kevin-lu@ti.com>
@@ -60,6 +60,7 @@
enum audio_device {
TAS2781 = 0,
+ TAS2563
};
enum device_catlog_id {
--
2.34.1
next prev parent reply other threads:[~2023-12-25 5:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-25 5:39 [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Shenghao Ding
2023-12-25 5:39 ` [PATCH v3 2/5] ASoC: tas2562: move tas2563 from tas2562 driver to tas2781 driver Shenghao Ding
2023-12-27 16:50 ` Andy Shevchenko
2023-12-25 5:39 ` Shenghao Ding [this message]
2023-12-25 5:39 ` [PATCH v3 4/5] ASoC: tas2781: Add tas2563 into driver Shenghao Ding
2023-12-27 16:51 ` Andy Shevchenko
2023-12-25 5:39 ` [PATCH v3 5/5] ASoC: dt-bindings: Add tas2563 into ti,ta2781.yaml to enable DSP mode Shenghao Ding
2023-12-25 13:18 ` Krzysztof Kozlowski
2023-12-27 6:58 ` [EXTERNAL] " Ding, Shenghao
2023-12-27 11:02 ` Krzysztof Kozlowski
2023-12-25 13:12 ` [PATCH v3 1/5] ASoC: dt-bindings: move tas2563 from tas2562.yaml to tas2781.yaml Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2023-12-27 17:41 [PATCH v3 3/5] ASoC: tas2781: Add tas2563 into header file for DSP mode Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231225053932.1138-3-shenghao-ding@ti.com \
--to=shenghao-ding@ti.com \
--cc=13916275206@139.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=baojun.xu@ti.com \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kevin-lu@ti.com \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=liam.r.girdwood@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=navada@ti.com \
--cc=peeyush@ti.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=robh+dt@kernel.org \
--cc=soyer@irl.hu \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).