From: Conor Dooley <conor@kernel.org>
To: AnnanLiu <annan.liu.xdu@outlook.com>
Cc: chao.wei@sophgo.com, unicorn_wang@outlook.com,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, paul.walmsley@sifive.com,
palmer@dabbelt.com, aou@eecs.berkeley.edu,
devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] riscv: dts: sophgo: add timer dt node for CV1800
Date: Thu, 28 Dec 2023 13:36:02 +0000 [thread overview]
Message-ID: <20231228-distill-heave-ebda9ee53576@spud> (raw)
In-Reply-To: <DM6PR20MB23167E08FCA546D6C1899CB1AB9EA@DM6PR20MB2316.namprd20.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 3228 bytes --]
On Thu, Dec 28, 2023 at 09:06:54PM +0800, AnnanLiu wrote:
> Add the timer device tree node to CV1800 SoC.
> This patch depends on the clk driver and reset driver.
> Clk driver link:
> https://lore.kernel.org/all/IA1PR20MB49539CDAD9A268CBF6CA184BBB9FA@IA1PR20MB4953.namprd20.prod.outlook.com/
> Reset driver link:
> https://lore.kernel.org/all/20231113005503.2423-1-jszhang@kernel.org/
FYI, this stuff should be under the --- line.
If there's nothing else wrong with this commit, I can fix this while
applying.
Cheers,
Conor.
>
> Signed-off-by: AnnanLiu <annan.liu.xdu@outlook.com>
> ---
> arch/riscv/boot/dts/sophgo/cv1800b.dtsi | 72 +++++++++++++++++++++++++
> 1 file changed, 72 insertions(+)
>
> diff --git a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> index aec6401a467b..34a1647cc51b 100644
> --- a/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> +++ b/arch/riscv/boot/dts/sophgo/cv1800b.dtsi
> @@ -113,6 +113,78 @@ plic: interrupt-controller@70000000 {
> riscv,ndev = <101>;
> };
>
> + timer0: timer@030a0000 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0000 0x14>;
> + interrupts = <79 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER0>;
> + status = "disabled";
> + };
> +
> + timer1: timer@030a0014 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0014 0x14>;
> + interrupts = <80 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER1>;
> + status = "disabled";
> + };
> +
> + timer2: timer@030a0028 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0028 0x14>;
> + interrupts = <81 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER2>;
> + status = "disabled";
> + };
> +
> + timer3: timer@030a003c {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a003c 0x14>;
> + interrupts = <82 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER3>;
> + status = "disabled";
> + };
> +
> + timer4: timer@030a0050 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0050 0x14>;
> + interrupts = <83 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER4>;
> + status = "disabled";
> + };
> +
> + timer5: timer@30a0064 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0064 0x14>;
> + interrupts = <84 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER5>;
> + status = "disabled";
> + };
> +
> + timer6: timer@030a0078 {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a0078 0x14>;
> + interrupts = <85 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER6>;
> + status = "disabled";
> + };
> +
> + timer7: timer@030a008c {
> + compatible = "snps,dw-apb-timer";
> + reg = <0x030a008c 0x14>;
> + interrupts = <86 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&osc>;
> + resets = <&rst RST_TIMER7>;
> + status = "disabled";
> + };
> +
> clint: timer@74000000 {
> compatible = "sophgo,cv1800b-clint", "thead,c900-clint";
> reg = <0x74000000 0x10000>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-12-28 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 13:06 [PATCH] riscv: dts: sophgo: add timer dt node for CV1800 AnnanLiu
2023-12-28 13:36 ` Conor Dooley [this message]
2023-12-28 13:47 ` Emil Renner Berthing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231228-distill-heave-ebda9ee53576@spud \
--to=conor@kernel.org \
--cc=annan.liu.xdu@outlook.com \
--cc=aou@eecs.berkeley.edu \
--cc=chao.wei@sophgo.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=unicorn_wang@outlook.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox