From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mg.richtek.com (mg.richtek.com [220.130.44.152]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0B3AD4C8A; Thu, 28 Dec 2023 03:20:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=richtek.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=richtek.com X-MailGates: (SIP:2,PASS,NONE)(compute_score:DELIVER,40,3) Received: from 192.168.10.47 by mg.richtek.com with MailGates ESMTPS Server V6.0(636819:0:AUTH_RELAY) (envelope-from ) (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256/256); Thu, 28 Dec 2023 11:19:30 +0800 (CST) Received: from ex4.rt.l (192.168.10.47) by ex4.rt.l (192.168.10.47) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.27; Thu, 28 Dec 2023 11:19:29 +0800 Received: from linuxcarl2.richtek.com (192.168.10.154) by ex4.rt.l (192.168.10.45) with Microsoft SMTP Server id 15.2.1258.27 via Frontend Transport; Thu, 28 Dec 2023 11:19:29 +0800 Date: Thu, 28 Dec 2023 11:19:29 +0800 From: ChiYuan Huang To: Krzysztof Kozlowski CC: Jonathan Cameron , Krzysztof Kozlowski , Conor Dooley , Lars-Peter Clausen , Rob Herring , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , , , Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: rtq6056: add support for the whole RTQ6056 family Message-ID: <20231228031929.GA32046@linuxcarl2.richtek.com> References: <1703562468-29052-1-git-send-email-cy_huang@richtek.com> <1703562468-29052-2-git-send-email-cy_huang@richtek.com> <9715ed9d-7edf-430c-808c-00e7748bc59a@linaro.org> <20231226111921.GA22684@linuxcarl2.richtek.com> <0f1f0991-9ad9-4216-afc8-8340eddb1ad9@linaro.org> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <0f1f0991-9ad9-4216-afc8-8340eddb1ad9@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) On Tue, Dec 26, 2023 at 01:12:50PM +0100, Krzysztof Kozlowski wrote: > On 26/12/2023 12:19, ChiYuan Huang wrote: > > On Tue, Dec 26, 2023 at 10:18:47AM +0100, Krzysztof Kozlowski wrote: > >> On 26/12/2023 04:47, cy_huang@richtek.com wrote: > >>> From: ChiYuan Huang > >>> > >>> Add compatible support for RTQ6053 and RTQ6059. > >>> > >>> Signed-off-by: ChiYuan Huang > >>> --- > >>> .../devicetree/bindings/iio/adc/richtek,rtq6056.yaml | 5 ++++- > >>> 1 file changed, 4 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml > >>> index 88e008629ea8..d1e1f36d1972 100644 > >>> --- a/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml > >>> +++ b/Documentation/devicetree/bindings/iio/adc/richtek,rtq6056.yaml > >>> @@ -25,7 +25,10 @@ description: | > >>> > >>> properties: > >>> compatible: > >>> - const: richtek,rtq6056 > >>> + enum: > >>> + - richtek,rtq6053 > >>> + - richtek,rtq6056 > >> > >> Aren't these devices compatible? Your driver change says they are, so > >> express compatibility with list here (and oneOf). > >> > > Thanks, I try to take other binding as the reference. One more question. > > If rtq6053 is compatible with rtq6056, there's only chip package type difference. > > Do I need to seperate it into a dedicated enum element? > > Or just put it into one item and said this part number is compatible with rtq6056? > > See example-schema. You need enum and items, both in oneOf:. > After reading the 'example-schema', I Still cannot understand what the special case items means. But in my case, is the below change correct? [Diff] properties: compatible: - enum: - - richtek,rtq6053 - - richtek,rtq6056 - - richtek,rtq6059 + oneOf: + - items: + - enum: + - richtek,rtq6053 + - richtek,rtq6056 + - richtek,rtq6059 > Best regards, > Krzysztof >