devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v2] arm64: dts: rockchip: nanopc-t6 sdmmc device tuning
@ 2023-12-28 17:29 John Clark
  2023-12-29 22:55 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: John Clark @ 2023-12-28 17:29 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	linux-rockchip
  Cc: Thomas McKahan, devicetree, linux-arm-kernel, linux-kernel,
	John Clark

drop max-frequency = <200000000> as it is already defined in rk3588s.dtsi
order no-sdio & no-mmc properties while we are here

Signed-off-by: John Clark <inindev@gmail.com>
---
Changes since v1:
Additional scenarios need to be tested for proposed regulator and
cd-gpios changes. Withdrawing those submissions for now.
- removed proposed vcc3v3_sd_s0 regulator
- removed proposed cd-gpios
---
 arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts
index e83b71510a47..d7722772ecd8 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-nanopc-t6.dts
@@ -536,13 +536,12 @@ &sdhci {
 };
 
 &sdmmc {
-	max-frequency = <200000000>;
-	no-sdio;
-	no-mmc;
 	bus-width = <4>;
 	cap-mmc-highspeed;
 	cap-sd-highspeed;
 	disable-wp;
+	no-mmc;
+	no-sdio;
 	sd-uhs-sdr104;
 	vmmc-supply = <&vcc_3v3_s3>;
 	vqmmc-supply = <&vccio_sd_s0>;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] arm64: dts: rockchip: nanopc-t6 sdmmc device tuning
  2023-12-28 17:29 [PATCH v2] arm64: dts: rockchip: nanopc-t6 sdmmc device tuning John Clark
@ 2023-12-29 22:55 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2023-12-29 22:55 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Rob Herring, John Clark, Conor Dooley,
	linux-rockchip
  Cc: Heiko Stuebner, linux-arm-kernel, Thomas McKahan, devicetree,
	linux-kernel

On Thu, 28 Dec 2023 17:29:35 +0000, John Clark wrote:
> drop max-frequency = <200000000> as it is already defined in rk3588s.dtsi
> order no-sdio & no-mmc properties while we are here
> 
> 

Applied, thanks!

[1/1] arm64: dts: rockchip: nanopc-t6 sdmmc device tuning
      commit: 9e1faff1cbc877903d019a7943d37ddc5042704d

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2023-12-29 22:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-28 17:29 [PATCH v2] arm64: dts: rockchip: nanopc-t6 sdmmc device tuning John Clark
2023-12-29 22:55 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).