* [PATCH] docs: dt-bindings: suggest "reg-names" position in DTS Coding Style
@ 2023-12-29 5:47 Rafał Miłecki
2023-12-30 14:31 ` Krzysztof Kozlowski
0 siblings, 1 reply; 2+ messages in thread
From: Rafał Miłecki @ 2023-12-29 5:47 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: Geert Uytterhoeven, Konrad Dybcio, devicetree, linux-kernel,
linux-doc, Rafał Miłecki, Andrew Davis, Andrew Lunn,
AngeloGioacchino Del Regno, Arnd Bergmann, Bjorn Andersson,
Chen-Yu Tsai, Dmitry Baryshkov, Jonathan Corbet, Matthias Brugger,
Michal Simek, Neil Armstrong, Nishanth Menon, Olof Johansson
From: Rafał Miłecki <rafal@milecki.pl>
Property "reg-names" is strictly related to "reg" so it should follow it
directly instead of falling into "Standard/common properties". This
helps reading DTS files.
Cc: Andrew Davis <afd@ti.com>
cc: Andrew Lunn <andrew@lunn.ch>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: Bjorn Andersson <andersson@kernel.org>
Cc: Chen-Yu Tsai <wens@kernel.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: Michal Simek <michal.simek@amd.com>
Cc: Neil Armstrong <neil.armstrong@linaro.org>
Cc: Nishanth Menon <nm@ti.com>
Cc: Olof Johansson <olof@lixom.net>
Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
.../devicetree/bindings/dts-coding-style.rst | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/Documentation/devicetree/bindings/dts-coding-style.rst b/Documentation/devicetree/bindings/dts-coding-style.rst
index a9bdd2b59dca..1a48e2ca80e9 100644
--- a/Documentation/devicetree/bindings/dts-coding-style.rst
+++ b/Documentation/devicetree/bindings/dts-coding-style.rst
@@ -116,12 +116,13 @@ The following order of properties in device nodes is preferred:
1. "compatible"
2. "reg"
-3. "ranges"
-4. Standard/common properties (defined by common bindings, e.g. without
+3. "reg-names"
+4. "ranges"
+5. Standard/common properties (defined by common bindings, e.g. without
vendor-prefixes)
-5. Vendor-specific properties
-6. "status" (if applicable)
-7. Child nodes, where each node is preceded with a blank line
+6. Vendor-specific properties
+7. "status" (if applicable)
+8. Child nodes, where each node is preceded with a blank line
The "status" property is by default "okay", thus it can be omitted.
--
2.35.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] docs: dt-bindings: suggest "reg-names" position in DTS Coding Style
2023-12-29 5:47 [PATCH] docs: dt-bindings: suggest "reg-names" position in DTS Coding Style Rafał Miłecki
@ 2023-12-30 14:31 ` Krzysztof Kozlowski
0 siblings, 0 replies; 2+ messages in thread
From: Krzysztof Kozlowski @ 2023-12-30 14:31 UTC (permalink / raw)
To: Rafał Miłecki, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Geert Uytterhoeven, Konrad Dybcio, devicetree, linux-kernel,
linux-doc, Rafał Miłecki, Andrew Davis, Andrew Lunn,
AngeloGioacchino Del Regno, Arnd Bergmann, Bjorn Andersson,
Chen-Yu Tsai, Dmitry Baryshkov, Jonathan Corbet, Matthias Brugger,
Michal Simek, Neil Armstrong, Nishanth Menon, Olof Johansson
On 29/12/2023 06:47, Rafał Miłecki wrote:
> From: Rafał Miłecki <rafal@milecki.pl>
>
> Property "reg-names" is strictly related to "reg" so it should follow it
> directly instead of falling into "Standard/common properties". This
> helps reading DTS files.
All 'xxx-names' should immediately follow 'xxx'. Instead of this change,
just add a note at the bottom of this section?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-12-30 14:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-29 5:47 [PATCH] docs: dt-bindings: suggest "reg-names" position in DTS Coding Style Rafał Miłecki
2023-12-30 14:31 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).