* [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
@ 2023-12-29 20:29 David Heidelberg
2023-12-29 21:37 ` Luca Weiss
0 siblings, 1 reply; 5+ messages in thread
From: David Heidelberg @ 2023-12-29 20:29 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley
Cc: Caleb Connolly, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel
Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
Signed-off-by: David Heidelberg <david@ixit.cz>
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
1 file changed, 2 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index c2244824355a..ad8677b62bfb 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
<&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
+ power-domains = <&gcc UFS_PHY_GDSC>;
+
resets = <&ufs_mem_hc 0>;
reset-names = "ufsphy";
--
2.43.0
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
2023-12-29 20:29 [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface David Heidelberg
@ 2023-12-29 21:37 ` Luca Weiss
2023-12-29 23:18 ` David Heidelberg
2024-01-01 15:43 ` Manivannan Sadhasivam
0 siblings, 2 replies; 5+ messages in thread
From: Luca Weiss @ 2023-12-29 21:37 UTC (permalink / raw)
To: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg
Cc: Caleb Connolly, David Heidelberg, linux-arm-msm, devicetree,
linux-kernel, Manivannan Sadhasivam
On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
> Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
>
> Signed-off-by: David Heidelberg <david@ixit.cz>
> ---
> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
> 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
> clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
> <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
>
> + power-domains = <&gcc UFS_PHY_GDSC>;
> +
> resets = <&ufs_mem_hc 0>;
> reset-names = "ufsphy";
This is potentially the wrong power domain, see the conversation here:
https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/
Hopefully Mani can give some input here :)
Regards
Luca
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
2023-12-29 21:37 ` Luca Weiss
@ 2023-12-29 23:18 ` David Heidelberg
2023-12-30 23:28 ` Caleb Connolly
2024-01-01 15:43 ` Manivannan Sadhasivam
1 sibling, 1 reply; 5+ messages in thread
From: David Heidelberg @ 2023-12-29 23:18 UTC (permalink / raw)
To: Luca Weiss, Bjorn Andersson, Konrad Dybcio, Rob Herring,
Krzysztof Kozlowski, Conor Dooley
Cc: Caleb Connolly, linux-arm-msm, devicetree, linux-kernel,
Manivannan Sadhasivam
On 29/12/2023 22:37, Luca Weiss wrote:
> On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
>> Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
>>
>> Signed-off-by: David Heidelberg <david@ixit.cz>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
>> 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>> @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
>> clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
>> <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
>>
>> + power-domains = <&gcc UFS_PHY_GDSC>;
>> +
>> resets = <&ufs_mem_hc 0>;
>> reset-names = "ufsphy";
> This is potentially the wrong power domain, see the conversation here:
> https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/
Thanks, I was thinking about SDM845_MX, but then looked at rest more
closer qcom archs and thought it'll be likely GDSC (also by looking at
ufs_mem_hc reset vectors).
>
> Hopefully Mani can give some input here :)
>
> Regards
> Luca
>
>
--
David Heidelberg
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
2023-12-29 23:18 ` David Heidelberg
@ 2023-12-30 23:28 ` Caleb Connolly
0 siblings, 0 replies; 5+ messages in thread
From: Caleb Connolly @ 2023-12-30 23:28 UTC (permalink / raw)
To: David Heidelberg, Luca Weiss, Bjorn Andersson, Konrad Dybcio,
Rob Herring, Krzysztof Kozlowski, Conor Dooley
Cc: linux-arm-msm, devicetree, linux-kernel, Manivannan Sadhasivam
Hi David,
Did you boot-test this?
On 30/12/2023 00:18, David Heidelberg wrote:
> On 29/12/2023 22:37, Luca Weiss wrote:
>
>> On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
>>> Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
>>>
>>> Signed-off-by: David Heidelberg <david@ixit.cz>
>>> ---
>>> arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
>>> 100644
>>> --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
>>> @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
>>> clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
>>> <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
>>>
>>> + power-domains = <&gcc UFS_PHY_GDSC>;
>>> +
>>> resets = <&ufs_mem_hc 0>;
>>> reset-names = "ufsphy";
>> This is potentially the wrong power domain, see the conversation here:
>> https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/
> Thanks, I was thinking about SDM845_MX, but then looked at rest more
> closer qcom archs and thought it'll be likely GDSC (also by looking at
> ufs_mem_hc reset vectors).
>>
>> Hopefully Mani can give some input here :)
>>
>> Regards
>> Luca
>>
>>
--
// Caleb (they/them)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
2023-12-29 21:37 ` Luca Weiss
2023-12-29 23:18 ` David Heidelberg
@ 2024-01-01 15:43 ` Manivannan Sadhasivam
1 sibling, 0 replies; 5+ messages in thread
From: Manivannan Sadhasivam @ 2024-01-01 15:43 UTC (permalink / raw)
To: Luca Weiss
Cc: Bjorn Andersson, Konrad Dybcio, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, David Heidelberg, Caleb Connolly, linux-arm-msm,
devicetree, linux-kernel, Manivannan Sadhasivam
On Fri, Dec 29, 2023 at 10:37:56PM +0100, Luca Weiss wrote:
> On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
> > Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
> >
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
> > clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
> > <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> >
> > + power-domains = <&gcc UFS_PHY_GDSC>;
> > +
> > resets = <&ufs_mem_hc 0>;
> > reset-names = "ufsphy";
>
> This is potentially the wrong power domain, see the conversation here:
> https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/
>
Yes, GDSCs are the power domain of the controllers, not PHYs. This applies to
other peripherals such as USB, PCIe etc...
- Mani
> Hopefully Mani can give some input here :)
>
> Regards
> Luca
>
>
--
மணிவண்ணன் சதாசிவம்
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-01 15:43 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-12-29 20:29 [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface David Heidelberg
2023-12-29 21:37 ` Luca Weiss
2023-12-29 23:18 ` David Heidelberg
2023-12-30 23:28 ` Caleb Connolly
2024-01-01 15:43 ` Manivannan Sadhasivam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).