From: Arun Kumar K <arun.kk@samsung.com>
To: Kukjin Kim <kgene.kim@samsung.com>,
Karol Lewandowski <k.lewandowsk@samsung.com>
Cc: "linux-samsung-soc@vger.kernel.org"
<linux-samsung-soc@vger.kernel.org>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
Kamil Debski <k.debski@samsung.com>,
Jeongtae Park <jtp.park@samsung.com>,
"thomas.abraham@linaro.org" <thomas.abraham@linaro.org>,
Sylwester Nawrocki <s.nawrocki@samsung.com>,
NAVEEN KRISHNA CHATRADHI <ch.naveen@samsung.com>,
SUNIL JOSHI <joshi@samsung.com>,
Thomas P Abraham <thomas.ab@samsung.com>
Subject: RE: [PATCH v4] ARM: EXYNOS: Add MFC device tree support
Date: Wed, 26 Sep 2012 11:00:06 +0000 (GMT) [thread overview]
Message-ID: <20232973.290871348657205865.JavaMail.weblogic@epml02> (raw)
Hi Kukjin,
As suggested by you, the function exynos_fdt_find_mfc_mem() can be moved to plat-samsung.
I feel plat-samsung/s5p-dev-mfc.c would be a good place. Hope it is ok?
Also I will wrap it with #ifdef CONFIG_OF for non-dt mode.
I will post the updated patch with the suggested changes.
Regards
Arun
On Wed, Sep 26, 2012 at 7:42 AM, Kukjin Kim <kgene.kim@samsung.com> wrote:
> Karol Lewandowski wrote:
>>
>> On 09/22/2012 08:07 PM, Arun Kumar K wrote:
>>
>> > This patch adds device tree entry for MFC v6 in the Exynos5
>> > SoC. Makes the required changes in the clock files and adds
>> > MFC to the DT device list.
>> >
>> > Signed-off-by: Naveen Krishna Chatradhi <ch.naveen@samsung.com>
>> > Signed-off-by: Arun Kumar K <arun.kk@samsung.com>
>>
>>
>> Looks good for me. FWIW, I could probably add
>>
>> Acked-by: Karol Lewandowski <k.lewandowsk@samsung.com>
>>
> Happens following build error with exynos4_defconfig because of non-DT ?
>
> arch/arm/mach-exynos/common.c: In function 'exynos_fdt_find_mfc_mem':
> arch/arm/mach-exynos/common.c:1058: error: implicit declaration of function 'of_flat_dt_is_compatible'
> arch/arm/mach-exynos/common.c:1061: error: implicit declaration of function 'of_get_flat_dt_prop'
> arch/arm/mach-exynos/common.c:1061: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1064: error: implicit declaration of function 'of_read_ulong'
> arch/arm/mach-exynos/common.c:1066: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1071: warning: assignment makes pointer from integer without a cast
> arch/arm/mach-exynos/common.c:1076: warning: assignment makes pointer from integer without a cast
> make[1]: *** [arch/arm/mach-exynos/common.o] Error 1
>
> And I think, firstly we could move the function exynos_fdt_find_mfc_mem() into plat-samsung/ for using on other Samsung stuff such as s5pv210 and need to enclose '#ifdef CONFIG_OF" for non-DT?
>
> Thanks.
>
> Best regards,
> Kgene.
> --
> Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
> SW Solution Development Team, Samsung Electronics Co., Ltd.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next reply other threads:[~2012-09-26 11:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-26 11:00 Arun Kumar K [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-09-26 12:57 [PATCH v4] ARM: EXYNOS: Add MFC device tree support Arun Kumar K
2012-09-22 18:07 [PATCH v4] " Arun Kumar K
2012-09-22 18:07 ` [PATCH v4] ARM: EXYNOS: " Arun Kumar K
2012-09-24 8:22 ` Karol Lewandowski
2012-09-26 2:12 ` Kukjin Kim
2012-09-26 6:54 ` Tomasz Figa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20232973.290871348657205865.JavaMail.weblogic@epml02 \
--to=arun.kk@samsung.com \
--cc=ch.naveen@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=joshi@samsung.com \
--cc=jtp.park@samsung.com \
--cc=k.debski@samsung.com \
--cc=k.lewandowsk@samsung.com \
--cc=kgene.kim@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=thomas.ab@samsung.com \
--cc=thomas.abraham@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).