From: Manivannan Sadhasivam <mani@kernel.org>
To: Luca Weiss <luca@z3ntu.xyz>
Cc: Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
David Heidelberg <david@ixit.cz>,
Caleb Connolly <caleb.connolly@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Manivannan Sadhasivam <mani@kernel.org>
Subject: Re: [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface
Date: Mon, 1 Jan 2024 21:13:36 +0530 [thread overview]
Message-ID: <20240101154336.GA3280@thinkpad> (raw)
In-Reply-To: <2710291.mvXUDI8C0e@z3ntu.xyz>
On Fri, Dec 29, 2023 at 10:37:56PM +0100, Luca Weiss wrote:
> On Freitag, 29. Dezember 2023 21:29:54 CET David Heidelberg wrote:
> > Reported by: `make CHECK_DTBS=1 qcom/sdm845-oneplus-enchilada.dtb`
> >
> > Signed-off-by: David Heidelberg <david@ixit.cz>
> > ---
> > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 ++
> > 1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > b/arch/arm64/boot/dts/qcom/sdm845.dtsi index c2244824355a..ad8677b62bfb
> > 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -2644,6 +2644,8 @@ ufs_mem_phy: phy@1d87000 {
> > clocks = <&gcc GCC_UFS_MEM_CLKREF_CLK>,
> > <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> >
> > + power-domains = <&gcc UFS_PHY_GDSC>;
> > +
> > resets = <&ufs_mem_hc 0>;
> > reset-names = "ufsphy";
>
> This is potentially the wrong power domain, see the conversation here:
> https://lore.kernel.org/linux-arm-msm/20231204172829.GA69580@thinkpad/
>
Yes, GDSCs are the power domain of the controllers, not PHYs. This applies to
other peripherals such as USB, PCIe etc...
- Mani
> Hopefully Mani can give some input here :)
>
> Regards
> Luca
>
>
--
மணிவண்ணன் சதாசிவம்
prev parent reply other threads:[~2024-01-01 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-29 20:29 [PATCH] arm64: dts: qcom: sdm845: add power domain to UFS phy interface David Heidelberg
2023-12-29 21:37 ` Luca Weiss
2023-12-29 23:18 ` David Heidelberg
2023-12-30 23:28 ` Caleb Connolly
2024-01-01 15:43 ` Manivannan Sadhasivam [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240101154336.GA3280@thinkpad \
--to=mani@kernel.org \
--cc=andersson@kernel.org \
--cc=caleb.connolly@linaro.org \
--cc=conor+dt@kernel.org \
--cc=david@ixit.cz \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luca@z3ntu.xyz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).