devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b
@ 2024-01-06 20:26 Alexey Charkov
  2024-01-25 21:12 ` Heiko Stuebner
  0 siblings, 1 reply; 2+ messages in thread
From: Alexey Charkov @ 2024-01-06 20:26 UTC (permalink / raw)
  To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Heiko Stuebner,
	Sebastian Reichel, Cristian Ciocaltea, Christopher Obbard,
	Tamás Szűcs, Shreeya Patel, devicetree,
	linux-arm-kernel, linux-rockchip, linux-kernel
  Cc: Alexey Charkov

By default the GPIO pin that connects to the WiFi enable signal
inside the M.2 Key E slot is driven low, resulting in impossibility
to connect to any network. Add a DT node to expose it as an RFKILL
device, which lets the WiFi driver or userspace toggle it as
required.

Signed-off-by: Alexey Charkov <alchark@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
index 741f631db345..a5a104131403 100644
--- a/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3588-rock-5b.dts
@@ -59,6 +59,13 @@ fan: pwm-fan {
 		#cooling-cells = <2>;
 	};
 
+	rfkill {
+		compatible = "rfkill-gpio";
+		label = "rfkill-pcie-wlan";
+		radio-type = "wlan";
+		shutdown-gpios = <&gpio4 RK_PA2 GPIO_ACTIVE_HIGH>;
+	};
+
 	vcc3v3_pcie2x1l0: vcc3v3-pcie2x1l0-regulator {
 		compatible = "regulator-fixed";
 		enable-active-high;
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b
  2024-01-06 20:26 [PATCH] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b Alexey Charkov
@ 2024-01-25 21:12 ` Heiko Stuebner
  0 siblings, 0 replies; 2+ messages in thread
From: Heiko Stuebner @ 2024-01-25 21:12 UTC (permalink / raw)
  To: Alexey Charkov, Cristian Ciocaltea, Sebastian Reichel,
	linux-arm-kernel, linux-kernel, Tamás Szűcs,
	Krzysztof Kozlowski, Christopher Obbard, linux-rockchip,
	Rob Herring, Conor Dooley, devicetree, Shreeya Patel
  Cc: Heiko Stuebner

On Sun, 7 Jan 2024 00:26:45 +0400, Alexey Charkov wrote:
> By default the GPIO pin that connects to the WiFi enable signal
> inside the M.2 Key E slot is driven low, resulting in impossibility
> to connect to any network. Add a DT node to expose it as an RFKILL
> device, which lets the WiFi driver or userspace toggle it as
> required.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b
      commit: 82d40b141a4c7ab6608a84a5ce0c58b747cb7163

Best regards,
-- 
Heiko Stuebner <heiko@sntech.de>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-01-25 21:12 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-06 20:26 [PATCH] arm64: dts: rockchip: add rfkill node for M.2 Key E WiFi on rock-5b Alexey Charkov
2024-01-25 21:12 ` Heiko Stuebner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).