From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f47.google.com (mail-oa1-f47.google.com [209.85.160.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 475281118E for ; Sun, 7 Jan 2024 03:25:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="QL7ccs8L" Received: by mail-oa1-f47.google.com with SMTP id 586e51a60fabf-20400d5b54eso657791fac.1 for ; Sat, 06 Jan 2024 19:25:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704597904; x=1705202704; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=JT8PzdZBJLSbhtU2oJSCK4IIB9jqkagcV3B13A1Ehp4=; b=QL7ccs8LZfTJUu2iPhPihFPI/anIk08E6iSd+PNsX9xSYQ/VJFRIDjTYt3Cpj1hsPP ZvutDgCuKbQWcUB1mkredk3DgtXhVbuVHOvCxP1w4qLSJ1phxE1GC5aarTd08Z3h0Fax LjZLeo0+P3H2Xu59fZIhetQBK07wuTbeTfV6ST0QF/rto1qwXq1DVoFO9LcE4cCsz62e zy0NaTlG/eh4q3mTKhlqrVkF+wR46GScSO9C8rZhJqPjd0IFIxp3zC+PeEm1H4uUPdPx HmQod8PS/IEIsyP+HdB7/a5/6NtwYJCvqPCNH0YshXQluJIG7mzjvKj0opFdfmjeDHnf K09g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704597904; x=1705202704; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JT8PzdZBJLSbhtU2oJSCK4IIB9jqkagcV3B13A1Ehp4=; b=cKhm4ViRRj4PnT3pPu4yJo6Xwo3WL5CHVAo/r3EBxQyWfj4kWnvFLx9ssqklA4S4zV yp1wdPZ3ijLXGN36UWyK31/QcXGTFKdjdoOIJbzCOxBDbTZQHaMto2UJTOihKCUqXl0Z rHrjLek8B/sA584l8lT4zzLg2WxnQzLmqDk9y4ilMlbtrmaMOwLEWgXf5LjzMd7WlW1Q RBHszUr9qFyasx4VTymNSQKbluomnrmE8t7EdW7NSWFbnO5246AxLlRLAsMgWNSrCvry hbMM+Hx/zbxRfZCMJbD9cH7N4ZsMlwVj6goB9qZmUr2SqaVTpNRqWfHhly2Wye9+IgNH zwmg== X-Gm-Message-State: AOJu0YyPUftcPlXpSgwtOTCmwsJBp38s3jqwJsK4FcNHrYCsJ8oGhnMT h+/Zro+BgykOAHFyh6cTqCR/V/F6FGFO X-Google-Smtp-Source: AGHT+IHff8Egcia+tCBq4/ujZo7qI22JNBSI2y6azf6TA1QKj7wiLnydPvISo8qBHWU0i/bPamewsQ== X-Received: by 2002:a05:6870:9a1d:b0:204:521a:505f with SMTP id fo29-20020a0568709a1d00b00204521a505fmr2577606oab.57.1704597904376; Sat, 06 Jan 2024 19:25:04 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id t6-20020a63dd06000000b005b9083b81f0sm3608131pgg.36.2024.01.06.19.24.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 19:25:03 -0800 (PST) Date: Sun, 7 Jan 2024 08:54:56 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 06/16] PCI: imx6: Simplify ltssm_enable() by using ltssm_off and ltssm_mask Message-ID: <20240107032456.GE3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-7-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231227182727.1747435-7-Frank.Li@nxp.com> On Wed, Dec 27, 2023 at 01:27:17PM -0500, Frank Li wrote: > Add drvdata::ltssm_off and drvdata::ltssm_mask to simple > imx6_pcie_ltssm_enable(disable)() logic. > > Signed-off-by: Frank Li Reviewed-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v1 to v3 > - none > > drivers/pci/controller/dwc/pci-imx6.c | 37 ++++++++++++--------------- > 1 file changed, 16 insertions(+), 21 deletions(-) > > diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c > index 332c392f8e5bc..588bfb616260e 100644 > --- a/drivers/pci/controller/dwc/pci-imx6.c > +++ b/drivers/pci/controller/dwc/pci-imx6.c > @@ -75,6 +75,8 @@ struct imx6_pcie_drvdata { > int dbi_length; > const char *gpr; > const char *clk_names[IMX6_PCIE_MAX_CLKS]; > + const u32 ltssm_off; > + const u32 ltssm_mask; > }; > > struct imx6_pcie { > @@ -775,18 +777,11 @@ static int imx6_pcie_wait_for_speed_change(struct imx6_pcie *imx6_pcie) > static void imx6_pcie_ltssm_enable(struct device *dev) > { > struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); > + const struct imx6_pcie_drvdata *drvdata = imx6_pcie->drvdata; > > - switch (imx6_pcie->drvdata->variant) { > - case IMX6Q: > - case IMX6SX: > - case IMX6QP: > - regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX6Q_GPR12_PCIE_CTL_2, > - IMX6Q_GPR12_PCIE_CTL_2); > - break; > - default: > - break; > - } > + if (drvdata->ltssm_mask) > + regmap_update_bits(imx6_pcie->iomuxc_gpr, drvdata->ltssm_off, drvdata->ltssm_mask, > + drvdata->ltssm_mask); > > reset_control_deassert(imx6_pcie->apps_reset); > } > @@ -794,17 +789,11 @@ static void imx6_pcie_ltssm_enable(struct device *dev) > static void imx6_pcie_ltssm_disable(struct device *dev) > { > struct imx6_pcie *imx6_pcie = dev_get_drvdata(dev); > + const struct imx6_pcie_drvdata *drvdata = imx6_pcie->drvdata; > > - switch (imx6_pcie->drvdata->variant) { > - case IMX6Q: > - case IMX6SX: > - case IMX6QP: > - regmap_update_bits(imx6_pcie->iomuxc_gpr, IOMUXC_GPR12, > - IMX6Q_GPR12_PCIE_CTL_2, 0); > - break; > - default: > - break; > - } > + if (drvdata->ltssm_mask) > + regmap_update_bits(imx6_pcie->iomuxc_gpr, drvdata->ltssm_off, > + drvdata->ltssm_mask, 0); > > reset_control_assert(imx6_pcie->apps_reset); > } > @@ -1385,6 +1374,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { > .dbi_length = 0x200, > .gpr = "fsl,imx6q-iomuxc-gpr", > .clk_names = {"pcie_bus", "pcie", "pcie_phy"}, > + .ltssm_off = IOMUXC_GPR12, > + .ltssm_mask = IMX6Q_GPR12_PCIE_CTL_2, > }, > [IMX6SX] = { > .variant = IMX6SX, > @@ -1393,6 +1384,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { > IMX6_PCIE_FLAG_SUPPORTS_SUSPEND, > .gpr = "fsl,imx6q-iomuxc-gpr", > .clk_names = {"pcie_bus", "pcie", "pcie_phy", "pcie_inbound_axi"}, > + .ltssm_off = IOMUXC_GPR12, > + .ltssm_mask = IMX6Q_GPR12_PCIE_CTL_2, > }, > [IMX6QP] = { > .variant = IMX6QP, > @@ -1402,6 +1395,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { > .dbi_length = 0x200, > .gpr = "fsl,imx6q-iomuxc-gpr", > .clk_names = {"pcie_bus", "pcie", "pcie_phy"}, > + .ltssm_off = IOMUXC_GPR12, > + .ltssm_mask = IMX6Q_GPR12_PCIE_CTL_2, > }, > [IMX7D] = { > .variant = IMX7D, > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்