From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0015125A3 for ; Sun, 7 Jan 2024 05:35:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="UoXyuj5b" Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6dc02ab3cc9so718379a34.3 for ; Sat, 06 Jan 2024 21:35:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704605712; x=1705210512; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=QAQHK5ll+I9fqZVygsC2SG0aCFgjVutNBXAQTzwAdEM=; b=UoXyuj5bVLw675K0mpq1mL0ahXQdzWArxEUG8wScYVJE4KMH+qtwmukl89cKDEevV4 evh7n94Cr7mVTeGRQUtbteVt+LbLeOA4UMztqmpB9IGhUSi4XlgIxHiHyryMU4lIl5ln 46d//kNT+sTcDsu2P4ws5w0ejJfLq9uIMFMZjqQjjoAemke4DJ8TAgaTqBx1qSIOkYH6 EYOShYhsDqsxk3dREsEI55Fwsb2HQZNcqh4LlnKhHarRDGus56cAnnOl3PIFs7oyTIgg Su1kdJjprHd2ZvhnHQKpjxx/U57PPgXgnY/WxwNTxKhXQlvZeBSOblQ03SLW2T7QDAYt 2hXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704605712; x=1705210512; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=QAQHK5ll+I9fqZVygsC2SG0aCFgjVutNBXAQTzwAdEM=; b=nqSnvVn+8/+GKamKdf+EejufwaHYAVNZwgD3A44pOKX696F50yfrd8Rq+8s8hLFk3z wcfLdcTG9Y8k8D2qOkn54JvUgWiu5M0AjWBgy4bAVdCdy5y7V+j/lISLwY7NjWyRPI9p qJhEYZk1ZBy4+6I1pg2sUzzEqhTIt/TEA7Yae3Dcv/bO08qZWDM6zqEyZ9zYed9yA8xV nD5fGCo9F9tcJ4bjd0vPMEfGVw392QQfZK2Y69vA5iHIMxnOnWLslJ2bVupaL7ALFrfg dQVeqBaZVzt644/LgvTcXVW5QOvLMRo0ZWHRhg8VSWk37qc0NA2eq/Frmlwd1iZxr6my kiMg== X-Gm-Message-State: AOJu0YyDskn2BwdXWTZp0/503yF/xWSKUGdfb2LFjRQTpS0JEHdvn4QO QHBZeGO6ZJZPvxcgdrIN6Z1mFVWbU21v X-Google-Smtp-Source: AGHT+IHFYUUCHFOG1zw6MP5ODbboKC5GLnr9M5Rq8WdYlLjMIPfuPqb7MhRt2tmk/+KAt8X2v5uycA== X-Received: by 2002:a05:6870:2247:b0:204:3d7e:791 with SMTP id j7-20020a056870224700b002043d7e0791mr2796524oaf.17.1704605712652; Sat, 06 Jan 2024 21:35:12 -0800 (PST) Received: from thinkpad ([103.197.115.97]) by smtp.gmail.com with ESMTPSA id fb32-20020a056a002da000b006d9a48882f7sm3803258pfb.118.2024.01.06.21.35.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 06 Jan 2024 21:35:12 -0800 (PST) Date: Sun, 7 Jan 2024 11:05:05 +0530 From: Manivannan Sadhasivam To: Frank Li Cc: krzysztof.kozlowski@linaro.org, bhelgaas@google.com, conor+dt@kernel.org, devicetree@vger.kernel.org, festevam@gmail.com, helgaas@kernel.org, hongxing.zhu@nxp.com, imx@lists.linux.dev, kernel@pengutronix.de, krzysztof.kozlowski+dt@linaro.org, kw@linux.com, l.stach@pengutronix.de, linux-arm-kernel@lists.infradead.org, linux-imx@nxp.com, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, lpieralisi@kernel.org, robh@kernel.org, s.hauer@pengutronix.de, shawnguo@kernel.org Subject: Re: [PATCH v7 10/16] dt-bindings: imx6q-pcie: restruct reg and reg-name Message-ID: <20240107053505.GJ3416@thinkpad> References: <20231227182727.1747435-1-Frank.Li@nxp.com> <20231227182727.1747435-11-Frank.Li@nxp.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20231227182727.1747435-11-Frank.Li@nxp.com> On Wed, Dec 27, 2023 at 01:27:21PM -0500, Frank Li wrote: > snps,dw-pcie.yaml already have reg and reg-name information. Needn't > duplciate here. > > Add 'if' check for existed compatible string to restrict reg and reg-names. > This prepare to add new compatible string with difference reg-names sets. > > Reviewed-by: Krzysztof Kozlowski > Signed-off-by: Frank Li Acked-by: Manivannan Sadhasivam - Mani > --- > > Notes: > Change from v6 to v7 > - add Krzysztof's review tag > Change from v5 to v6 > - Add if check for existed compatible string > Change from v4 to v5 > - add Rob's Acked > Change from v1 to v4: > - new patch at v4 > > .../bindings/pci/fsl,imx6q-pcie.yaml | 30 ++++++++++++------- > 1 file changed, 20 insertions(+), 10 deletions(-) > > diff --git a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > index 81bbb8728f0f9..eeca6b7b540f9 100644 > --- a/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > +++ b/Documentation/devicetree/bindings/pci/fsl,imx6q-pcie.yaml > @@ -30,16 +30,6 @@ properties: > - fsl,imx8mm-pcie > - fsl,imx8mp-pcie > > - reg: > - items: > - - description: Data Bus Interface (DBI) registers. > - - description: PCIe configuration space region. > - > - reg-names: > - items: > - - const: dbi > - - const: config > - > clocks: > minItems: 3 > items: > @@ -90,6 +80,26 @@ required: > allOf: > - $ref: /schemas/pci/snps,dw-pcie.yaml# > - $ref: /schemas/pci/fsl,imx6q-pcie-common.yaml# > + - if: > + properties: > + compatible: > + enum: > + - fsl,imx6q-pcie > + - fsl,imx6sx-pcie > + - fsl,imx6qp-pcie > + - fsl,imx7d-pcie > + - fsl,imx8mq-pcie > + - fsl,imx8mm-pcie > + - fsl,imx8mp-pcie > + then: > + properties: > + reg: > + maxItems: 2 > + reg-names: > + items: > + - const: dbi > + - const: config > + > - if: > properties: > compatible: > -- > 2.34.1 > -- மணிவண்ணன் சதாசிவம்