From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CCA494F886; Wed, 10 Jan 2024 22:56:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="axhinZBK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B8DB5C433F1; Wed, 10 Jan 2024 22:56:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1704927383; bh=Zyd//6KwNDpLrLV+GuG4nAjU0pYfBNI8SX3KOq9P4J4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=axhinZBK6yzEcNMYnkUu3vO9vUUs2YATjWk7DgANXEsmi8H9Fah5CkS1gDExMeTn4 ldcUtSJKnRYZssRqluLG0PGvCoBMNnZkcdDXxIrv2ptRX94SYN473GTaM0stHt8zOQ eZI87OsofjSdDy9VwRKhSplkpTOM0zFTWUnflQMk6eiysiaXh8FkOilA0uit5acbQT w7uPmNWphcnTWkYv64hbzwWnvvhBsEv/MVQHH9NdOWH9fftMsENxNzwN9LpRho6h1w PIKaWCFcbav0PHCbevEJig03BKVyWKLHNwA7mHaXyLnxq/j7f1wQSN8QUkoKp8AOb2 B+/z5suK0/DNw== Received: (nullmailer pid 2864456 invoked by uid 1000); Wed, 10 Jan 2024 22:56:20 -0000 Date: Wed, 10 Jan 2024 16:56:20 -0600 From: Rob Herring To: David Lechner Cc: Mark Brown , Jonathan Cameron , Krzysztof Kozlowski , Conor Dooley , Michael Hennerich , Nuno =?iso-8859-1?Q?S=E1?= , Frank Rowand , Thierry Reding , Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= , Jonathan Corbet , linux-spi@vger.kernel.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-doc@vger.kernel.org, linux-pwm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 11/13] dt-bindings: iio: offload: add binding for PWM/DMA triggered buffer Message-ID: <20240110225620.GA2854345-robh@kernel.org> References: <20240109-axi-spi-engine-series-3-v1-0-e42c6a986580@baylibre.com> <20240109-axi-spi-engine-series-3-v1-11-e42c6a986580@baylibre.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20240109-axi-spi-engine-series-3-v1-11-e42c6a986580@baylibre.com> On Wed, Jan 10, 2024 at 01:49:52PM -0600, David Lechner wrote: > This adds a new binding for a PWM trigger and DMA data output connected > to an SPI controller offload instance. > > Signed-off-by: David Lechner > --- > .../adi,spi-offload-pwm-trigger-dma-buffer.yaml | 59 ++++++++++++++++++++++ > 1 file changed, 59 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/offload/adi,spi-offload-pwm-trigger-dma-buffer.yaml b/Documentation/devicetree/bindings/iio/offload/adi,spi-offload-pwm-trigger-dma-buffer.yaml > new file mode 100644 > index 000000000000..748cfab19eff > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/offload/adi,spi-offload-pwm-trigger-dma-buffer.yaml > @@ -0,0 +1,59 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/offload/adi,spi-offload-pwm-trigger-dma-buffer.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: SPI Offload with PWM Trigger and DMA Buffer Data Output > + > +maintainers: > + - Michael Hennerich > + - Nuno Sá > + > +description: | > + This binding describes the connection of a PWM device to the trigger input > + and a DMA channel to the output data stream of a SPI Offload instance. > + > + https://wiki.analog.com/resources/fpga/peripherals/spi_engine/offload > + https://wiki.analog.com/resources/fpga/peripherals/spi_engine/tutorial > + > +$ref: /schemas/spi/adi,axi-spi-engine.yaml#/$defs/offload Not really worth the complexity just for 'reg'. Generally, the bus schema would define general constraints on reg like range of address values and the device schema (this one) is just how many entries. > + > +properties: > + compatible: > + const: adi,spi-offload-pwm-trigger-dma-buffer > + > + reg: > + maxItems: 1 > + > + pwms: > + maxItems: 1 > + > + dmas: > + maxItems: 1 > + > +required: > + - compatible > + - pwms > + - dmas > + > +unevaluatedProperties: false > + > +examples: > + - | > + spi { > + #address-cells = <1>; > + #size-cells = <0>; > + > + offloads { > + #address-cells = <1>; > + #size-cells = <0>; > + > + offload@0 { > + compatible = "adi,spi-offload-pwm-trigger-dma-buffer"; > + reg = <0>; > + pwms = <&pwm 0>; > + dmas = <&dma 0>; > + }; > + }; Just make one complete example for the device. > + }; > > -- > 2.43.0 >