From: Jonathan Cameron <jic23@kernel.org>
To: Christian Eggers <ceggers@arri.de>
Cc: Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Javier Carrasco <javier.carrasco.cruz@gmail.com>,
<linux-iio@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] iio: light: as73211: add support for as7331
Date: Sat, 13 Jan 2024 15:15:49 +0000 [thread overview]
Message-ID: <20240113151549.2be0463e@jic23-huawei> (raw)
In-Reply-To: <4555448.LvFx2qVVIh@n95hx1g2>
> > +struct as73211_data;
> > +
> > +/**
> > + * struct spec_dev_data - device-specific data
> > + * @intensity_scale: Function to retrieve intensity scale values.
> > + * @channel: Device channels.
> > + * @num_channels: Number of channels of the device.
> > + */
> > +struct spec_dev_data {
>
> I would call it as73211_spec_dev_data (is the C++ One Definition Rule relevant for
> the kernel?)
>
> > + int (*intensity_scale)(struct as73211_data *data, int chan, int *val, int *val2);
> > + struct iio_chan_spec const *channel;
> s/channel/channels/
>
> > + int num_channels;
> > +};
Both good suggestions so I've applied them both and pushed out a new version of
the togreg tree.
Thanks,
Jonathan
next prev parent reply other threads:[~2024-01-13 15:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-03 12:08 [PATCH v2 0/3] iio: light: add support for AMS AS7331 Javier Carrasco
2024-01-03 12:08 ` [PATCH v2 1/3] iio: light: as73211: use IIO_VAL_FRACTIONAL for intensity scales Javier Carrasco
2024-01-03 12:08 ` [PATCH v2 2/3] dt-bindings: iio: light: as73211: add support for as7331 Javier Carrasco
2024-01-03 12:08 ` [PATCH v2 3/3] " Javier Carrasco
2024-01-12 9:47 ` Christian Eggers
2024-01-13 15:15 ` Jonathan Cameron [this message]
2024-01-07 15:58 ` [PATCH v2 0/3] iio: light: add support for AMS AS7331 Jonathan Cameron
2024-01-07 17:34 ` Javier Carrasco
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240113151549.2be0463e@jic23-huawei \
--to=jic23@kernel.org \
--cc=ceggers@arri.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=javier.carrasco.cruz@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).