From: Jonathan Cameron <jic23@kernel.org>
To: linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh@kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Cc: Julia Lawall <Julia.Lawall@inria.fr>,
Nicolas Palix <nicolas.palix@imag.fr>,
Sumera Priyadarsini <sylphrenadin@gmail.com>,
Jonathan Cameron <Jonathan.Cameron@huawei.com>
Subject: [PATCH 0/4] of: Automate handling of of_node_put()
Date: Sun, 14 Jan 2024 16:53:54 +0000 [thread overview]
Message-ID: <20240114165358.119916-1-jic23@kernel.org> (raw)
From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Changes since RFC: Thanks to Rob Herring for reviewing.
- Patch description typo fixes
- Add some info on the coccinelle script to patch 1. Primarily stating
that we don't seem to cause false positives with this change and that
any scripting to find cases to update like this can wait for now.
- Note the if (_T) is left in place as general consensus from similar
discussions on other cleanup.h use cases is that it can be helpful
to let the compiler optimize out the call, even when the call would
be safe with a NULL value.
Recent addition of scope based cleanup (linux/cleanup.h) allows us
to avoid a large number of places where error handlers and early
returns have to carefully deal with left over resources.
The need to call of_node_put() on breaking out of loops over child
nodes is one of these cases and this series is to address that.
A similar series has been posted for property.h equivalent case.
https://lore.kernel.org/linux-iio/20240101172611.694830-1-jic23@kernel.org/
(will be updates shortly).
If everyone is happy with this series, I'd propose an immutable branch
(either in iio.git or somewhere else) so that we can pull the first 2
patches into other trees without having to wait a whole cycle to start
making more use of this.
Jonathan Cameron (4):
of: Add cleanup.h based auto release via __free(device_node) markings.
of: unittest: Use __free(device_node)
iio: adc: fsl-imx25-gcq: Use __free(device_node)
iio: adc: rcar-gyroadc: use __free(device_node)
drivers/iio/adc/fsl-imx25-gcq.c | 12 +++---------
drivers/iio/adc/rcar-gyroadc.c | 20 ++++++--------------
drivers/of/unittest.c | 10 +++-------
include/linux/of.h | 2 ++
4 files changed, 14 insertions(+), 30 deletions(-)
--
2.43.0
next reply other threads:[~2024-01-14 16:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-14 16:53 Jonathan Cameron [this message]
2024-01-14 16:53 ` [PATCH 1/4] of: Add cleanup.h based auto release via __free(device_node) markings Jonathan Cameron
2024-01-14 16:53 ` [PATCH 2/4] of: unittest: Use __free(device_node) Jonathan Cameron
2024-01-16 18:26 ` Rob Herring
2024-01-17 17:01 ` Jonathan Cameron
2024-01-17 17:09 ` Jonathan Cameron
2024-01-17 19:47 ` Rob Herring
2024-01-17 20:13 ` Jonathan Cameron
2024-01-14 16:53 ` [PATCH 3/4] iio: adc: fsl-imx25-gcq: " Jonathan Cameron
2024-01-14 16:53 ` [PATCH 4/4] iio: adc: rcar-gyroadc: use __free(device_node) Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240114165358.119916-1-jic23@kernel.org \
--to=jic23@kernel.org \
--cc=Jonathan.Cameron@huawei.com \
--cc=Julia.Lawall@inria.fr \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-iio@vger.kernel.org \
--cc=nicolas.palix@imag.fr \
--cc=robh@kernel.org \
--cc=sylphrenadin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).