devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jonathan Cameron <Jonathan.Cameron@Huawei.com>
To: "Nuno Sá" <noname.nuno@gmail.com>
Cc: Nuno Sa via B4 Relay <devnull+nuno.sa.analog.com@kernel.org>,
	<nuno.sa@analog.com>, <linux-iio@vger.kernel.org>,
	<devicetree@vger.kernel.org>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Michael Hennerich <Michael.Hennerich@analog.com>,
	Jonathan Cameron <jic23@kernel.org>,
	"Rob Herring" <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Frank Rowand <frowand.list@gmail.com>,
	Olivier Moysan <olivier.moysan@foss.st.com>
Subject: Re: [PATCH v5 7/8] iio: adc: ad9467: convert to backend framework
Date: Mon, 15 Jan 2024 16:07:54 +0000	[thread overview]
Message-ID: <20240115160754.00002cc9@Huawei.com> (raw)
In-Reply-To: <0a7f38984f45531b1e08b20ea1d8532e1e78bf73.camel@gmail.com>

> > > +		return ret;
> > > +
> > > +	ret = iio_backend_enable(st->back);
> > > +	if (ret)
> > > +		return ret;  
> > 
> > I'm curious there is no iio_backend_disable() to be done in the exit path?
> >   
> 
> Ehehe something I have in my mind, yes. I'm just not disabling the core because
> it was the same with the previous approach. My goal was to have (more or less)
> the same state before vs after introducing the backend. I was thinking in adding
> a devm_iio_backend_enable() as a follow up patch and use it in here (or actually
> use it for the first axi-dac/dds user as that one will be come from a "clean"
> state).
> 
> If you prefer I can already turn iio_backend_enable() ->
> devm_iio_backend_enable() and use it in this patch.
Might be cleaner to do that.  Or add a big fat comment here to say it'll get
cleaned up in a follow up patch.

> 
> - Nuno Sá
> >   


  reply	other threads:[~2024-01-15 16:07 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 16:40 [PATCH v5 0/8] iio: add new backend framework Nuno Sa via B4 Relay
2024-01-12 16:40 ` [PATCH v5 1/8] dt-bindings: adc: ad9467: add new io-backend property Nuno Sa via B4 Relay
2024-01-12 16:40 ` [PATCH v5 2/8] dt-bindings: adc: axi-adc: update bindings for backend framework Nuno Sa via B4 Relay
2024-01-12 20:42   ` Rob Herring
2024-01-12 16:40 ` [PATCH v5 3/8] driver: core: allow modifying device_links flags Nuno Sa via B4 Relay
2024-01-12 16:40 ` [PATCH v5 4/8] of: property: add device link support for io-backends Nuno Sa via B4 Relay
2024-01-12 16:40 ` [PATCH v5 5/8] iio: buffer-dmaengine: export buffer alloc and free functions Nuno Sa via B4 Relay
2024-01-12 16:40 ` [PATCH v5 6/8] iio: add the IIO backend framework Nuno Sa via B4 Relay
2024-01-13 17:22   ` Jonathan Cameron
2024-01-15 10:12     ` Nuno Sá
2024-01-12 16:40 ` [PATCH v5 7/8] iio: adc: ad9467: convert to " Nuno Sa via B4 Relay
2024-01-12 17:33   ` Jonathan Cameron
2024-01-15 10:08     ` Nuno Sá
2024-01-15 16:07       ` Jonathan Cameron [this message]
2024-01-12 16:40 ` [PATCH v5 8/8] iio: adc: adi-axi-adc: move " Nuno Sa via B4 Relay
2024-01-12 17:39   ` Jonathan Cameron
2024-01-15 10:10     ` Nuno Sá

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240115160754.00002cc9@Huawei.com \
    --to=jonathan.cameron@huawei.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+nuno.sa.analog.com@kernel.org \
    --cc=frowand.list@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jic23@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=noname.nuno@gmail.com \
    --cc=nuno.sa@analog.com \
    --cc=olivier.moysan@foss.st.com \
    --cc=rafael@kernel.org \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).