[PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory

[PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory

[André Draszik]

From: André Draszik <andre.draszik@linaro.org>

Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
DT_SCHEMA_FILES") anchored all searches to the bindings directory
(since bindings only exist below that), but it turns out this is not
always desired.

Just anchor to the base kernel source directory and while at it, break
the overly long line for legibility.

Reported-by: Michal Simek <michal.simek@amd.com>
Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
Cc: Masahiro Yamada <masahiroy@kernel.org>
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 Documentation/devicetree/bindings/Makefile | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
index 2323fd5b7cda..129cf698fa8a 100644
--- a/Documentation/devicetree/bindings/Makefile
+++ b/Documentation/devicetree/bindings/Makefile
@@ -28,7 +28,10 @@ $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
 find_all_cmd = find $(srctree)/$(src) \( -name '*.yaml' ! \
 		-name 'processed-schema*' \)
 
-find_cmd = $(find_all_cmd) | sed 's|^$(srctree)/$(src)/||' | grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | sed 's|^|$(srctree)/$(src)/|'
+find_cmd = $(find_all_cmd) | \
+		sed 's|^$(srctree)/||' | \
+		grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | \
+		sed 's|^|$(srctree)/|'
 CHK_DT_DOCS := $(shell $(find_cmd))
 
 quiet_cmd_yamllint = LINT    $(src)
-- 
2.43.0

Re: [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory

[Michal Simek]

On 1/16/24 07:27, André Draszik wrote:
> From: André Draszik <andre.draszik@linaro.org>
> 
> Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
> DT_SCHEMA_FILES") anchored all searches to the bindings directory
> (since bindings only exist below that), but it turns out this is not
> always desired.
> 
> Just anchor to the base kernel source directory and while at it, break
> the overly long line for legibility.
> 
> Reported-by: Michal Simek <michal.simek@amd.com>
> Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>   Documentation/devicetree/bindings/Makefile | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/Makefile b/Documentation/devicetree/bindings/Makefile
> index 2323fd5b7cda..129cf698fa8a 100644
> --- a/Documentation/devicetree/bindings/Makefile
> +++ b/Documentation/devicetree/bindings/Makefile
> @@ -28,7 +28,10 @@ $(obj)/%.example.dts: $(src)/%.yaml check_dtschema_version FORCE
>   find_all_cmd = find $(srctree)/$(src) \( -name '*.yaml' ! \
>   		-name 'processed-schema*' \)
>   
> -find_cmd = $(find_all_cmd) | sed 's|^$(srctree)/$(src)/||' | grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | sed 's|^|$(srctree)/$(src)/|'
> +find_cmd = $(find_all_cmd) | \
> +		sed 's|^$(srctree)/||' | \
> +		grep -F -e "$(subst :," -e ",$(DT_SCHEMA_FILES))" | \
> +		sed 's|^|$(srctree)/|'
>   CHK_DT_DOCS := $(shell $(find_cmd))
>   
>   quiet_cmd_yamllint = LINT    $(src)


Tested-by: Michal Simek <michal.simek@amd.com>

Thanks,
Michal

Re: [PATCH] dt-bindings: don't anchor DT_SCHEMA_FILES to bindings directory

[Rob Herring]

On Tue, 16 Jan 2024 06:27:31 +0000, André Draszik wrote:
> From: André Draszik <andre.draszik@linaro.org>
> 
> Commit 5e3ef4546819 ("dt-bindings: ignore paths outside kernel for
> DT_SCHEMA_FILES") anchored all searches to the bindings directory
> (since bindings only exist below that), but it turns out this is not
> always desired.
> 
> Just anchor to the base kernel source directory and while at it, break
> the overly long line for legibility.
> 
> Reported-by: Michal Simek <michal.simek@amd.com>
> Closes: https://lore.kernel.org/all/827695c3-bb33-4a86-8586-2c7323530398@amd.com/
> Cc: Masahiro Yamada <masahiroy@kernel.org>
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
>  Documentation/devicetree/bindings/Makefile | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 

Added a 'Fixes' tag and applied, thanks!