devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Conor Dooley <conor@kernel.org>
To: linux-riscv@lists.infradead.org
Cc: conor@kernel.org, Conor Dooley <conor.dooley@microchip.com>,
	Daire McNamara <daire.mcnamara@microchip.com>,
	Wolfgang Grandegger <wg@grandegger.com>,
	Marc Kleine-Budde <mkl@pengutronix.de>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Michael Turquette <mturquette@baylibre.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-can@vger.kernel.org, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-clk@vger.kernel.org
Subject: [PATCH v2 2/7] dt-bindings: can: mpfs: add missing required clock
Date: Mon, 22 Jan 2024 12:19:50 +0000	[thread overview]
Message-ID: <20240122-breeder-lying-0d3668d98886@spud> (raw)
In-Reply-To: <20240122-catty-roast-d3625dbb02fe@spud>

From: Conor Dooley <conor.dooley@microchip.com>

The CAN controller on PolarFire SoC has an AHB peripheral clock _and_ a
CAN bus clock. The bus clock was omitted when the binding was written,
but is required for operation. Make up for lost time and add it.

Cautionary tale in adding bindings without having implemented a real
user for them perhaps.

Fixes: c878d518d7b6 ("dt-bindings: can: mpfs: document the mpfs CAN controller")
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 .../devicetree/bindings/net/can/microchip,mpfs-can.yaml     | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
index 45aa3de7cf01..01e4d4a54df6 100644
--- a/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
+++ b/Documentation/devicetree/bindings/net/can/microchip,mpfs-can.yaml
@@ -24,7 +24,9 @@ properties:
     maxItems: 1
 
   clocks:
-    maxItems: 1
+    items:
+      - description: AHB peripheral clock
+      - description: CAN bus clock
 
 required:
   - compatible
@@ -39,7 +41,7 @@ examples:
     can@2010c000 {
         compatible = "microchip,mpfs-can";
         reg = <0x2010c000 0x1000>;
-        clocks = <&clkcfg 17>;
+        clocks = <&clkcfg 17>, <&clkcfg 37>;
         interrupt-parent = <&plic>;
         interrupts = <56>;
     };
-- 
2.43.0


  parent reply	other threads:[~2024-01-22 12:20 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-22 12:19 [PATCH v2 0/7] MPFS clock fixes required for correct CAN clock modeling Conor Dooley
2024-01-22 12:19 ` [PATCH v2 1/7] dt-bindings: clock: mpfs: add more MSSPLL output definitions Conor Dooley
2024-01-22 12:19 ` Conor Dooley [this message]
2024-01-22 13:13   ` [PATCH v2 2/7] dt-bindings: can: mpfs: add missing required clock Marc Kleine-Budde
2024-01-22 14:21     ` Conor Dooley
2024-01-22 14:46       ` Marc Kleine-Budde
2024-01-22 14:56         ` Conor Dooley
2024-01-22 15:31           ` Marc Kleine-Budde
2024-01-22 15:47             ` Conor Dooley
2024-01-30 12:11             ` Conor Dooley
2024-01-30 13:01               ` Marc Kleine-Budde
2024-02-06 14:19                 ` Conor Dooley
2024-01-23 11:27   ` Krzysztof Kozlowski
2024-01-22 12:19 ` [PATCH v2 3/7] clk: microchip: mpfs: split MSSPLL in two Conor Dooley
2024-01-22 12:19 ` [PATCH v2 4/7] clk: microchip: mpfs: setup for using other mss pll outputs Conor Dooley
2024-01-22 12:19 ` [PATCH v2 5/7] clk: microchip: mpfs: add missing MSSPLL outputs Conor Dooley
2024-01-22 12:19 ` [PATCH v2 6/7] clk: microchip: mpfs: convert MSSPLL outputs to clk_divider Conor Dooley
2024-01-22 12:19 ` [PATCH v2 7/7] riscv: dts: microchip: add missing CAN bus clocks Conor Dooley
2024-02-06 14:27 ` (subset) [PATCH v2 0/7] MPFS clock fixes required for correct CAN clock modeling Conor Dooley

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240122-breeder-lying-0d3668d98886@spud \
    --to=conor@kernel.org \
    --cc=aou@eecs.berkeley.edu \
    --cc=conor.dooley@microchip.com \
    --cc=daire.mcnamara@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-can@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-riscv@lists.infradead.org \
    --cc=mkl@pengutronix.de \
    --cc=mturquette@baylibre.com \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=paul.walmsley@sifive.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).