* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-22 9:17 [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string Peng Fan (OSS)
@ 2024-01-22 9:30 ` Conor Dooley
2024-01-22 10:26 ` Marc Kleine-Budde
2024-02-12 13:56 ` Rob Herring
2 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2024-01-22 9:30 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: wg, mkl, conor+dt, davem, robh+dt, krzysztof.kozlowski+dt,
edumazet, kuba, pabeni, linux-can, netdev, devicetree,
linux-kernel, Peng Fan
[-- Attachment #1: Type: text/plain, Size: 1079 bytes --]
On Mon, Jan 22, 2024 at 05:17:38PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
> - fsl,imx6ul-flexcan
> - fsl,imx6sx-flexcan
> - const: fsl,imx6q-flexcan
> + - items:
> + - const: fsl,imx95-flexcan
> + - const: fsl,imx93-flexcan
> - items:
> - enum:
> - fsl,ls1028ar1-flexcan
> --
> 2.37.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-22 9:17 [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string Peng Fan (OSS)
2024-01-22 9:30 ` Conor Dooley
@ 2024-01-22 10:26 ` Marc Kleine-Budde
2024-01-22 20:56 ` Jakub Kicinski
2024-02-12 13:56 ` Rob Herring
2 siblings, 1 reply; 9+ messages in thread
From: Marc Kleine-Budde @ 2024-01-22 10:26 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: wg, conor+dt, davem, robh+dt, krzysztof.kozlowski+dt, edumazet,
kuba, pabeni, linux-can, netdev, devicetree, linux-kernel,
Peng Fan
[-- Attachment #1: Type: text/plain, Size: 1329 bytes --]
On 22.01.2024 17:17:38, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
regards,
Marc
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> index 4162469c3c08..f197d9b516bb 100644
> --- a/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> +++ b/Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml
> @@ -38,6 +38,9 @@ properties:
> - fsl,imx6ul-flexcan
> - fsl,imx6sx-flexcan
> - const: fsl,imx6q-flexcan
> + - items:
> + - const: fsl,imx95-flexcan
> + - const: fsl,imx93-flexcan
> - items:
> - enum:
> - fsl,ls1028ar1-flexcan
> --
> 2.37.1
>
>
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung Nürnberg | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-22 10:26 ` Marc Kleine-Budde
@ 2024-01-22 20:56 ` Jakub Kicinski
2024-01-23 7:00 ` Peng Fan
0 siblings, 1 reply; 9+ messages in thread
From: Jakub Kicinski @ 2024-01-22 20:56 UTC (permalink / raw)
To: Marc Kleine-Budde
Cc: Peng Fan (OSS), wg, conor+dt, davem, robh+dt,
krzysztof.kozlowski+dt, edumazet, pabeni, linux-can, netdev,
devicetree, linux-kernel, Peng Fan
On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> >
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>
> Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
Hm, you don't apply CAN DTB patches?
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-22 20:56 ` Jakub Kicinski
@ 2024-01-23 7:00 ` Peng Fan
2024-01-31 14:57 ` Rob Herring
0 siblings, 1 reply; 9+ messages in thread
From: Peng Fan @ 2024-01-23 7:00 UTC (permalink / raw)
To: Jakub Kicinski, Marc Kleine-Budde
Cc: Peng Fan (OSS), wg@grandegger.com, conor+dt@kernel.org,
davem@davemloft.net, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, edumazet@google.com,
pabeni@redhat.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
>
> On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > >
> > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> >
> > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
>
> Hm, you don't apply CAN DTB patches?
Nope. I am preparing dt-binding first, then post the i.MX95 SoC
dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
single patch only for CAN node.
Thanks,
Peng.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-23 7:00 ` Peng Fan
@ 2024-01-31 14:57 ` Rob Herring
2024-01-31 23:22 ` Peng Fan
0 siblings, 1 reply; 9+ messages in thread
From: Rob Herring @ 2024-01-31 14:57 UTC (permalink / raw)
To: Peng Fan
Cc: Jakub Kicinski, Marc Kleine-Budde, Peng Fan (OSS),
wg@grandegger.com, conor+dt@kernel.org, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, edumazet@google.com,
pabeni@redhat.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> >
> > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > >
> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > >
> > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> >
> > Hm, you don't apply CAN DTB patches?
>
> Nope. I am preparing dt-binding first, then post the i.MX95 SoC
> dtsi. The CAN will be in the i.MX95 SOC dtsi file, not a
> single patch only for CAN node.
The question was why isn't Marc, the CAN maintainer, applying this. I
have the same question.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-31 14:57 ` Rob Herring
@ 2024-01-31 23:22 ` Peng Fan
2024-02-01 18:40 ` Conor Dooley
0 siblings, 1 reply; 9+ messages in thread
From: Peng Fan @ 2024-01-31 23:22 UTC (permalink / raw)
To: Rob Herring
Cc: Jakub Kicinski, Marc Kleine-Budde, Peng Fan (OSS),
wg@grandegger.com, conor+dt@kernel.org, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, edumazet@google.com,
pabeni@redhat.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
> Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> string
>
> On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > compatible string
> > >
> > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > >
> > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > >
> > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > >
> > > Hm, you don't apply CAN DTB patches?
> >
> > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > for CAN node.
>
> The question was why isn't Marc, the CAN maintainer, applying this. I have
> the same question.
That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
patch file, it will be in a separate patchset with some i.MX95 patches.
Thanks,
Peng.
>
> Rob
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-31 23:22 ` Peng Fan
@ 2024-02-01 18:40 ` Conor Dooley
0 siblings, 0 replies; 9+ messages in thread
From: Conor Dooley @ 2024-02-01 18:40 UTC (permalink / raw)
To: Peng Fan
Cc: Rob Herring, Jakub Kicinski, Marc Kleine-Budde, Peng Fan (OSS),
wg@grandegger.com, conor+dt@kernel.org, davem@davemloft.net,
krzysztof.kozlowski+dt@linaro.org, edumazet@google.com,
pabeni@redhat.com, linux-can@vger.kernel.org,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]
On Wed, Jan 31, 2024 at 11:22:49PM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible
> > string
> >
> > On Tue, Jan 23, 2024 at 07:00:27AM +0000, Peng Fan wrote:
> > > > Subject: Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95
> > > > compatible string
> > > >
> > > > On Mon, 22 Jan 2024 11:26:25 +0100 Marc Kleine-Budde wrote:
> > > > > > Add i.MX95 flexcan which is compatible i.MX93 flexcan
> > > > > >
> > > > > > Signed-off-by: Peng Fan <peng.fan@nxp.com>
> > > > >
> > > > > Acked-by: Marc Kleine-Budde <mkl@pengutronix.de>
> > > >
> > > > Hm, you don't apply CAN DTB patches?
> > >
> > > Nope. I am preparing dt-binding first, then post the i.MX95 SoC dtsi.
> > > The CAN will be in the i.MX95 SOC dtsi file, not a single patch only
> > > for CAN node.
> >
> > The question was why isn't Marc, the CAN maintainer, applying this. I have
> > the same question.
>
> That's fine, let's drop this patch, the CAN node will not be put in my soc dtsi
> patch file, it will be in a separate patchset with some i.MX95 patches.
I am confused. This patch (for the binding) needs to be applied
regardless of what you are doing with your soc dtsi file.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string
2024-01-22 9:17 [PATCH] dt-bindings: can: fsl,flexcan: add i.MX95 compatible string Peng Fan (OSS)
2024-01-22 9:30 ` Conor Dooley
2024-01-22 10:26 ` Marc Kleine-Budde
@ 2024-02-12 13:56 ` Rob Herring
2 siblings, 0 replies; 9+ messages in thread
From: Rob Herring @ 2024-02-12 13:56 UTC (permalink / raw)
To: Peng Fan (OSS)
Cc: davem, edumazet, devicetree, linux-kernel, conor+dt, Peng Fan,
kuba, wg, robh+dt, krzysztof.kozlowski+dt, pabeni, linux-can,
netdev, mkl
On Mon, 22 Jan 2024 17:17:38 +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
>
> Add i.MX95 flexcan which is compatible i.MX93 flexcan
>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
> Documentation/devicetree/bindings/net/can/fsl,flexcan.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
It seems this isn't getting applied to CAN tree, so I applied it.
Rob
^ permalink raw reply [flat|nested] 9+ messages in thread