From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E10AA50A75; Tue, 23 Jan 2024 00:39:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.140.110.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705970392; cv=none; b=nW/1Chat5ysNXFeNvk+egfUHqv2zqbsPJVMl9bHheD+9z+nYW0l8ymA3lsQpr8/mVU41gTMatXUiQEEY6+EBJd7bRRvcmfL5dSfDVc5Qsio4GrvGnRlsiJh85GWBGfburiqPdQUbJpYr//DRF74ONPkY2SC+wAF/xcISi0RvoSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1705970392; c=relaxed/simple; bh=/c8wDG5UxtxoAwAuatiMUYKoX68PJuZG3V53bYgLges=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=JzdR2nZhzwYDaP5df9moU6W1A0DVEz8Hr+aLED6YVTzJrj+i71jG3JNyWco8/eGUqhIMrTvIq7tifAtPA4sDwwufFq/dib7oL/cJjx4Npmyqj8s1oWM8b34GPd8zKO3L5WOJZ+/JKwwu6FYqT8Z598dUouDLfQWizdvEf5QYQ5w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com; spf=pass smtp.mailfrom=arm.com; arc=none smtp.client-ip=217.140.110.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=arm.com Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C93DE1FB; Mon, 22 Jan 2024 16:40:34 -0800 (PST) Received: from minigeek.lan (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id C62203F73F; Mon, 22 Jan 2024 16:39:46 -0800 (PST) Date: Tue, 23 Jan 2024 00:38:53 +0000 From: Andre Przywara To: Chen-Yu Tsai Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , Samuel Holland , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Vinod Koul , Chen-Yu Tsai , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-sound@vger.kernel.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/7] ASoC: sunxi: sun4i-spdif: Add support for Allwinner H616 Message-ID: <20240123003853.3da2ff57@minigeek.lan> In-Reply-To: <20240122170518.3090814-4-wens@kernel.org> References: <20240122170518.3090814-1-wens@kernel.org> <20240122170518.3090814-4-wens@kernel.org> Organization: Arm Ltd. X-Mailer: Claws Mail 4.2.0 (GTK 3.24.31; x86_64-slackware-linux-gnu) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 23 Jan 2024 01:05:14 +0800 Chen-Yu Tsai wrote: Hi Chen-Yu, thanks for posting this! > From: Chen-Yu Tsai > > The SPDIF hardware block found in the H616 SoC has the same layout as > the one found in the H6 SoC, except that it is missing the receiver > side. > > Since the driver currently only supports the transmit function, support > for the H616 is identical to what is currently done for the H6. I compared the OWA manual sections of the H6 and the H616 manuals, and can confirm that indeed the H616 is the same as the H6, minus the RX part: > Signed-off-by: Chen-Yu Tsai Reviewed-by: Andre Przywara Cheers, Andre > --- > sound/soc/sunxi/sun4i-spdif.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/sound/soc/sunxi/sun4i-spdif.c b/sound/soc/sunxi/sun4i-spdif.c > index 702386823d17..f41c30955857 100644 > --- a/sound/soc/sunxi/sun4i-spdif.c > +++ b/sound/soc/sunxi/sun4i-spdif.c > @@ -577,6 +577,11 @@ static const struct of_device_id sun4i_spdif_of_match[] = { > .compatible = "allwinner,sun50i-h6-spdif", > .data = &sun50i_h6_spdif_quirks, > }, > + { > + .compatible = "allwinner,sun50i-h616-spdif", > + /* Essentially the same as the H6, but without RX */ > + .data = &sun50i_h6_spdif_quirks, > + }, > { /* sentinel */ } > }; > MODULE_DEVICE_TABLE(of, sun4i_spdif_of_match);