From: Wenhua Lin <Wenhua.Lin@unisoc.com>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
"Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>
Cc: Orson Zhai <orsonzhai@gmail.com>,
Baolin Wang <baolin.wang@linux.alibaba.com>,
Chunyan Zhang <zhang.lyra@gmail.com>, <linux-pwm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
wenhua lin <wenhua.lin1994@gmail.com>,
Wenhua Lin <Wenhua.Lin@unisoc.com>,
Xiongpeng Wu <xiongpeng.wu@unisoc.com>,
zhaochen su <zhaochen.su29@gmail.com>,
Zhaochen Su <Zhaochen.Su@unisoc.com>,
Xiaolong Wang <Xiaolong.Wang@unisoc.com>
Subject: [PATCH V2 1/6] pwm: sprd: Add support for UMS9620
Date: Thu, 25 Jan 2024 10:55:28 +0800 [thread overview]
Message-ID: <20240125025533.10315-2-Wenhua.Lin@unisoc.com> (raw)
In-Reply-To: <20240125025533.10315-1-Wenhua.Lin@unisoc.com>
The PMW unit on the current Unisoc's SoCs has 4 channels but has different
address offsets. On UMS512, they are 0x0, 0x20, 0x40, 0x60 respectively,
while are 0x0, 0x4000, 0x8000, 0xC000 on UMS9620.
Signed-off-by: Wenhua Lin <Wenhua.Lin@unisoc.com>
---
drivers/pwm/pwm-sprd.c | 28 ++++++++++++++++++++++++----
1 file changed, 24 insertions(+), 4 deletions(-)
diff --git a/drivers/pwm/pwm-sprd.c b/drivers/pwm/pwm-sprd.c
index 77939e161006..bc1e3ed13528 100644
--- a/drivers/pwm/pwm-sprd.c
+++ b/drivers/pwm/pwm-sprd.c
@@ -9,6 +9,7 @@
#include <linux/math64.h>
#include <linux/mod_devicetable.h>
#include <linux/module.h>
+#include <linux/of.h>
#include <linux/platform_device.h>
#include <linux/pwm.h>
@@ -23,7 +24,6 @@
#define SPRD_PWM_ENABLE_BIT BIT(0)
#define SPRD_PWM_CHN_NUM 4
-#define SPRD_PWM_REGS_SHIFT 5
#define SPRD_PWM_CHN_CLKS_NUM 2
#define SPRD_PWM_CHN_OUTPUT_CLK 1
@@ -32,14 +32,27 @@ struct sprd_pwm_chn {
u32 clk_rate;
};
+struct sprd_pwm_data {
+ int reg_shift;
+};
+
struct sprd_pwm_chip {
void __iomem *base;
struct device *dev;
struct pwm_chip chip;
+ const struct sprd_pwm_data *pdata;
int num_pwms;
struct sprd_pwm_chn chn[SPRD_PWM_CHN_NUM];
};
+static const struct sprd_pwm_data ums512_data = {
+ .reg_shift = 5,
+};
+
+static const struct sprd_pwm_data ums9620_data = {
+ .reg_shift = 14,
+};
+
static inline struct sprd_pwm_chip* sprd_pwm_from_chip(struct pwm_chip *chip)
{
return container_of(chip, struct sprd_pwm_chip, chip);
@@ -58,7 +71,7 @@ static const char * const sprd_pwm_clks[] = {
static u32 sprd_pwm_read(struct sprd_pwm_chip *spc, u32 hwid, u32 reg)
{
- u32 offset = reg + (hwid << SPRD_PWM_REGS_SHIFT);
+ u32 offset = reg + (hwid << spc->pdata->reg_shift);
return readl_relaxed(spc->base + offset);
}
@@ -66,7 +79,7 @@ static u32 sprd_pwm_read(struct sprd_pwm_chip *spc, u32 hwid, u32 reg)
static void sprd_pwm_write(struct sprd_pwm_chip *spc, u32 hwid,
u32 reg, u32 val)
{
- u32 offset = reg + (hwid << SPRD_PWM_REGS_SHIFT);
+ u32 offset = reg + (hwid << spc->pdata->reg_shift);
writel_relaxed(val, spc->base + offset);
}
@@ -253,6 +266,7 @@ static int sprd_pwm_clk_init(struct sprd_pwm_chip *spc)
static int sprd_pwm_probe(struct platform_device *pdev)
{
struct sprd_pwm_chip *spc;
+ const void *priv;
int ret;
spc = devm_kzalloc(&pdev->dev, sizeof(*spc), GFP_KERNEL);
@@ -263,6 +277,11 @@ static int sprd_pwm_probe(struct platform_device *pdev)
if (IS_ERR(spc->base))
return PTR_ERR(spc->base);
+ priv = of_device_get_match_data(&pdev->dev);
+ if (!priv)
+ return dev_err_probe(&pdev->dev, -EINVAL, "get regs shift failed!\n");
+ spc->pdata = priv;
+
spc->dev = &pdev->dev;
ret = sprd_pwm_clk_init(spc);
@@ -281,7 +300,8 @@ static int sprd_pwm_probe(struct platform_device *pdev)
}
static const struct of_device_id sprd_pwm_of_match[] = {
- { .compatible = "sprd,ums512-pwm", },
+ { .compatible = "sprd,ums512-pwm", .data = (void *)&ums512_data},
+ { .compatible = "sprd,ums9620-pwm", .data = (void *)&ums9620_data},
{ },
};
MODULE_DEVICE_TABLE(of, sprd_pwm_of_match);
--
2.17.1
next prev parent reply other threads:[~2024-01-25 3:09 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-25 2:55 [PATCH V2 0/6] pwm: sprd: Modification of UNISOC Platform PWM Driver Wenhua Lin
2024-01-25 2:55 ` Wenhua Lin [this message]
2024-01-26 7:24 ` [PATCH V2 1/6] pwm: sprd: Add support for UMS9620 Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 2/6] pwm: sprd: Improve the pwm backlight control function Wenhua Lin
2024-01-25 7:20 ` Chunyan Zhang
2024-01-25 21:13 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 3/6] pwm: sprd: Optimize the calculation method of duty Wenhua Lin
2024-01-26 7:30 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 4/6] dt-bindings: pwm: sprd: Convert to YAML Wenhua Lin
2024-01-25 17:31 ` Conor Dooley
2024-01-30 22:17 ` Rob Herring
2024-01-25 2:55 ` [PATCH V2 5/6] pwm: sprd: Add sprd,ums9620-pwm compatible Wenhua Lin
2024-01-25 21:08 ` Uwe Kleine-König
2024-01-25 2:55 ` [PATCH V2 6/6] dt-bindings: pwm: sprd: Add sprd,mod attribute Wenhua Lin
2024-01-25 17:24 ` Conor Dooley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240125025533.10315-2-Wenhua.Lin@unisoc.com \
--to=wenhua.lin@unisoc.com \
--cc=Xiaolong.Wang@unisoc.com \
--cc=Zhaochen.Su@unisoc.com \
--cc=baolin.wang@linux.alibaba.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=robh+dt@kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
--cc=wenhua.lin1994@gmail.com \
--cc=xiongpeng.wu@unisoc.com \
--cc=zhang.lyra@gmail.com \
--cc=zhaochen.su29@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).