* [PATCH 0/2] bluetooth: mt7921s: Add binding and fixup existing dts
@ 2024-01-25 9:52 Chen-Yu Tsai
2024-01-25 9:52 ` [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Chen-Yu Tsai
2024-01-25 9:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node Chen-Yu Tsai
0 siblings, 2 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2024-01-25 9:52 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, Sean Wang, linux-bluetooth, netdev, linux-mediatek,
devicetree, linux-arm-kernel, linux-kernel
Hi everyone,
This short series adds a binding document for the MT7921S SDIO Bluetooth
controller. The MT7921S is a SDIO-based WiFi/Bluetooth combo. WiFi and
Bluetooth are separate SDIO functions. The chip has extra per-subsystem
reset lines that can reset only WiFi or Bluetooth cores.
Patch 1 documents the SDIO function and the reset line, based on
existing device tree and driver usage. I listed Sean Wang, the original
driver author and maintainer, as the maintainer of the binding.
Patch 2 fixes up the sole existing usage of the compatible string by
making it a proper SDIO function node.
Please take a look. Not sure which tree patch 1 should be merged
through? I suppose with proper acks it could go through the soc/mediatek
tree together with patch 2.
Regards
ChenYu
Chen-Yu Tsai (2):
dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node
.../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
MAINTAINERS | 1 +
.../mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 +-
3 files changed, 52 insertions(+), 1 deletion(-)
create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
--
2.43.0.429.g432eaa2c6b-goog
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
2024-01-25 9:52 [PATCH 0/2] bluetooth: mt7921s: Add binding and fixup existing dts Chen-Yu Tsai
@ 2024-01-25 9:52 ` Chen-Yu Tsai
2024-01-25 11:39 ` AngeloGioacchino Del Regno
2024-01-26 3:02 ` Rob Herring
2024-01-25 9:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node Chen-Yu Tsai
1 sibling, 2 replies; 8+ messages in thread
From: Chen-Yu Tsai @ 2024-01-25 9:52 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, Sean Wang, linux-bluetooth, netdev, linux-mediatek,
devicetree, linux-arm-kernel, linux-kernel
The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over
SDIO. While the Bluetooth function is fully discoverable, the chip
has a pin that can reset just the Bluetooth side, as opposed to the
full chip. This needs to be described in the device tree.
Add a device tree binding for MT7921S Bluetooth over SDIO specifically
ot document the reset line.
Cc: Sean Wang <sean.wang@mediatek.com>
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
.../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
MAINTAINERS | 1 +
2 files changed, 50 insertions(+)
create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
new file mode 100644
index 000000000000..bbe240e7cc40
--- /dev/null
+++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
@@ -0,0 +1,49 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: MediaTek MT7921S Bluetooth
+
+description:
+ This binding describes the Bluetooth side of the SDIO-attached MT7921S
+ WiFi+Bluetooth combo chips. These chips are dual-radio chips supporting
+ WiFi and Bluetooth. Bluetooth works over SDIO just like WiFi. Bluetooth
+ has its own reset line, separate from WiFi, which can be used to reset
+ the Bluetooth core.
+
+maintainers:
+ - Sean Wang <sean.wang@mediatek.com>
+
+properties:
+ compatible:
+ enum:
+ - mediatek,mt7921s-bluetooth
+ reg:
+ const: 2
+
+ reset-gpios:
+ maxItems: 1
+ description: A GPIO line connected to the Bluetooth subsystem reset line.
+ Typically the W_DISABLE2# pin on M.2 E-key modules. If present this
+ shall be flagged as active low.
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ mmc {
+ #address-cells = <1>;
+ #size-cells = <0>;
+
+ bluetooth@2 {
+ compatible = "mediatek,mt7921s-bluetooth";
+ reg = <2>;
+ reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>;
+ };
+ };
diff --git a/MAINTAINERS b/MAINTAINERS
index b64a64ca7916..662957146852 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -13657,6 +13657,7 @@ M: Sean Wang <sean.wang@mediatek.com>
L: linux-bluetooth@vger.kernel.org
L: linux-mediatek@lists.infradead.org (moderated for non-subscribers)
S: Maintained
+F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt
F: drivers/bluetooth/btmtkuart.c
--
2.43.0.429.g432eaa2c6b-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node
2024-01-25 9:52 [PATCH 0/2] bluetooth: mt7921s: Add binding and fixup existing dts Chen-Yu Tsai
2024-01-25 9:52 ` [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Chen-Yu Tsai
@ 2024-01-25 9:52 ` Chen-Yu Tsai
2024-01-25 11:40 ` AngeloGioacchino Del Regno
1 sibling, 1 reply; 8+ messages in thread
From: Chen-Yu Tsai @ 2024-01-25 9:52 UTC (permalink / raw)
To: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger,
AngeloGioacchino Del Regno
Cc: Chen-Yu Tsai, Sean Wang, linux-bluetooth, netdev, linux-mediatek,
devicetree, linux-arm-kernel, linux-kernel
Bluetooth is not a random device connected to the MMC/SD controller. It
is function 2 of the SDIO device.
Fix the address of the bluetooth node. Also fix the node name and drop
the label.
Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board")
Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
---
arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
index a2e74b829320..6a7ae616512d 100644
--- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
+++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi-pico6.dts
@@ -82,7 +82,8 @@ pins-clk {
};
&mmc1 {
- bt_reset: bt-reset {
+ bluetooth@2 {
+ reg = <2>;
compatible = "mediatek,mt7921s-bluetooth";
pinctrl-names = "default";
pinctrl-0 = <&bt_pins_reset>;
--
2.43.0.429.g432eaa2c6b-goog
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
2024-01-25 9:52 ` [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Chen-Yu Tsai
@ 2024-01-25 11:39 ` AngeloGioacchino Del Regno
2024-01-26 3:26 ` Chen-Yu Tsai
2024-01-26 3:02 ` Rob Herring
1 sibling, 1 reply; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-25 11:39 UTC (permalink / raw)
To: Chen-Yu Tsai, Marcel Holtmann, Luiz Augusto von Dentz,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger
Cc: Sean Wang, linux-bluetooth, netdev, linux-mediatek, devicetree,
linux-arm-kernel, linux-kernel
Il 25/01/24 10:52, Chen-Yu Tsai ha scritto:
> The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over
> SDIO. While the Bluetooth function is fully discoverable, the chip
> has a pin that can reset just the Bluetooth side, as opposed to the
> full chip. This needs to be described in the device tree.
>
> Add a device tree binding for MT7921S Bluetooth over SDIO specifically
> ot document the reset line.
>
> Cc: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>
> diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> new file mode 100644
> index 000000000000..bbe240e7cc40
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> @@ -0,0 +1,49 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: MediaTek MT7921S Bluetooth
> +
title:
maintainers:
description:
... and then, you missed
allOf:
- $ref: bluetooth-controller.yaml#
Everything else looks good.
Cheers,
Angelo
> +description:
MT7921S is a (dual?) SDIO-attached dual-radio WiFi+Bluetooth combo chip;
this chip has two dedicated reset lines, one of which is used to reset
the Bluetooth core.
The WiFi part of this chip is described in ....where? :-)
> + This binding describes the Bluetooth side of the SDIO-attached MT7921S
> + WiFi+Bluetooth combo chips. These chips are dual-radio chips supporting
> + WiFi and Bluetooth. Bluetooth works over SDIO just like WiFi. Bluetooth
> + has its own reset line, separate from WiFi, which can be used to reset
> + the Bluetooth core.
> +
> +maintainers:
> + - Sean Wang <sean.wang@mediatek.com>
> +
> +properties:
> + compatible:
> + enum:
> + - mediatek,mt7921s-bluetooth
> + reg:
> + const: 2
> +
> + reset-gpios:
> + maxItems: 1
> + description: A GPIO line connected to the Bluetooth subsystem reset line.
> + Typically the W_DISABLE2# pin on M.2 E-key modules. If present this
> + shall be flagged as active low.
description:
An active-low reset line connected for the Bluetooth core;
on typical M.2 Key-E modules this is the W_DISABLE2# pin.
Cheers,
Angelo
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + mmc {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + bluetooth@2 {
> + compatible = "mediatek,mt7921s-bluetooth";
> + reg = <2>;
> + reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>;
> + };
> + };
> diff --git a/MAINTAINERS b/MAINTAINERS
> index b64a64ca7916..662957146852 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -13657,6 +13657,7 @@ M: Sean Wang <sean.wang@mediatek.com>
> L: linux-bluetooth@vger.kernel.org
> L: linux-mediatek@lists.infradead.org (moderated for non-subscribers)
> S: Maintained
> +F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt
> F: drivers/bluetooth/btmtkuart.c
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node
2024-01-25 9:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node Chen-Yu Tsai
@ 2024-01-25 11:40 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-25 11:40 UTC (permalink / raw)
To: Chen-Yu Tsai, Marcel Holtmann, Luiz Augusto von Dentz,
Rob Herring, Krzysztof Kozlowski, Conor Dooley, Matthias Brugger
Cc: Sean Wang, linux-bluetooth, netdev, linux-mediatek, devicetree,
linux-arm-kernel, linux-kernel
Il 25/01/24 10:52, Chen-Yu Tsai ha scritto:
> Bluetooth is not a random device connected to the MMC/SD controller. It
> is function 2 of the SDIO device.
>
> Fix the address of the bluetooth node. Also fix the node name and drop
> the label.
>
> Fixes: 055ef10ccdd4 ("arm64: dts: mt8183: Add jacuzzi pico/pico6 board")
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
2024-01-25 9:52 ` [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Chen-Yu Tsai
2024-01-25 11:39 ` AngeloGioacchino Del Regno
@ 2024-01-26 3:02 ` Rob Herring
1 sibling, 0 replies; 8+ messages in thread
From: Rob Herring @ 2024-01-26 3:02 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Sean Wang, Krzysztof Kozlowski, devicetree, Matthias Brugger,
Luiz Augusto von Dentz, Marcel Holtmann, netdev, linux-arm-kernel,
linux-mediatek, linux-kernel, AngeloGioacchino Del Regno,
Rob Herring, Conor Dooley, linux-bluetooth
On Thu, 25 Jan 2024 17:52:37 +0800, Chen-Yu Tsai wrote:
> The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over
> SDIO. While the Bluetooth function is fully discoverable, the chip
> has a pin that can reset just the Bluetooth side, as opposed to the
> full chip. This needs to be described in the device tree.
>
> Add a device tree binding for MT7921S Bluetooth over SDIO specifically
> ot document the reset line.
>
> Cc: Sean Wang <sean.wang@mediatek.com>
> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> ---
> .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 50 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>
My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):
yamllint warnings/errors:
dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.example.dts:25.39-40 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2
doc reference errors (make refcheckdocs):
See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240125095240.2308340-2-wenst@chromium.org
The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.
If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:
pip3 install dtschema --upgrade
Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
2024-01-25 11:39 ` AngeloGioacchino Del Regno
@ 2024-01-26 3:26 ` Chen-Yu Tsai
2024-01-26 9:12 ` AngeloGioacchino Del Regno
0 siblings, 1 reply; 8+ messages in thread
From: Chen-Yu Tsai @ 2024-01-26 3:26 UTC (permalink / raw)
To: AngeloGioacchino Del Regno
Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, Sean Wang,
linux-bluetooth, netdev, linux-mediatek, devicetree,
linux-arm-kernel, linux-kernel
On Thu, Jan 25, 2024 at 7:39 PM AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com> wrote:
>
> Il 25/01/24 10:52, Chen-Yu Tsai ha scritto:
> > The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over
> > SDIO. While the Bluetooth function is fully discoverable, the chip
> > has a pin that can reset just the Bluetooth side, as opposed to the
> > full chip. This needs to be described in the device tree.
> >
> > Add a device tree binding for MT7921S Bluetooth over SDIO specifically
> > ot document the reset line.
> >
> > Cc: Sean Wang <sean.wang@mediatek.com>
> > Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
> > ---
> > .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
> > MAINTAINERS | 1 +
> > 2 files changed, 50 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> > new file mode 100644
> > index 000000000000..bbe240e7cc40
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> > @@ -0,0 +1,49 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MediaTek MT7921S Bluetooth
> > +
>
> title:
>
> maintainers:
>
> description:
>
> ... and then, you missed
>
> allOf:
> - $ref: bluetooth-controller.yaml#
(facepalm)
> Everything else looks good.
>
> Cheers,
> Angelo
>
> > +description:
>
> MT7921S is a (dual?) SDIO-attached dual-radio WiFi+Bluetooth combo chip;
> this chip has two dedicated reset lines, one of which is used to reset
> the Bluetooth core.
> The WiFi part of this chip is described in ....where? :-)
The function itself is fully probable and the implementation doesn't make
use of the WiFi's reset line, so I don't see any reason to describe it?
I don't actually know what the reset line does in the chip hardware.
This patch is just described what is already used.
> > + This binding describes the Bluetooth side of the SDIO-attached MT7921S
> > + WiFi+Bluetooth combo chips. These chips are dual-radio chips supporting
> > + WiFi and Bluetooth. Bluetooth works over SDIO just like WiFi. Bluetooth
> > + has its own reset line, separate from WiFi, which can be used to reset
> > + the Bluetooth core.
> > +
> > +maintainers:
> > + - Sean Wang <sean.wang@mediatek.com>
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - mediatek,mt7921s-bluetooth
> > + reg:
> > + const: 2
> > +
> > + reset-gpios:
> > + maxItems: 1
> > + description: A GPIO line connected to the Bluetooth subsystem reset line.
> > + Typically the W_DISABLE2# pin on M.2 E-key modules. If present this
> > + shall be flagged as active low.
>
> description:
> An active-low reset line connected for the Bluetooth core;
connected to?
> on typical M.2 Key-E modules this is the W_DISABLE2# pin.
Otherwise this looks better. Thanks.
ChenYu
> Cheers,
> Angelo
>
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + mmc {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + bluetooth@2 {
> > + compatible = "mediatek,mt7921s-bluetooth";
> > + reg = <2>;
> > + reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>;
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index b64a64ca7916..662957146852 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -13657,6 +13657,7 @@ M: Sean Wang <sean.wang@mediatek.com>
> > L: linux-bluetooth@vger.kernel.org
> > L: linux-mediatek@lists.infradead.org (moderated for non-subscribers)
> > S: Maintained
> > +F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
> > F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt
> > F: drivers/bluetooth/btmtkuart.c
> >
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth
2024-01-26 3:26 ` Chen-Yu Tsai
@ 2024-01-26 9:12 ` AngeloGioacchino Del Regno
0 siblings, 0 replies; 8+ messages in thread
From: AngeloGioacchino Del Regno @ 2024-01-26 9:12 UTC (permalink / raw)
To: Chen-Yu Tsai
Cc: Marcel Holtmann, Luiz Augusto von Dentz, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Matthias Brugger, Sean Wang,
linux-bluetooth, netdev, linux-mediatek, devicetree,
linux-arm-kernel, linux-kernel
Il 26/01/24 04:26, Chen-Yu Tsai ha scritto:
> On Thu, Jan 25, 2024 at 7:39 PM AngeloGioacchino Del Regno
> <angelogioacchino.delregno@collabora.com> wrote:
>>
>> Il 25/01/24 10:52, Chen-Yu Tsai ha scritto:
>>> The MediaTek MT7921S is a WiFi/Bluetooth combo chip that works over
>>> SDIO. While the Bluetooth function is fully discoverable, the chip
>>> has a pin that can reset just the Bluetooth side, as opposed to the
>>> full chip. This needs to be described in the device tree.
>>>
>>> Add a device tree binding for MT7921S Bluetooth over SDIO specifically
>>> ot document the reset line.
>>>
>>> Cc: Sean Wang <sean.wang@mediatek.com>
>>> Signed-off-by: Chen-Yu Tsai <wenst@chromium.org>
>>> ---
>>> .../bluetooth/mediatek,mt7921s-bluetooth.yaml | 49 +++++++++++++++++++
>>> MAINTAINERS | 1 +
>>> 2 files changed, 50 insertions(+)
>>> create mode 100644 Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>>>
>>> diff --git a/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>>> new file mode 100644
>>> index 000000000000..bbe240e7cc40
>>> --- /dev/null
>>> +++ b/Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>>> @@ -0,0 +1,49 @@
>>> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
>>> +%YAML 1.2
>>> +---
>>> +$id: http://devicetree.org/schemas/net/bluetooth/mediatek,mt7921s-bluetooth.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: MediaTek MT7921S Bluetooth
>>> +
>>
>> title:
>>
>> maintainers:
>>
>> description:
>>
>> ... and then, you missed
>>
>> allOf:
>> - $ref: bluetooth-controller.yaml#
>
> (facepalm)
>
>> Everything else looks good.
>>
>> Cheers,
>> Angelo
>>
>>> +description:
>>
>> MT7921S is a (dual?) SDIO-attached dual-radio WiFi+Bluetooth combo chip;
>> this chip has two dedicated reset lines, one of which is used to reset
>> the Bluetooth core.
>> The WiFi part of this chip is described in ....where? :-)
>
> The function itself is fully probable and the implementation doesn't make
> use of the WiFi's reset line, so I don't see any reason to describe it?
> I don't actually know what the reset line does in the chip hardware.
> This patch is just described what is already used.
>
>>> + This binding describes the Bluetooth side of the SDIO-attached MT7921S
>>> + WiFi+Bluetooth combo chips. These chips are dual-radio chips supporting
>>> + WiFi and Bluetooth. Bluetooth works over SDIO just like WiFi. Bluetooth
>>> + has its own reset line, separate from WiFi, which can be used to reset
>>> + the Bluetooth core.
>>> +
>>> +maintainers:
>>> + - Sean Wang <sean.wang@mediatek.com>
>>> +
>>> +properties:
>>> + compatible:
>>> + enum:
>>> + - mediatek,mt7921s-bluetooth
>>> + reg:
>>> + const: 2
>>> +
>>> + reset-gpios:
>>> + maxItems: 1
>>> + description: A GPIO line connected to the Bluetooth subsystem reset line.
>>> + Typically the W_DISABLE2# pin on M.2 E-key modules. If present this
>>> + shall be flagged as active low.
>>
>> description:
>> An active-low reset line connected for the Bluetooth core;
>
> connected to?
Eh yes, sorry - I edited that statement multiple times and that "for" stuck
there for reasons :-)
>
>> on typical M.2 Key-E modules this is the W_DISABLE2# pin.
>
> Otherwise this looks better. Thanks.
You're welcome!
Cheers!
>
>
> ChenYu
>
>> Cheers,
>> Angelo
>>
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>> +
>>> +additionalProperties: false
>>> +
>>> +examples:
>>> + - |
>>> + mmc {
>>> + #address-cells = <1>;
>>> + #size-cells = <0>;
>>> +
>>> + bluetooth@2 {
>>> + compatible = "mediatek,mt7921s-bluetooth";
>>> + reg = <2>;
>>> + reset-gpios = <&pio 8 GPIO_ACTIVE_LOW>;
>>> + };
>>> + };
>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>> index b64a64ca7916..662957146852 100644
>>> --- a/MAINTAINERS
>>> +++ b/MAINTAINERS
>>> @@ -13657,6 +13657,7 @@ M: Sean Wang <sean.wang@mediatek.com>
>>> L: linux-bluetooth@vger.kernel.org
>>> L: linux-mediatek@lists.infradead.org (moderated for non-subscribers)
>>> S: Maintained
>>> +F: Documentation/devicetree/bindings/net/bluetooth/mediatek,mt7921s-bluetooth.yaml
>>> F: Documentation/devicetree/bindings/net/mediatek-bluetooth.txt
>>> F: drivers/bluetooth/btmtkuart.c
>>>
>>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2024-01-26 9:12 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-01-25 9:52 [PATCH 0/2] bluetooth: mt7921s: Add binding and fixup existing dts Chen-Yu Tsai
2024-01-25 9:52 ` [PATCH 1/2] dt-bindings: net: bluetooth: Add MediaTek MT7921S SDIO Bluetooth Chen-Yu Tsai
2024-01-25 11:39 ` AngeloGioacchino Del Regno
2024-01-26 3:26 ` Chen-Yu Tsai
2024-01-26 9:12 ` AngeloGioacchino Del Regno
2024-01-26 3:02 ` Rob Herring
2024-01-25 9:52 ` [PATCH 2/2] arm64: dts: mediatek: mt8183-pico6: Fix bluetooth node Chen-Yu Tsai
2024-01-25 11:40 ` AngeloGioacchino Del Regno
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).