* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-21 13:40 [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Vaishnav Achath
@ 2024-01-24 5:56 ` Jayesh Choudhary
2024-01-24 17:21 ` Nishanth Menon
2024-01-26 7:56 ` Wadim Egorov
2024-02-06 8:40 ` Vignesh Raghavendra
2 siblings, 1 reply; 8+ messages in thread
From: Jayesh Choudhary @ 2024-01-24 5:56 UTC (permalink / raw)
To: Vaishnav Achath, nm, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: bb, linux-arm-kernel, devicetree, linux-kernel, u-kumar1
Hello Vaishnav,
On 21/01/24 19:10, Vaishnav Achath wrote:
> K3 Remoteproc R5 driver requires reserved memory carveouts and
> mailbox configuration to instantiate the cores successfully.
> Since this is a board level dependency, keep the R5 subsytem
> disabled at SoC dtsi, otherwise it results in probe errors like
> below during AM62P SK boot:
>
> r5fss@79000000: reserved memory init failed, ret = -22
> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> r5fss@78000000: reserved memory init failed, ret = -22
> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
>
> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> index c4b0b91d70cf..14eb9ba836d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> ranges = <0x79000000 0x00 0x79000000 0x8000>,
> <0x79020000 0x00 0x79020000 0x8000>;
> power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> +
> mcu_r5fss0_core0: r5f@79000000 {
> compatible = "ti,am62-r5f";
> reg = <0x79000000 0x00008000>,
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> index 19f42b39394e..10a7059b2d9b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> ranges = <0x78000000 0x00 0x78000000 0x8000>,
> <0x78100000 0x00 0x78100000 0x8000>;
> power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
>
> wkup_r5fss0_core0: r5f@78000000 {
> compatible = "ti,am62-r5f";
Thanks.
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-24 5:56 ` Jayesh Choudhary
@ 2024-01-24 17:21 ` Nishanth Menon
2024-01-25 5:47 ` Vaishnav Achath
0 siblings, 1 reply; 8+ messages in thread
From: Nishanth Menon @ 2024-01-24 17:21 UTC (permalink / raw)
To: Jayesh Choudhary
Cc: Vaishnav Achath, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, bb, linux-arm-kernel,
devicetree, linux-kernel, u-kumar1
On 11:26-20240124, Jayesh Choudhary wrote:
> Hello Vaishnav,
>
> On 21/01/24 19:10, Vaishnav Achath wrote:
> > K3 Remoteproc R5 driver requires reserved memory carveouts and
> > mailbox configuration to instantiate the cores successfully.
> > Since this is a board level dependency, keep the R5 subsytem
> > disabled at SoC dtsi, otherwise it results in probe errors like
> > below during AM62P SK boot:
> >
> > r5fss@79000000: reserved memory init failed, ret = -22
> > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> > r5fss@78000000: reserved memory init failed, ret = -22
> > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
> >
> > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
> >
> > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>
> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
>
> > ---
> > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> > 2 files changed, 3 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > index c4b0b91d70cf..14eb9ba836d3 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> > ranges = <0x79000000 0x00 0x79000000 0x8000>,
> > <0x79020000 0x00 0x79020000 0x8000>;
> > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> > + status = "disabled";
> > +
> > mcu_r5fss0_core0: r5f@79000000 {
> > compatible = "ti,am62-r5f";
> > reg = <0x79000000 0x00008000>,
> > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > index 19f42b39394e..10a7059b2d9b 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> > ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > <0x78100000 0x00 0x78100000 0x8000>;
> > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> > + status = "disabled";
Is there a reason for difference in white space addition?
> > wkup_r5fss0_core0: r5f@78000000 {
> > compatible = "ti,am62-r5f";
>
> Thanks.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-24 17:21 ` Nishanth Menon
@ 2024-01-25 5:47 ` Vaishnav Achath
2024-01-25 13:43 ` Nishanth Menon
2024-01-25 14:04 ` Nishanth Menon
0 siblings, 2 replies; 8+ messages in thread
From: Vaishnav Achath @ 2024-01-25 5:47 UTC (permalink / raw)
To: Nishanth Menon, Jayesh Choudhary
Cc: vigneshr, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt, bb,
linux-arm-kernel, devicetree, linux-kernel, u-kumar1
Hi Nishanth,
On 24/01/24 22:51, Nishanth Menon wrote:
> On 11:26-20240124, Jayesh Choudhary wrote:
>> Hello Vaishnav,
>>
>> On 21/01/24 19:10, Vaishnav Achath wrote:
>>> K3 Remoteproc R5 driver requires reserved memory carveouts and
>>> mailbox configuration to instantiate the cores successfully.
>>> Since this is a board level dependency, keep the R5 subsytem
>>> disabled at SoC dtsi, otherwise it results in probe errors like
>>> below during AM62P SK boot:
>>>
>>> r5fss@79000000: reserved memory init failed, ret = -22
>>> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
>>> r5fss@78000000: reserved memory init failed, ret = -22
>>> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
>>>
>>> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>>>
>>> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
>>
>> Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
>>
>>> ---
>>> arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
>>> arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
>>> 2 files changed, 3 insertions(+)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> index c4b0b91d70cf..14eb9ba836d3 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
>>> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
>>> ranges = <0x79000000 0x00 0x79000000 0x8000>,
>>> <0x79020000 0x00 0x79020000 0x8000>;
>>> power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
>>> + status = "disabled";
>>> +
>>> mcu_r5fss0_core0: r5f@79000000 {
>>> compatible = "ti,am62-r5f";
>>> reg = <0x79000000 0x00008000>,
>>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> index 19f42b39394e..10a7059b2d9b 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
>>> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
>>> ranges = <0x78000000 0x00 0x78000000 0x8000>,
>>> <0x78100000 0x00 0x78100000 0x8000>;
>>> power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
>>> + status = "disabled";
>
> Is there a reason for difference in white space addition?
>
For mcu_r5fss0_core0 child node there was no blank line as per the
recommended coding style :
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124
So I added a newline there and wkup_r5fss0 already had it correct, since
the change was trivial it was not mentioned in commit message.
Thanks and Regards,
Vaishnav
>>> wkup_r5fss0_core0: r5f@78000000 {
>>> compatible = "ti,am62-r5f";
>>
>> Thanks.
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-25 5:47 ` Vaishnav Achath
@ 2024-01-25 13:43 ` Nishanth Menon
2024-01-25 14:04 ` Nishanth Menon
1 sibling, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2024-01-25 13:43 UTC (permalink / raw)
To: Vaishnav Achath
Cc: Jayesh Choudhary, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, bb, linux-arm-kernel,
devicetree, linux-kernel, u-kumar1
On 11:17-20240125, Vaishnav Achath wrote:
> Hi Nishanth,
>
> On 24/01/24 22:51, Nishanth Menon wrote:
> > On 11:26-20240124, Jayesh Choudhary wrote:
> > > Hello Vaishnav,
> > >
> > > On 21/01/24 19:10, Vaishnav Achath wrote:
> > > > K3 Remoteproc R5 driver requires reserved memory carveouts and
> > > > mailbox configuration to instantiate the cores successfully.
> > > > Since this is a board level dependency, keep the R5 subsytem
> > > > disabled at SoC dtsi, otherwise it results in probe errors like
> > > > below during AM62P SK boot:
> > > >
> > > > r5fss@79000000: reserved memory init failed, ret = -22
> > > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> > > > r5fss@78000000: reserved memory init failed, ret = -22
> > > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
> > > >
> > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
> > > >
> > > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> > >
> > > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
> > >
> > > > ---
> > > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> > > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> > > > 2 files changed, 3 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > index c4b0b91d70cf..14eb9ba836d3 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> > > > ranges = <0x79000000 0x00 0x79000000 0x8000>,
> > > > <0x79020000 0x00 0x79020000 0x8000>;
> > > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> > > > + status = "disabled";
> > > > +
^^ Look here.
> > > > mcu_r5fss0_core0: r5f@79000000 {
> > > > compatible = "ti,am62-r5f";
> > > > reg = <0x79000000 0x00008000>,
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > index 19f42b39394e..10a7059b2d9b 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> > > > ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > > > <0x78100000 0x00 0x78100000 0x8000>;
> > > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> > > > + status = "disabled";
> >
^^ no white space here.
> > Is there a reason for difference in white space addition?
> >
>
> For mcu_r5fss0_core0 child node there was no blank line as per the
> recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124
>
> So I added a newline there and wkup_r5fss0 already had it correct, since the
> change was trivial it was not mentioned in commit message.
Sigh, please add a EoL here to keep the look consistent between mcu and
wakeup dtsis. there is no need to state in commit message.
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-25 5:47 ` Vaishnav Achath
2024-01-25 13:43 ` Nishanth Menon
@ 2024-01-25 14:04 ` Nishanth Menon
1 sibling, 0 replies; 8+ messages in thread
From: Nishanth Menon @ 2024-01-25 14:04 UTC (permalink / raw)
To: Vaishnav Achath
Cc: Jayesh Choudhary, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt, bb, linux-arm-kernel,
devicetree, linux-kernel, u-kumar1
On 11:17-20240125, Vaishnav Achath wrote:
> Hi Nishanth,
>
> On 24/01/24 22:51, Nishanth Menon wrote:
> > On 11:26-20240124, Jayesh Choudhary wrote:
> > > Hello Vaishnav,
> > >
> > > On 21/01/24 19:10, Vaishnav Achath wrote:
> > > > K3 Remoteproc R5 driver requires reserved memory carveouts and
> > > > mailbox configuration to instantiate the cores successfully.
> > > > Since this is a board level dependency, keep the R5 subsytem
> > > > disabled at SoC dtsi, otherwise it results in probe errors like
> > > > below during AM62P SK boot:
> > > >
> > > > r5fss@79000000: reserved memory init failed, ret = -22
> > > > r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> > > > r5fss@78000000: reserved memory init failed, ret = -22
> > > > r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
> > > >
> > > > Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
> > > >
> > > > Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> > >
> > > Reviewed-by: Jayesh Choudhary <j-choudhary@ti.com>
> > >
> > > > ---
> > > > arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> > > > arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> > > > 2 files changed, 3 insertions(+)
> > > >
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > index c4b0b91d70cf..14eb9ba836d3 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> > > > @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> > > > ranges = <0x79000000 0x00 0x79000000 0x8000>,
> > > > <0x79020000 0x00 0x79020000 0x8000>;
> > > > power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> > > > + status = "disabled";
> > > > +
> > > > mcu_r5fss0_core0: r5f@79000000 {
> > > > compatible = "ti,am62-r5f";
> > > > reg = <0x79000000 0x00008000>,
> > > > diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > index 19f42b39394e..10a7059b2d9b 100644
> > > > --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> > > > @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> > > > ranges = <0x78000000 0x00 0x78000000 0x8000>,
> > > > <0x78100000 0x00 0x78100000 0x8000>;
> > > > power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> > > > + status = "disabled";
> >
> > Is there a reason for difference in white space addition?
> >
>
> For mcu_r5fss0_core0 child node there was no blank line as per the
> recommended coding style : https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/dts-coding-style.rst#n124
>
> So I added a newline there and wkup_r5fss0 already had it correct, since the
> change was trivial it was not mentioned in commit message.
>
For some reason i was misled to think that the EoL spacing was messed
up. Looking at
https://lore.kernel.org/all/20240121134017.374992-1-vaishnav.a@ti.com/ i
realise it is being fixed properly in the patch. Oops.. my bad.
Reviewed-by: Nishanth Menon <nm@ti.com>
--
Regards,
Nishanth Menon
Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-21 13:40 [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Vaishnav Achath
2024-01-24 5:56 ` Jayesh Choudhary
@ 2024-01-26 7:56 ` Wadim Egorov
2024-02-06 8:40 ` Vignesh Raghavendra
2 siblings, 0 replies; 8+ messages in thread
From: Wadim Egorov @ 2024-01-26 7:56 UTC (permalink / raw)
To: Vaishnav Achath, nm, vigneshr, kristo, robh+dt,
krzysztof.kozlowski+dt, conor+dt
Cc: bb, linux-arm-kernel, devicetree, linux-kernel, u-kumar1
Am 21.01.24 um 14:40 schrieb Vaishnav Achath:
> K3 Remoteproc R5 driver requires reserved memory carveouts and
> mailbox configuration to instantiate the cores successfully.
> Since this is a board level dependency, keep the R5 subsytem
> disabled at SoC dtsi, otherwise it results in probe errors like
> below during AM62P SK boot:
>
> r5fss@79000000: reserved memory init failed, ret = -22
> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> r5fss@78000000: reserved memory init failed, ret = -22
> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
Shouldn't we have a similar patch for the am64 R5 cores?
>
> Fixes: b5080c7c1f7e ("arm64: dts: ti: k3-am62p: Add nodes for more IPs")
>
> Signed-off-by: Vaishnav Achath <vaishnav.a@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi | 2 ++
> arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi | 1 +
> 2 files changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> index c4b0b91d70cf..14eb9ba836d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-mcu.dtsi
> @@ -187,6 +187,8 @@ mcu_r5fss0: r5fss@79000000 {
> ranges = <0x79000000 0x00 0x79000000 0x8000>,
> <0x79020000 0x00 0x79020000 0x8000>;
> power-domains = <&k3_pds 7 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> +
> mcu_r5fss0_core0: r5f@79000000 {
> compatible = "ti,am62-r5f";
> reg = <0x79000000 0x00008000>,
> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> index 19f42b39394e..10a7059b2d9b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi
> @@ -78,6 +78,7 @@ wkup_r5fss0: r5fss@78000000 {
> ranges = <0x78000000 0x00 0x78000000 0x8000>,
> <0x78100000 0x00 0x78100000 0x8000>;
> power-domains = <&k3_pds 119 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
>
> wkup_r5fss0_core0: r5f@78000000 {
> compatible = "ti,am62-r5f";
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
2024-01-21 13:40 [PATCH] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes Vaishnav Achath
2024-01-24 5:56 ` Jayesh Choudhary
2024-01-26 7:56 ` Wadim Egorov
@ 2024-02-06 8:40 ` Vignesh Raghavendra
2 siblings, 0 replies; 8+ messages in thread
From: Vignesh Raghavendra @ 2024-02-06 8:40 UTC (permalink / raw)
To: nm, kristo, robh+dt, krzysztof.kozlowski+dt, conor+dt,
Vaishnav Achath
Cc: Vignesh Raghavendra, bb, linux-arm-kernel, devicetree,
linux-kernel, u-kumar1
Hi Vaishnav Achath,
On Sun, 21 Jan 2024 19:10:17 +0530, Vaishnav Achath wrote:
> K3 Remoteproc R5 driver requires reserved memory carveouts and
> mailbox configuration to instantiate the cores successfully.
> Since this is a board level dependency, keep the R5 subsytem
> disabled at SoC dtsi, otherwise it results in probe errors like
> below during AM62P SK boot:
>
> r5fss@79000000: reserved memory init failed, ret = -22
> r5fss@79000000: k3_r5_cluster_rproc_init failed, ret = -22
> r5fss@78000000: reserved memory init failed, ret = -22
> r5fss@78000000: k3_r5_cluster_rproc_init failed, ret = -22
>
> [...]
I have applied the following to branch ti-k3-dts-next on [1].
Thank you!
[1/1] arm64: dts: ti: k3-am62p-mcu/wakeup: Disable MCU and wakeup R5FSS nodes
commit: dfc90e5f1a0fe0f8124521bc1911e38aa6cd9118
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent up the chain during
the next merge window (or sooner if it is a relevant bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/ti/linux.git
--
Vignesh
^ permalink raw reply [flat|nested] 8+ messages in thread