devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "André Draszik" <andre.draszik@linaro.org>
To: peter.griffin@linaro.org, robh+dt@kernel.org,
	krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@android.com,
	tudor.ambarus@linaro.org, willmcvicker@google.com,
	semen.protsenko@linaro.org, alim.akhtar@samsung.com,
	s.nawrocki@samsung.com, tomasz.figa@gmail.com,
	cw00.choi@samsung.com, mturquette@baylibre.com, sboyd@kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org,
	devicetree@vger.kernel.org
Subject: [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8
Date: Sat, 27 Jan 2024 00:35:52 +0000	[thread overview]
Message-ID: <20240127003607.501086-4-andre.draszik@linaro.org> (raw)
In-Reply-To: <20240127003607.501086-1-andre.draszik@linaro.org>

Wrong pclk clocks have been used in this usi8 instance here. For USI
and I2C, we need the ipclk and pclk, where pclk is the bus clock.
Without it, nothing can work.
It is unclear what exactly is using USI8_USI_CLK, but it is not
required for the IP to be operational at this stage, while pclk is.
This also brings the DT in line with the clock names expected by the
usi and i2c drivers.

Update the DTSI accordingly.

Fixes: 6d44d1a1fb62 ("arm64: dts: exynos: gs101: define USI8 with I2C configuration")
Signed-off-by: André Draszik <andre.draszik@linaro.org>
---
 arch/arm64/boot/dts/exynos/google/gs101.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/exynos/google/gs101.dtsi b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
index bc251e565be6..e5b665be2d62 100644
--- a/arch/arm64/boot/dts/exynos/google/gs101.dtsi
+++ b/arch/arm64/boot/dts/exynos/google/gs101.dtsi
@@ -380,7 +380,7 @@ usi8: usi@109700c0 {
 			ranges;
 			#address-cells = <1>;
 			#size-cells = <1>;
-			clocks = <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>,
+			clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>,
 				 <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>;
 			clock-names = "pclk", "ipclk";
 			samsung,sysreg = <&sysreg_peric0 0x101c>;
@@ -397,7 +397,7 @@ hsi2c_8: i2c@10970000 {
 				pinctrl-names = "default";
 				pinctrl-0 = <&hsi2c8_bus>;
 				clocks = <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_IPCLK_7>,
-					 <&cmu_peric0 CLK_GOUT_PERIC0_CLK_PERIC0_USI8_USI_CLK>;
+					 <&cmu_peric0 CLK_GOUT_PERIC0_PERIC0_TOP0_PCLK_7>;
 				clock-names = "hsi2c", "hsi2c_pclk";
 				status = "disabled";
 			};
-- 
2.43.0.429.g432eaa2c6b-goog


  parent reply	other threads:[~2024-01-27  0:37 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-27  0:35 gs101 oriole: peripheral block 0 (peric0) fixes André Draszik
2024-01-27  0:35 ` [PATCH 1/5] clk: samsung: gs101: gpio_peric0_pclk needs to be kept on André Draszik
2024-01-27  3:06   ` Sam Protsenko
2024-01-27  3:51   ` Tudor Ambarus
2024-01-29 12:54   ` Peter Griffin
2024-01-27  0:35 ` [PATCH 2/5] arm64: dts: exynos: gs101: fix usi8 default mode André Draszik
2024-01-27  3:05   ` Sam Protsenko
2024-01-27  3:48   ` Tudor Ambarus
2024-01-29  9:48   ` Peter Griffin
2024-01-27  0:35 ` André Draszik [this message]
2024-01-27  3:22   ` [PATCH 3/5] arm64: dts: exynos: gs101: use correct clocks for usi8 Sam Protsenko
2024-01-27  4:00     ` Tudor Ambarus
2024-01-29 16:33       ` Tudor Ambarus
2024-01-29 14:01     ` André Draszik
2024-01-27  0:35 ` [PATCH 4/5] arm64: dts: exynos: gs101: use correct clocks for usi_uart André Draszik
2024-01-27  1:37   ` André Draszik
2024-01-27  3:23   ` Sam Protsenko
2024-01-27  4:03   ` Tudor Ambarus
2024-01-29 16:39     ` Tudor Ambarus
2024-01-27  0:35 ` [PATCH 5/5] clk: samsung: gs101: don't mark non-essential clocks as critical André Draszik
2024-01-27  1:38   ` André Draszik
2024-01-27  3:30   ` Sam Protsenko
2024-01-29 14:37     ` André Draszik
2024-01-29 19:16       ` Sam Protsenko
2024-01-30  9:31         ` André Draszik
2024-01-30  9:39           ` Tudor Ambarus
2024-01-29 16:44   ` Tudor Ambarus
2024-01-27  3:01 ` gs101 oriole: peripheral block 0 (peric0) fixes Sam Protsenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240127003607.501086-4-andre.draszik@linaro.org \
    --to=andre.draszik@linaro.org \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kernel-team@android.com \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=mturquette@baylibre.com \
    --cc=peter.griffin@linaro.org \
    --cc=robh+dt@kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=sboyd@kernel.org \
    --cc=semen.protsenko@linaro.org \
    --cc=tomasz.figa@gmail.com \
    --cc=tudor.ambarus@linaro.org \
    --cc=willmcvicker@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).