From: Trevor Woerner <twoerner@gmail.com>
To: Heiko Stuebner <heiko@sntech.de>
Cc: Jonas Karlman <jonas@kwiboo.se>, Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties
Date: Fri, 26 Jan 2024 20:56:29 -0500 [thread overview]
Message-ID: <20240127015629.GA36077@localhost> (raw)
In-Reply-To: <1976352.usQuhbGJ8B@phil>
On Thu 2024-01-25 @ 09:12:46 PM, Heiko Stuebner wrote:
> Hi,
>
> Am Freitag, 19. Januar 2024, 00:03:12 CET schrieb Trevor Woerner:
> > On Thu 2024-01-18 @ 08:31:30 AM, Jonas Karlman wrote:
> > > On 2024-01-17 09:15, Jonas Karlman wrote:
> > > I have just sent out a U-Boot series that fix ethernet on the v1.21
> > > revision of the ROCK Pi E board, see [2].
> >
> > Thank you! I have tested your patches both in U-Boot and Linux and they work
> > perfectly.
>
> if I'm reading this correctly, this patch is not needed anymore, right?
True, patch 2/2 is not needed (or correct).
> I'm not yet sure about the first patch, as it really is
> just a cosmetic ;-)
I wouldn't say it's entirely cosmetic. Some rock-pi-e boards come with the
8211e PHY and others come with the 8211f PHY. Labelling the phandle as
"rtl8211e" would be misleading/confusing for people who had boards whose boot
logs would report otherwise.
next prev parent reply other threads:[~2024-01-27 1:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 20:41 [PATCH 1/2] arm64: dts: rockchip: rock-pi-e: adjust phy-handle name Trevor Woerner
2024-01-16 20:41 ` [PATCH 2/2] arm64: dts: rockchip: rock-pi-e: fix location of snps properties Trevor Woerner
2024-01-17 4:38 ` Chen-Yu Tsai
2024-01-17 5:47 ` Trevor Woerner
2024-01-17 8:15 ` Jonas Karlman
2024-01-18 7:31 ` Jonas Karlman
2024-01-18 23:03 ` Trevor Woerner
2024-01-25 20:12 ` Heiko Stuebner
2024-01-27 1:56 ` Trevor Woerner [this message]
2024-02-13 19:37 ` (subset) [PATCH 1/2] arm64: dts: rockchip: rock-pi-e: adjust phy-handle name Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240127015629.GA36077@localhost \
--to=twoerner@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=jonas@kwiboo.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).