[RFC PATCH 0/2] arm64: dts: renesas: ulcb-kf: adapt regulators to schematics

[RFC PATCH 0/2] arm64: dts: renesas: ulcb-kf: adapt regulators to schematics

[Wolfram Sang]

As discussed before, here are suggestions to rename some regulators on
the KingFisher board. Patch 2 has an open question, this is why the
series is RFC. Looking forward to comments.

Based on the patch "arm64: dts: renesas: ulcb-kf: add regulators for
PCIe ch1".

Branch can be found here:
git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/upport_kf

Wolfram Sang (2):
  arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics
  arm64: dts: renesas: ulcb-kf: adapt sound 5v regulator to schematics

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 28 ++++++++++++++----------
 1 file changed, 16 insertions(+), 12 deletions(-)

-- 
2.39.2

[RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Wolfram Sang]

It is named T1.8V in the schematics. Also add properties dcoumenting it
is always on, also during boot.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index c8dc06f0dfed..6b6a0a8bc1db 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -32,11 +32,13 @@ hdmi1_con: endpoint {
 		};
 	};
 
-	hdmi_1v8: regulator-hdmi-1v8 {
+	t1v8: regulator-t1v8 {
 		compatible = "regulator-fixed";
-		regulator-name = "hdmi-1v8";
+		regulator-name = "t1v8";
 		regulator-min-microvolt = <1800000>;
 		regulator-max-microvolt = <1800000>;
+		regulator-boot-on;
+		regulator-always-on;
 	};
 
 	pcie_1v5: regulator-pcie-1v5 {
@@ -154,11 +156,11 @@ hdmi@3d {
 
 				pd-gpios = <&gpio_exp_75 5 GPIO_ACTIVE_LOW>;
 
-				avdd-supply = <&hdmi_1v8>;
-				dvdd-supply = <&hdmi_1v8>;
-				pvdd-supply = <&hdmi_1v8>;
+				avdd-supply = <&t1v8>;
+				dvdd-supply = <&t1v8>;
+				pvdd-supply = <&t1v8>;
 				dvdd-3v-supply = <&reg_3p3v>;
-				bgvdd-supply = <&hdmi_1v8>;
+				bgvdd-supply = <&t1v8>;
 
 				adi,input-depth = <8>;
 				adi,input-colorspace = "rgb";
-- 
2.39.2

Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Geert Uytterhoeven]

Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> It is named T1.8V in the schematics. Also add properties dcoumenting it

documenting

> is always on, also during boot.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>

> --- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> +++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
> @@ -32,11 +32,13 @@ hdmi1_con: endpoint {
>                 };
>         };
>
> -       hdmi_1v8: regulator-hdmi-1v8 {
> +       t1v8: regulator-t1v8 {

"t1p8v"?
Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

>                 compatible = "regulator-fixed";
> -               regulator-name = "hdmi-1v8";
> +               regulator-name = "t1v8";
>                 regulator-min-microvolt = <1800000>;
>                 regulator-max-microvolt = <1800000>;
> +               regulator-boot-on;
> +               regulator-always-on;
>         };
>
>         pcie_1v5: regulator-pcie-1v5 {
> @@ -154,11 +156,11 @@ hdmi@3d {
>
>                                 pd-gpios = <&gpio_exp_75 5 GPIO_ACTIVE_LOW>;
>
> -                               avdd-supply = <&hdmi_1v8>;
> -                               dvdd-supply = <&hdmi_1v8>;
> -                               pvdd-supply = <&hdmi_1v8>;
> +                               avdd-supply = <&t1v8>;
> +                               dvdd-supply = <&t1v8>;
> +                               pvdd-supply = <&t1v8>;
>                                 dvdd-3v-supply = <&reg_3p3v>;
> -                               bgvdd-supply = <&hdmi_1v8>;
> +                               bgvdd-supply = <&t1v8>;
>
>                                 adi,input-depth = <8>;
>                                 adi,input-colorspace = "rgb";

The rest LGTM.

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 220 bytes --]


> > -       hdmi_1v8: regulator-hdmi-1v8 {
> > +       t1v8: regulator-t1v8 {
> 
> "t1p8v"?
> Or "reg_t1p8v", as the former is a rather short name, causing conflicts?

Agreed, I'll take the latter and resend.


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Geert Uytterhoeven]

Hi Wolfram,

On Mon, Feb 12, 2024 at 2:42 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > -       hdmi_1v8: regulator-hdmi-1v8 {
> > > +       t1v8: regulator-t1v8 {
> >
> > "t1p8v"?
> > Or "reg_t1p8v", as the former is a rather short name, causing conflicts?
>
> Agreed, I'll take the latter and resend.

No need for that, I can fix it while applying...
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [RFC PATCH 1/2] arm64: dts: renesas: ulcb-kf: adapt 1.8V HDMI regulator to schematics

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 227 bytes --]


> > > "t1p8v"?
> > > Or "reg_t1p8v", as the former is a rather short name, causing conflicts?
> >
> > Agreed, I'll take the latter and resend.
> 
> No need for that, I can fix it while applying...

Cool, thank you!


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[RFC PATCH 2/2] arm64: dts: renesas: ulcb-kf: adapt sound 5v regulator to schematics

[Wolfram Sang]

Sound uses the standard 5V supply, so rename the fixed regulator as
such. Also add properties dcoumenting it is always on, also during boot.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---

Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
because 5V are not used on ULCB, but I am open to change it.

 arch/arm64/boot/dts/renesas/ulcb-kf.dtsi | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
index 6b6a0a8bc1db..84b0976503b7 100644
--- a/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
+++ b/arch/arm64/boot/dts/renesas/ulcb-kf.dtsi
@@ -59,11 +59,13 @@ pcie_3v3: regulator-pcie-3v3 {
 		enable-active-high;
 	};
 
-	snd_vcc5v: regulator-snd_vcc5v {
+	reg_5v: regulator-5v {
 		compatible = "regulator-fixed";
-		regulator-name = "snd-vcc5v";
+		regulator-name = "fixed-5V";
 		regulator-min-microvolt = <5000000>;
 		regulator-max-microvolt = <5000000>;
+		regulator-boot-on;
+		regulator-always-on;
 	};
 
 	wlan_en: regulator-wlan_en {
@@ -210,10 +212,10 @@ pcm3168a: audio-codec@44 {
 
 				VDD1-supply = <&reg_3p3v>;
 				VDD2-supply = <&reg_3p3v>;
-				VCCAD1-supply = <&snd_vcc5v>;
-				VCCAD2-supply = <&snd_vcc5v>;
-				VCCDA1-supply = <&snd_vcc5v>;
-				VCCDA2-supply = <&snd_vcc5v>;
+				VCCAD1-supply = <&reg_5v>;
+				VCCAD2-supply = <&reg_5v>;
+				VCCDA1-supply = <&reg_5v>;
+				VCCDA2-supply = <&reg_5v>;
 			};
 
 			gyroscope@6b {
-- 
2.39.2

Re: [RFC PATCH 2/2] arm64: dts: renesas: ulcb-kf: adapt sound 5v regulator to schematics

[Geert Uytterhoeven]

Hi Wolfram,

Thanks for your patch!

On Mon, Jan 29, 2024 at 10:23 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> Sound uses the standard 5V supply, so rename the fixed regulator as
> such. Also add properties dcoumenting it is always on, also during boot.

documenting

> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> ---
>
> Or shall we move the regulator to ulcb.dtsi? I tend to leave it here
> because 5V are not used on ULCB, but I am open to change it.

I think it's fine to keep it here, as the regulator (U59) that generates
5V from 12V is present on the Kingfisher board.  However, according
to the schematics, 5V is generated by the PMIC on the ULCB too, and
both 5V nets are connected through the board-to-board connectors?

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v6.9.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds