From: Stephen Boyd <sboyd@kernel.org>
To: Rob Herring <robh+dt@kernel.org>
Cc: linux-kernel@vger.kernel.org, patches@lists.linux.dev,
linux-um@lists.infradead.org,
linux-arm-kernel@lists.infradead.org, kunit-dev@googlegroups.com,
linux-kselftest@vger.kernel.org, devicetree@vger.kernel.org,
Frank Rowand <frowand.list@gmail.com>
Subject: [PATCH v2 4/7] of: Always unflatten in unflatten_and_copy_device_tree()
Date: Mon, 29 Jan 2024 16:45:03 -0800 [thread overview]
Message-ID: <20240130004508.1700335-5-sboyd@kernel.org> (raw)
In-Reply-To: <20240130004508.1700335-1-sboyd@kernel.org>
We want to populate an empty DT whenever CONFIG_OF is enabled so that
overlays can be applied and the DT unit tests can be run. Make
unflatten_and_copy_device_tree() stop printing a warning if the
'initial_boot_params' pointer is NULL. Instead, simply copy the dtb if
there is one and then unflatten it. If there isn't a DT to copy, then
the call to unflatten_device_tree() is largely a no-op, so nothing
really changes here.
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
---
drivers/of/fdt.c | 32 +++++++++++++++++---------------
1 file changed, 17 insertions(+), 15 deletions(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index bf502ba8da95..b488ad86d456 100644
--- a/drivers/of/fdt.c
+++ b/drivers/of/fdt.c
@@ -1318,6 +1318,21 @@ bool __init early_init_dt_scan(void *params)
return true;
}
+static void __init copy_device_tree(void)
+{
+ int size;
+ void *dt;
+
+ size = fdt_totalsize(initial_boot_params);
+ dt = early_init_dt_alloc_memory_arch(size,
+ roundup_pow_of_two(FDT_V17_SIZE));
+
+ if (dt) {
+ memcpy(dt, initial_boot_params, size);
+ initial_boot_params = dt;
+ }
+}
+
/**
* unflatten_device_tree - create tree of device_nodes from flat blob
*
@@ -1350,22 +1365,9 @@ void __init unflatten_device_tree(void)
*/
void __init unflatten_and_copy_device_tree(void)
{
- int size;
- void *dt;
+ if (initial_boot_params)
+ copy_device_tree();
- if (!initial_boot_params) {
- pr_warn("No valid device tree found, continuing without\n");
- return;
- }
-
- size = fdt_totalsize(initial_boot_params);
- dt = early_init_dt_alloc_memory_arch(size,
- roundup_pow_of_two(FDT_V17_SIZE));
-
- if (dt) {
- memcpy(dt, initial_boot_params, size);
- initial_boot_params = dt;
- }
unflatten_device_tree();
}
--
https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git/
https://git.kernel.org/pub/scm/linux/kernel/git/sboyd/spmi.git
next prev parent reply other threads:[~2024-01-30 0:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-30 0:44 [PATCH v2 0/7] of: populate of_root node if bootloader doesn't Stephen Boyd
2024-01-30 0:45 ` [PATCH v2 1/7] arm64: Unconditionally call unflatten_device_tree() Stephen Boyd
2024-01-31 20:54 ` Rob Herring
2024-01-31 22:59 ` Stephen Boyd
2024-02-02 16:30 ` Rob Herring
2024-01-30 0:45 ` [PATCH v2 2/7] um: " Stephen Boyd
2024-01-30 0:45 ` [PATCH v2 3/7] x86/of: Unconditionally call unflatten_and_copy_device_tree() Stephen Boyd
2024-01-30 13:30 ` Saurabh Singh Sengar
2024-01-30 0:45 ` Stephen Boyd [this message]
2024-01-30 0:45 ` [PATCH v2 5/7] of: Create of_root if no dtb provided by firmware Stephen Boyd
2024-01-30 0:45 ` [PATCH v2 6/7] of: unittest: treat missing of_root as error instead of fixing up Stephen Boyd
2024-01-30 0:45 ` [PATCH v2 7/7] of: Add KUnit test to confirm DTB is loaded Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130004508.1700335-5-sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=kunit-dev@googlegroups.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=patches@lists.linux.dev \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).