From: Rob Herring <robh@kernel.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Jon Hunter <jonathanh@nvidia.com>,
Sameer Pujar <spujar@nvidia.com>,
devicetree@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] ASoC: dt-bindings: tegra: Document iommus and interconnects for ADMAIF
Date: Tue, 30 Jan 2024 11:53:05 -0600 [thread overview]
Message-ID: <20240130175305.GA2051939-robh@kernel.org> (raw)
In-Reply-To: <20240118142706.4179146-1-thierry.reding@gmail.com>
On Thu, Jan 18, 2024 at 03:27:05PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> The ADMAIF is responsible for accessing system memory on behalf of other
> components of the APE, so make sure it can be hooked up to an IOMMU and
> memory controller.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
> .../bindings/sound/nvidia,tegra210-admaif.yaml | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> index 15ab40aeab1e..59304f02d063 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> @@ -39,6 +39,18 @@ properties:
>
> dma-names: true
>
> + iommus:
> + maxItems: 1
> +
> + interconnects:
> + description: Description of the interconnect paths for the ADMA interface; see
> + ../interconnect/interconnect.txt for details.
Don't need generic descriptions of common properties. What you need is
defining how many entries and a description for each entry.
Rob
prev parent reply other threads:[~2024-01-30 17:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-18 14:27 [PATCH 1/2] ASoC: dt-bindings: tegra: Document iommus and interconnects for ADMAIF Thierry Reding
2024-01-18 14:27 ` [PATCH 2/2] dt-bindings: sound: tegra: Correct clocks and resets for HDA Thierry Reding
2024-01-30 17:56 ` Rob Herring
2024-01-30 17:53 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240130175305.GA2051939-robh@kernel.org \
--to=robh@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jonathanh@nvidia.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-tegra@vger.kernel.org \
--cc=spujar@nvidia.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).