From: Bjorn Helgaas <helgaas@kernel.org>
To: Frank Li <Frank.Li@nxp.com>
Cc: "Bjorn Helgaas" <bhelgaas@google.com>,
"Jingoo Han" <jingoohan1@gmail.com>,
"Gustavo Pimentel" <gustavo.pimentel@synopsys.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Lorenzo Pieralisi" <lpieralisi@kernel.org>,
"Krzysztof Wilczyński" <kw@linux.com>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Conor Dooley" <conor+dt@kernel.org>,
imx@lists.linux.dev, linux-pci@vger.kernel.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 5/6] dt-bindings: PCI: dwc: Add 'msg" register region
Date: Wed, 31 Jan 2024 10:01:36 -0600 [thread overview]
Message-ID: <20240131160136.GA587669@bhelgaas> (raw)
In-Reply-To: <20240130-pme_msg-v1-5-d52b0add5c7c@nxp.com>
Super nit: use matching quotes in subject.
On Tue, Jan 30, 2024 at 07:45:30PM -0500, Frank Li wrote:
> Add a outbound iATU-capable memory-region which will be use to send PCI
> message (such as pme-turn-off) to peripheral. So all platforms can use
> common method to send out pme-turn-off message by using one outbound iATU.
s/Add a outbound/Add an outbound/
s/will be use/will be used/ (also below)
s/PCI/PCIe/ (also below)
s/pme-turn-off/PME_Turn_Off/ to make it more searchable in spec (also below)
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> index 022055edbf9e6..e27d81b6a131c 100644
> --- a/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> +++ b/Documentation/devicetree/bindings/pci/snps,dw-pcie.yaml
> @@ -101,6 +101,10 @@ properties:
> Outbound iATU-capable memory-region which will be used to access
> the peripheral PCIe devices configuration space.
> const: config
> + - description:
> + Outbound iATU-capable memory-region which will be use to send
> + PCI message (such as pme-turn-off) to peripheral.
> + const: msg
> - description:
> Vendor-specific CSR names. Consider using the generic names above
> for new bindings.
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2024-01-31 16:01 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-31 0:45 [PATCH 0/6] PCI: dwc: Add common pme_turn_off message by using outbound iATU Frank Li
2024-01-31 0:45 ` [PATCH 1/6] PCI: Add INTx Mechanism Messages macros Frank Li
2024-01-31 15:37 ` Bjorn Helgaas
2024-02-01 17:53 ` Bjorn Helgaas
2024-01-31 0:45 ` [PATCH 2/6] PCI: dwc: Change arguments of dw_pcie_prog_outbound_atu() Frank Li
2024-01-31 15:41 ` Bjorn Helgaas
2024-01-31 15:56 ` Frank Li
2024-01-31 18:23 ` Bjorn Helgaas
2024-01-31 0:45 ` [PATCH 3/6] PCI: dwc: Add outbound MSG TLPs support Frank Li
2024-02-01 3:07 ` Yoshihiro Shimoda
2024-02-01 4:18 ` Frank Li
2024-01-31 0:45 ` [PATCH 4/6] PCI: Add PME_TURN_OFF message macro Frank Li
2024-01-31 0:45 ` [PATCH 5/6] dt-bindings: PCI: dwc: Add 'msg" register region Frank Li
2024-01-31 16:01 ` Bjorn Helgaas [this message]
2024-01-31 0:45 ` [PATCH 6/6] PCI: dwc: Add common send pme_turn_off message method Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240131160136.GA587669@bhelgaas \
--to=helgaas@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=bhelgaas@google.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gustavo.pimentel@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jingoohan1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kw@linux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).