Re: [PATCH v4 03/12] dt-bindings: mtd: brcmnand: Add ecc strap property

William Zhang
2024-02-05T18:05:21Z

[-- Attachment #1: Type: text/plain, Size: 2919 bytes --]

Hi Miquel,

On 2/5/24 05:26, Miquel Raynal wrote:
> Hi,
>
> conor@kernel.org wrote on Sat, 3 Feb 2024 14:49:50 +0000:
>
>> On Fri, Feb 02, 2024 at 04:28:24PM -0800, William Zhang wrote:
>>> Add brcm,nand-ecc-use-strap to get ecc and spare area size settings from
>>> board boot strap for broadband board designs because they do not specify
>>> ecc setting in dts but rather using the strap setting.
>>>
>>> Signed-off-by: William Zhang <william.zhang@broadcom.com>
>>>
>>> ---
>>>
>>> Changes in v4:
>>> - Move ecc strap property to this separate patch and remove some
>>> non-binding related text from the description
>>>
>>> Changes in v3: None
>>> Changes in v2: None
>>>
>>> Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml | 8 ++++++++
>>> 1 file changed, 8 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> index d0168d55c73e..2599d902ec3a 100644
>>> --- a/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
>>> @@ -147,6 +147,14 @@ patternProperties:
>>> layout.
>>> $ref: /schemas/types.yaml#/definitions/uint32
>>>
>>> + brcm,nand-ecc-use-strap:
>>> + description:
>>> + This flag indicates the ecc strength and spare area size should
>>> + be retrieved from the SoC NAND boot strap setting instead of
>>> + nand-ecc-strength and brcm,nand-oob-sector-size or auto detection.
>>
>> I'm still on the fence about this being overly prescriptive about the
>> operating systems behaviour. I think it would be good to say why the
>> strap values are better than those explicitly provided in DT rather than
>> just saying "these strap values should be used".
>
> I don't know if there is a point is saying why they would be better, as
> they are not. It is a -questionable- design choice. However I would
> just get rid of any mention to other properties. Just say one should
> expect the strap value to be read and applied by the system when this
> property is present.
>
Agree we don't need to say which is better as it is just a design
choice. And it is used by all BCMBCA internal ref boards and customer
designs. But if we just say strap value is read and applied, it is vague
and nobody would know what is applied. I replied this email yesterday
and suggest the followings:

This property provides a choice for retrieving ecc strength and spare
area size from the SoC NAND boot strap setting. It is commonly used by
the BCMBCA SoC board design.

Hope this make everyone happy and we can move forward.

>>> + This is commonly used by the BCMBCA SoC board design.
>>> + $ref: /schemas/types.yaml#/definitions/flag
>>> +
>>> unevaluatedProperties: false
>>>
>>> allOf:
>>> --
>>> 2.37.3
>>>
>
>
> Thanks,
> Miquèl

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4212 bytes --]