Re: [PATCH v8 2/7] dt-bindings: adc: axi-adc: update bindings for backend framework

[Jonathan Cameron <jic23@kernel.org>]

On Sun, 4 Feb 2024 07:30:05 +0000
"Sa, Nuno" <Nuno.Sa@analog.com> wrote:

> > -----Original Message-----
> > From: David Lechner <dlechner@baylibre.com>
> > Sent: Friday, February 2, 2024 10:38 PM
> > To: Sa, Nuno <Nuno.Sa@analog.com>
> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; Lars-Peter Clausen
> > <lars@metafoo.de>; Hennerich, Michael <Michael.Hennerich@analog.com>;
> > Jonathan Cameron <jic23@kernel.org>; Rob Herring <robh+dt@kernel.org>;
> > Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Conor Dooley
> > <conor+dt@kernel.org>; Frank Rowand <frowand.list@gmail.com>; Olivier
> > Moysan <olivier.moysan@foss.st.com>; Rob Herring <robh@kernel.org>
> > Subject: Re: [PATCH v8 2/7] dt-bindings: adc: axi-adc: update bindings for backend
> > framework
> > 
> > 
> > On Fri, Feb 2, 2024 at 9:10 AM Nuno Sa via B4 Relay
> > <devnull+nuno.sa.analog.com@kernel.org> wrote:  
> > >
> > > From: Nuno Sa <nuno.sa@analog.com>
> > >
> > > 'adi,adc-dev' is now deprecated and must not be used anymore. Hence,
> > > also remove it from being required.
> > >
> > > The reason why it's being deprecated is because the axi-adc CORE is now
> > > an IIO service provider hardware (IIO backends) for consumers to make use
> > > of. Before, the logic with 'adi,adc-dev' was the opposite (it was kind
> > > of consumer referencing other nodes/devices) and that proved to be wrong
> > > and to not scale.
> > >
> > > Now, IIO consumers of this hardware are expected to reference it using the
> > > io-backends property. Hence, the new '#io-backend-cells' is being added
> > > so the device is easily identified as a provider.
> > >
> > > Reviewed-by: Rob Herring <robh@kernel.org>
> > > Signed-off-by: Nuno Sa <nuno.sa@analog.com>
> > > ---
> > >  Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml | 8 +++++---
> > >  1 file changed, 5 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml  
> > b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml  
> > > index 9996dd93f84b..add10b22dcac 100644
> > > --- a/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/adc/adi,axi-adc.yaml
> > > @@ -39,12 +39,15 @@ properties:
> > >      $ref: /schemas/types.yaml#/definitions/phandle
> > >      description:
> > >        A reference to a the actual ADC to which this FPGA ADC interfaces to.
> > > +    deprecated: true
> > > +
> > > +  '#io-backends-cells'  
> > 
> > Still missing the : here.  
> 
> Ahh crap!! I was so blindly assuming the error report was because the property could
> still be missing in the core schemas that I did not even paid attention. Thanks for this!
> 
> But worst, the property is not even correct. #io-backends-cells -> #io-backend-cells
> Both here and in the example.
> 
> Jonathan, sorry about this... Let me know if this is something you can fix or if you
> want me to spin another version.
I've tried to fix it up.  Please check the testing branch to see if I messed it up.

> 
> - Nuno Sá
>