From: Devarsh Thakkar <devarsht@ti.com>
To: <mchehab@kernel.org>, <robh+dt@kernel.org>,
<krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
<hverkuil-cisco@xs4all.nl>, <linux-media@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <laurent.pinchart@ideasonboard.com>, <praneeth@ti.com>,
<nm@ti.com>, <vigneshr@ti.com>, <a-bhatia1@ti.com>,
<j-luthra@ti.com>, <b-brnich@ti.com>, <detheridge@ti.com>,
<p-mantena@ti.com>, <vijayp@ti.com>, <devarsht@ti.com>,
<andrzej.p@collabora.com>, <nicolas@ndufresne.ca>
Subject: [PATCH v4 0/3] Add V4L2 M2M Driver for E5010 JPEG Encoder
Date: Mon, 5 Feb 2024 17:12:36 +0530 [thread overview]
Message-ID: <20240205114239.924697-1-devarsht@ti.com> (raw)
This adds support for V4L2 M2M based driver for E5010 JPEG Encoder
which is a stateful JPEG encoder from Imagination technologies
and is present in TI AM62A SoC.
v4l2-compliance test :
Link: https://gist.github.com/devarsht/867b1d646bca3f3877edb1f3638aae31
E5010 JPEG Encoder Manual tests :
Performance:
Link: https://gist.github.com/devarsht/63d835093195181866ae9a85de880d3c
Functionality:
Link: https://gist.github.com/devarsht/253e485e86661a3051e711f97ec3c5ac
Compression Quality:
Link: https://gist.github.com/devarsht/e16d8b73c8107ac78cc77ad79fd6299f
Multi Instance:
Link: https://gist.github.com/devarsht/58af9ccf822963d2bf8f0c2f4481438a
Link to previous series:
https://lore.kernel.org/all/20230816152210.4080779-1-devarsht@ti.com/
Diff w.r.t previous series (git range-diff) :
https://gist.github.com/devarsht/22a744d999080de6e813bcfb5a596272
Devarsh Thakkar (3):
media: dt-bindings: Add Imagination E5010 JPEG Encoder
media: jpeg: Add reference quantization and huffman tables
media: imagination: Add E5010 JPEG Encoder driver
.../bindings/media/img,e5010-jpeg-enc.yaml | 75 +
MAINTAINERS | 7 +
drivers/media/platform/Kconfig | 1 +
drivers/media/platform/Makefile | 1 +
drivers/media/platform/imagination/Kconfig | 12 +
drivers/media/platform/imagination/Makefile | 3 +
.../platform/imagination/e5010-core-regs.h | 585 +++++++
.../platform/imagination/e5010-jpeg-enc-hw.c | 267 +++
.../platform/imagination/e5010-jpeg-enc-hw.h | 42 +
.../platform/imagination/e5010-jpeg-enc.c | 1552 +++++++++++++++++
.../platform/imagination/e5010-jpeg-enc.h | 169 ++
.../platform/imagination/e5010-mmu-regs.h | 311 ++++
include/media/jpeg.h | 4 +
include/media/jpeg_enc_reftables.h | 112 ++
14 files changed, 3141 insertions(+)
create mode 100644 Documentation/devicetree/bindings/media/img,e5010-jpeg-enc.yaml
create mode 100644 drivers/media/platform/imagination/Kconfig
create mode 100644 drivers/media/platform/imagination/Makefile
create mode 100644 drivers/media/platform/imagination/e5010-core-regs.h
create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.c
create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc-hw.h
create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.c
create mode 100644 drivers/media/platform/imagination/e5010-jpeg-enc.h
create mode 100644 drivers/media/platform/imagination/e5010-mmu-regs.h
create mode 100644 include/media/jpeg_enc_reftables.h
---
Changelog:
V1->V2:
No change (sending dt-binding and driver together)
V2->V3:
- Add DONOTMERGE patches for dts and defconfig
- Update driver with below changes :
- Correct license headers
- Use more generic name core instead of jasper for base registers
- Add Comment for forward declarations
- Simplify quantization table calculations
- Use v4l2_apply_frmsize_constraints for updating framesize and remove
unrequired functions
- Place TODO at top of file and in commit message too
- Use dev_err_probe helper in probe function
- Fix return value checking for failure scenarios in probe function
- Use v4l2_err/info/warn helpers instead of dev_err/info/warn helpers
- Fix unexpected indentation
- Correct commit message
- Update dt-bindings with below changes :
- Add vendor specific compatible
- Fix commit title and message
- Update reg names
- Update clocks to 1
- Fix dts example with proper naming
V3->V4:
- Use ti-specific compatible ti,am62a-jpeg-enc as secondary one in
dt-binding
- Remove clock-names as only single clock in dt-binding
- Fix issue with default params setting
- Correct v4l2 error prints
- Simplify register write functions with single statement return values
- Remove unrequired error checks from get_queue()
- Drop explicit device_caps setting as it is already taken care by v4l2
core
- Remove unrequired multiplanar checks and memset from s_fmt, g_fmt callback functions
- Fix try_fmt callback to not update the queues
- Remove unrequired contiguous format attribute from queue_init
- Use dynamic allocation for video_device and remove unrequired
assignments in probe()
- Remove unrequired checks from queue_setup function
- Return queued buffers back if start_streaming fails
- Use ARRAY_SIZE in place of hard-coding
- Use huffman and quantization tables from reference header file
--
2.34.1
next reply other threads:[~2024-02-05 11:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-05 11:42 Devarsh Thakkar [this message]
2024-02-05 11:42 ` [PATCH v4 1/3] media: dt-bindings: Add Imagination E5010 JPEG Encoder Devarsh Thakkar
2024-02-05 20:09 ` Rob Herring
2024-02-05 21:52 ` Andrew Davis
2024-02-07 6:28 ` Devarsh Thakkar
2024-02-05 11:42 ` [PATCH v4 2/3] media: jpeg: Add reference quantization and huffman tables Devarsh Thakkar
2024-02-05 11:42 ` [PATCH v4 3/3] media: imagination: Add E5010 JPEG Encoder driver Devarsh Thakkar
2024-02-05 13:11 ` Benjamin Gaignard
2024-02-07 9:40 ` Devarsh Thakkar
2024-02-07 10:01 ` Benjamin Gaignard
2024-02-07 13:21 ` Devarsh Thakkar
2024-02-05 20:31 ` Andrew Davis
2024-02-07 13:14 ` Devarsh Thakkar
2024-02-07 17:21 ` Andrew Davis
2024-02-08 10:04 ` Devarsh Thakkar
2024-02-15 13:55 ` Devarsh Thakkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205114239.924697-1-devarsht@ti.com \
--to=devarsht@ti.com \
--cc=a-bhatia1@ti.com \
--cc=andrzej.p@collabora.com \
--cc=b-brnich@ti.com \
--cc=conor+dt@kernel.org \
--cc=detheridge@ti.com \
--cc=devicetree@vger.kernel.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=j-luthra@ti.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=nm@ti.com \
--cc=p-mantena@ti.com \
--cc=praneeth@ti.com \
--cc=robh+dt@kernel.org \
--cc=vigneshr@ti.com \
--cc=vijayp@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).