From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Simon Glass <sjg@chromium.org>
Cc: "Rob Herring" <robh@kernel.org>,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
"Tom Rini" <trini@konsulko.com>,
"Michael Walle" <mwalle@kernel.org>,
"U-Boot Mailing List" <u-boot@lists.denx.de>,
"Conor Dooley" <conor+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Pratyush Yadav" <ptyadav@amazon.de>,
"Rafał Miłecki" <rafal@milecki.pl>,
"Richard Weinberger" <richard@nod.at>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible
Date: Mon, 5 Feb 2024 13:17:55 +0100 [thread overview]
Message-ID: <20240205131755.3462084f@xps-13> (raw)
In-Reply-To: <CAFLszTi+8ygXOidnhxj7sdJwc6X5i+++QvnUyfe-kde5eSts_w@mail.gmail.com>
Hi Simon,
> > > > > > > > > > > > +description: |
> > > > > > > > > > > > + The binman node provides a layout for firmware, used when packaging firmware
> > > > > > > > > > > > + from multiple projects. It is based on fixed-partitions, with some
> > > > > > > > > > > > + extensions, but uses 'compatible' to indicate the contents of the node, to
> > > > > > > > > > > > + avoid perturbing or confusing existing installations which use 'label' for a
> > > > > > > > > > > > + particular purpose.
> > > > > > > > > > > > +
> > > > > > > > > > > > + Binman supports properties used as inputs to the firmware-packaging process,
> > > > > > > > > > > > + such as those which control alignment of partitions. This binding addresses
> > > > > > > > > > > > + these 'input' properties. For example, it is common for the 'reg' property
> > > > > > > > > > > > + (an 'output' property) to be set by Binman, based on the alignment requested
> > > > > > > > > > > > + in the input.
> > > > > > > > > > > > +
> > > > > > > > > > > > + Once processing is complete, input properties have mostly served their
> > > > > > > > > > > > + purpose, at least until the firmware is repacked later, e.g. due to a
> > > > > > > > > > > > + firmware update. The 'fixed-partitions' binding should provide enough
> > > > > > > > > > > > + information to read the firmware at runtime, including decompression if
> > > > > > > > > > > > + needed.
> > > > > > > > > > >
> > > > > > > > > > > How is this going to work exactly? binman reads these nodes and then
> > > > > > > > > > > writes out 'fixed-partitions' nodes. But then you've lost the binman
> > > > > > > > > > > specifc parts needed for repacking.
> > > > > > > > > >
> > > > > > > > > > No, they are the same node. I do want the extra information to stick
> > > > > > > > > > around. So long as it is compatible with fixed-partition as well, this
> > > > > > > > > > should work OK.
> > > > > > > > >
> > > > > > > > > How can it be both? The partitions node compatible can be either
> > > > > > > > > 'fixed-partitions' or 'binman'.
> > > > > > > >
> > > > > > > > Can we not allow it to be both? I have tried to adjust things in
> > > > > > > > response to feedback but perhaps the feedback was leading me down the
> > > > > > > > wrong path?
> > > > > > >
> > > > > > > Sure, but then the schema has to and that means extending
> > > > > > > fixed-partitions.
> > > > > >
> > > > > > Can we cross that bridge later? There might be resistance to it. I'm
> > > > > > not sure. For now, perhaps just a binman compatible works well enough
> > > > > > to make progress.
> > > > >
> > > > > Is there any way to make progress on this? I would like to have
> > > > > software which doesn't understand the binman compatible to at least be
> > > > > able to understand the fixed-partition compatible. Is that acceptable?
> > > >
> > > > There's only 2 ways that it can work. Either binman writes out
> > > > fixed-partition nodes dropping/replacing anything only defined for
> > > > binman or fixed-partition is extended to include what binman needs.
> > >
> > > OK, then I suppose the best way is to add a new binman compatible, as
> > > is done with this v6 series. People then need to choose it instead of
> > > fixed-partition.
> >
> > I'm sorry this is not at all what Rob suggested, or did I totally
> > misunderstand his answer?
> >
> > In both cases the solution is to generate a "fixed-partition" node. Now
> > up to you to decide whether binman should adapt the output to the
> > current schema, or if the current schema should be extended to
> > understand all binman's output.
> >
> > At least that is my understanding and also what I kind of agree with.
>
> I do want to binman schema to include all the features of Binman.
>
> So are you saying that there should not be a 'binman' schema, but I
> should just add all the binman properties to the fixed-partition
> schema?
This is my current understanding, yes. But acknowledgment from Rob is
also welcome.
Thanks,
Miquèl
next prev parent reply other threads:[~2024-02-05 12:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-16 17:28 [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible Simon Glass
2023-11-16 17:28 ` [PATCH v6 2/3] dt-bindings: mtd: binman-partition: Add binman compatibles Simon Glass
2023-11-16 17:28 ` [PATCH v6 3/3] dt-bindings: mtd: binman-partitions: Add alignment properties Simon Glass
2023-11-29 23:22 ` [PATCH v6 1/3] dt-bindings: mtd: partitions: Add binman compatible Simon Glass
2023-12-08 15:00 ` Rob Herring
2023-12-08 17:46 ` Simon Glass
2023-12-08 21:56 ` Rob Herring
2023-12-08 22:58 ` Simon Glass
2023-12-14 17:27 ` Rob Herring
2023-12-14 21:09 ` Simon Glass
2024-01-04 21:54 ` Simon Glass
2024-01-17 15:56 ` Rob Herring
2024-02-04 12:07 ` Simon Glass
2024-02-05 7:50 ` Miquel Raynal
2024-02-05 11:59 ` Simon Glass
2024-02-05 12:17 ` Miquel Raynal [this message]
2024-03-08 2:44 ` Simon Glass
2024-03-08 7:42 ` Miquel Raynal
2024-03-12 22:25 ` Simon Glass
2024-03-13 7:35 ` Miquel Raynal
2024-03-14 2:15 ` Simon Glass
-- strict thread matches above, loose matches on Subject: below --
2023-10-25 21:06 Simon Glass
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240205131755.3462084f@xps-13 \
--to=miquel.raynal@bootlin.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=ptyadav@amazon.de \
--cc=rafal@milecki.pl \
--cc=richard@nod.at \
--cc=robh@kernel.org \
--cc=sjg@chromium.org \
--cc=trini@konsulko.com \
--cc=u-boot@lists.denx.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).