[PATCH v3 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example

[PATCH v3 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example

[Dimitri Fedrau]

Add interrupt bindings in example.

Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
---
 Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
index 7f6d0f9edc75..5b3f9670fa52 100644
--- a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
+++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
@@ -51,5 +51,7 @@ examples:
             compatible = "ti,hdc3021", "ti,hdc3020";
             reg = <0x47>;
             vdd-supply = <&vcc_3v3>;
+            interrupt-parent = <&gpio3>;
+            interrupts = <23 IRQ_TYPE_EDGE_RISING>;
         };
     };
-- 
2.39.2

Re: [PATCH v3 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example

[Javier Carrasco]

Hi Dimitri,

On 07.02.24 08:47, Dimitri Fedrau wrote:
> Add interrupt bindings in example.
> 
> Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> index 7f6d0f9edc75..5b3f9670fa52 100644
> --- a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> @@ -51,5 +51,7 @@ examples:
>              compatible = "ti,hdc3021", "ti,hdc3020";
>              reg = <0x47>;
>              vdd-supply = <&vcc_3v3>;
> +            interrupt-parent = <&gpio3>;
> +            interrupts = <23 IRQ_TYPE_EDGE_RISING>;
>          };
>      };

Did you compile the example? I think this will fail because you don't
have the include for IRQ_TYPE_EDGE_RISING.

Best regards,
Javier Carrasco

Re: [PATCH v3 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example

[Dimitri Fedrau]

Am Wed, Feb 07, 2024 at 08:54:57AM +0100 schrieb Javier Carrasco:
> Hi Dimitri,
> 
> On 07.02.24 08:47, Dimitri Fedrau wrote:
> > Add interrupt bindings in example.
> > 
> > Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> > ---
> >  Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> > index 7f6d0f9edc75..5b3f9670fa52 100644
> > --- a/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> > +++ b/Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml
> > @@ -51,5 +51,7 @@ examples:
> >              compatible = "ti,hdc3021", "ti,hdc3020";
> >              reg = <0x47>;
> >              vdd-supply = <&vcc_3v3>;
> > +            interrupt-parent = <&gpio3>;
> > +            interrupts = <23 IRQ_TYPE_EDGE_RISING>;
> >          };
> >      };
> 
> Did you compile the example? I think this will fail because you don't
> have the include for IRQ_TYPE_EDGE_RISING.
>
Missed that one, thanks. No didn't build the documentation yet. Will do
that.

Best regards,
Dimitri Fedrau

Re: [PATCH v3 2/3] dt-bindings: iio: humidity: hdc3020: add interrupt bindings in example

[Rob Herring]

On Wed, 07 Feb 2024 08:47:52 +0100, Dimitri Fedrau wrote:
> Add interrupt bindings in example.
> 
> Signed-off-by: Dimitri Fedrau <dima.fedrau@gmail.com>
> ---
>  Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 

My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check'
on your patch (DT_CHECKER_FLAGS is new in v5.13):

yamllint warnings/errors:

dtschema/dtc warnings/errors:
Error: Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.example.dts:33.34-35 syntax error
FATAL ERROR: Unable to parse input tree
make[2]: *** [scripts/Makefile.lib:419: Documentation/devicetree/bindings/iio/humidity/ti,hdc3020.example.dtb] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1428: dt_binding_check] Error 2
make: *** [Makefile:240: __sub-make] Error 2

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240207074758.4138724-3-dima.fedrau@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.