From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail5.25mail.st (mail5.25mail.st [74.50.62.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7B49E7483 for ; Mon, 12 Feb 2024 08:18:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.50.62.9 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707725912; cv=none; b=ghnBKnTQzjhYM6KqxB/JgN4zsqyczUIYfaGNeP8J+OTzS2rbQgAqyd6Xn3LuyGRVBkYett9Sp3lb5Yn7yfvTlriRASAlYhtnIPHqgDeP893VDmi4ed4S0OJpgKpCpWa9JLyFbKKIzdK6BsUeahcPnmXxaCfFSMke1SZjmzmsAzA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707725912; c=relaxed/simple; bh=o1J8VBOyGLyYjF4hp5r2x8I5a4dOkXgfTSRK3XqSHgc=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jHEYdlHWOgUqyJw/yVXWHdmrjHS1TvPvHSDK94hjZY71TnJ0f05PqcfKh8A+4v7LklEe/J1KZUvP104Cvgcovmaqvl0YvIjsPRKZkTiKqy9k540nb7Qibkba+rJqy9TvjI2u1aAepPT1fjxUt9xav+lpSCb4tjXlXTZXROKCxaI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com; spf=fail smtp.mailfrom=atomide.com; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b=rU9losSW; arc=none smtp.client-ip=74.50.62.9 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=atomide.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=atomide.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=atomide.com header.i=@atomide.com header.b="rU9losSW" Received: from localhost (91-158-86-216.elisa-laajakaista.fi [91.158.86.216]) by mail5.25mail.st (Postfix) with ESMTPSA id 090026036A; Mon, 12 Feb 2024 08:17:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=atomide.com; s=25mailst; t=1707725909; bh=o1J8VBOyGLyYjF4hp5r2x8I5a4dOkXgfTSRK3XqSHgc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=rU9losSWbWS9//3FMBSOy8jZGW1JynDEyZONP43YCZYddn/0cTvncDj9P3h58UlR1 C8mxCcwvdr/+7nfKnU+qjJEX2tOBtGP9eRyIiFAUGw9P41sNIM1u5MGhrxSY7oT4Fc QRi6wGGrnjYNOp1XMbrwHHGvswjDmUs/5lf+xAl/gGnaUWodxnl7Pj4QMYwGpVUgRU iWPZQOIiCcugEtWqaDtjM206+tdFoBKnIQULzTPUtISKuSJIA/JJREH7wLGA/SmPOP uzP58cZIBcjBP/Pgeo9+AwenUm5LGjZIWXHTxPYgREdCTpHcxUPquLydE/GA2uj6nX Qy7oRgZqs5yXw== Date: Mon, 12 Feb 2024 10:17:44 +0200 From: Tony Lindgren To: Krzysztof Kozlowski Cc: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Simha BN , Sam Ravnborg , Dmitry Baryshkov , Michael Walle , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 Message-ID: <20240212081744.GE5299@atomide.com> References: <20240211095144.2589-1-tony@atomide.com> <20240211095144.2589-4-tony@atomide.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: * Krzysztof Kozlowski [240212 08:06]: > On 11/02/2024 10:51, Tony Lindgren wrote: > > The tc358765 is similar to tc358775. The tc358765 just an earlier version > > of the hardware, and it's pin and register compatible with tc358775 for > > most part. > > > > From the binding point of view the only difference is that the tc358765 > > does not have stdby-gpios. > > > > Signed-off-by: Tony Lindgren > > --- > > It does not look like you tested the bindings, at least after quick > look. Please run `make dt_binding_check` (see > Documentation/devicetree/bindings/writing-schema.rst for instructions). > Maybe you need to update your dtschema and yamllint. I did.. But I did not notice that this no longer works: $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml LINT Documentation/devicetree/bindings usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] yamllint: error: one of the arguments FILE_OR_DIR - is required CHKDT Documentation/devicetree/bindings/processed-schema.json SCHEMA Documentation/devicetree/bindings/processed-schema.json After removing the ">2&1" from the Makefile, there's some more info: yamllint: error: one of the arguments FILE_OR_DIR - is required Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs to be now run with just: $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml Regards, Tony