From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43DC93A1DB for ; Mon, 12 Feb 2024 13:51:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707745871; cv=none; b=jmlpqx/20vTaRtnj1YPtwjV0XcopmM/ZrYh/WX+We9uitWthEa8T364rOfiwI+pysWT01r02prhRWiuSisMh4UnUixrEQrNzuiWsaCS/ABhbziBEv9hjMfGcFyfXOAwJpR56LeD7+S//RiilJJXIFFhzor0Km7zx4+o6J2B+7N0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707745871; c=relaxed/simple; bh=vwLwBT4PRTHSH4eQcxrNxB/+A7bhKLT0iSEbHHKStwA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PXkHccVcsJkmNVetcxvf0wAilKGgP23Yxt+mxZBk9BMOFM1pztLyBpuD8TccHNXg9tu82BK7v4NhSNtONfukRjR7v/NZoh6tqWBwMzKe7Hq42shN31xsRtPxlRdoIboxa3v49cuVlgJSwhPgjpsIPU7ZfkKelVU70oXvaaEtTUE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=lWbqPBIS; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="lWbqPBIS" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 84FA2C433F1; Mon, 12 Feb 2024 13:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707745870; bh=vwLwBT4PRTHSH4eQcxrNxB/+A7bhKLT0iSEbHHKStwA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lWbqPBISLWqLCCQsSISnhqS5B0JJ+u3JqDjUvp20+YJW126GKqVSAdg0/188lLqg+ mYAJBNyxQlzK8uBPcnvSlvCpAQbVj1rYnJ3C+DeiNG8p4tY2+JoT3hRL4Hr+IPonpq DVLsOm7F7tNE+8eAKwh/WlVFxGufg8OX2nspwEZy8Q0NeUrvzgzPv/5iMugAAzuP9w 6XZbfkuy4fDzWVkeFAN1sOC907V3Wzp+Xpq9RBYAthzdQPStvNMJkdZ3FsobIslb73 KWXrHwy6522vkMOdid4xR1rni2S/GGsHi0IOspHn0WrMQQzUx7YP9hASJeLhmH5OL3 cic65NngPkM8w== Date: Mon, 12 Feb 2024 07:51:08 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Tony Lindgren , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Krzysztof Kozlowski , Conor Dooley , Simha BN , Sam Ravnborg , Dmitry Baryshkov , Michael Walle , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org Subject: Re: [PATCH v3 03/10] dt-bindings: display: bridge: tc358775: Add support for tc358765 Message-ID: <20240212135108.GA49008-robh@kernel.org> References: <20240211095144.2589-1-tony@atomide.com> <20240211095144.2589-4-tony@atomide.com> <20240212081744.GE5299@atomide.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Mon, Feb 12, 2024 at 12:30:12PM +0100, Krzysztof Kozlowski wrote: > On 12/02/2024 09:17, Tony Lindgren wrote: > > * Krzysztof Kozlowski [240212 08:06]: > >> On 11/02/2024 10:51, Tony Lindgren wrote: > >>> The tc358765 is similar to tc358775. The tc358765 just an earlier version > >>> of the hardware, and it's pin and register compatible with tc358775 for > >>> most part. > >>> > >>> From the binding point of view the only difference is that the tc358765 > >>> does not have stdby-gpios. > >>> > >>> Signed-off-by: Tony Lindgren > >>> --- > >> > >> It does not look like you tested the bindings, at least after quick > >> look. Please run `make dt_binding_check` (see > >> Documentation/devicetree/bindings/writing-schema.rst for instructions). > >> Maybe you need to update your dtschema and yamllint. > > > > I did.. But I did not notice that this no longer works: > > > > $ make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/display/bridge/toshiba,tc358775.yaml > > LINT Documentation/devicetree/bindings > > usage: yamllint [-h] [-] [-c CONFIG_FILE | -d CONFIG_DATA] [--list-files] [-f {parsable,standard,colored,github,auto}] [-s] [--no-warnings] [-v] [FILE_OR_DIR ...] > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > CHKDT Documentation/devicetree/bindings/processed-schema.json > > SCHEMA Documentation/devicetree/bindings/processed-schema.json > > > > After removing the ">2&1" from the Makefile, there's some more info: > > > > yamllint: error: one of the arguments FILE_OR_DIR - is required > > > > Where DT_SCHEMA_FILES ends up empty. I guess dt_binding_check needs > > to be now run with just: > > > > $ make dt_binding_check DT_SCHEMA_FILES=toshiba,tc358775.yaml > > > > Yes, since June last year. Rob later brought (in July) backwards > compatible way, but apparently something changed now in Makefile. It broke in 6.8-rc1. I have a fix in my tree which I'll send to Linus this week. Rob