devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	 Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	 Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: nm@ti.com, r-gunasekaran@ti.com, afd@ti.com, b-liu@ti.com,
	srk@ti.com,  francesco@dolcini.it, linux-usb@vger.kernel.org,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 Roger Quadros <rogerq@kernel.org>
Subject: [PATCH v3 1/5] usb: dwc3-am62: call of_platform_depopulate in .remove()
Date: Wed, 14 Feb 2024 11:46:45 +0200	[thread overview]
Message-ID: <20240214-for-v6-9-am62-usb-errata-3-0-v3-1-147ec5eae18c@kernel.org> (raw)
In-Reply-To: <20240214-for-v6-9-am62-usb-errata-3-0-v3-0-147ec5eae18c@kernel.org>

We called of_platform_populate() in .probe() so call the
cleanup function of_platform_depopulate() in .remove().

Get rid of the now unnnecessary dwc3_ti_remove_core().

Signed-off-by: Roger Quadros <rogerq@kernel.org>
---
Changelog:

v3: no change
v2: no change
	https://lore.kernel.org/all/20240205141221.56076-2-rogerq@kernel.org/
v1: https://lore.kernel.org/all/20240201121220.5523-2-rogerq@kernel.org/
---
 drivers/usb/dwc3/dwc3-am62.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/usb/dwc3/dwc3-am62.c b/drivers/usb/dwc3/dwc3-am62.c
index 90a587bc29b7..1bfc9e67614f 100644
--- a/drivers/usb/dwc3/dwc3-am62.c
+++ b/drivers/usb/dwc3/dwc3-am62.c
@@ -267,21 +267,13 @@ static int dwc3_ti_probe(struct platform_device *pdev)
 	return ret;
 }
 
-static int dwc3_ti_remove_core(struct device *dev, void *c)
-{
-	struct platform_device *pdev = to_platform_device(dev);
-
-	platform_device_unregister(pdev);
-	return 0;
-}
-
 static void dwc3_ti_remove(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct dwc3_am62 *am62 = platform_get_drvdata(pdev);
 	u32 reg;
 
-	device_for_each_child(dev, NULL, dwc3_ti_remove_core);
+	of_platform_depopulate(dev);
 
 	/* Clear mode valid bit */
 	reg = dwc3_ti_readl(am62, USBSS_MODE_CONTROL);

-- 
2.34.1


  reply	other threads:[~2024-02-14  9:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-14  9:46 [PATCH v3 0/5] usb: dwc3-am62: module removal and errata fixes Roger Quadros
2024-02-14  9:46 ` Roger Quadros [this message]
2024-02-23 22:14   ` [PATCH v3 1/5] usb: dwc3-am62: call of_platform_depopulate in .remove() Thinh Nguyen
2024-02-14  9:46 ` [PATCH v3 2/5] usb: dwc3-am62: fix error on module removal Roger Quadros
2024-02-23 22:17   ` Thinh Nguyen
2024-02-23 22:31   ` Thinh Nguyen
2024-02-26 13:19     ` Roger Quadros
2024-02-14  9:46 ` [PATCH v3 3/5] usb: dwc3-am62: Fix PHY core voltage selection Roger Quadros
2024-02-23 22:19   ` Thinh Nguyen
2024-02-14  9:46 ` [PATCH v3 4/5] dt-bindings: usb/ti,am62-usb.yaml: Add PHY2 register space Roger Quadros
2024-02-14 14:09   ` Rob Herring
2024-02-14  9:46 ` [PATCH v3 5/5] usb: dwc3-am62: add workaround for Errata i2409 Roger Quadros
2024-02-23 22:24   ` Thinh Nguyen
2024-02-23 13:17 ` [PATCH v3 0/5] usb: dwc3-am62: module removal and errata fixes Roger Quadros
2024-02-23 22:25   ` Thinh Nguyen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240214-for-v6-9-am62-usb-errata-3-0-v3-1-147ec5eae18c@kernel.org \
    --to=rogerq@kernel.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=afd@ti.com \
    --cc=b-liu@ti.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=francesco@dolcini.it \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=nm@ti.com \
    --cc=r-gunasekaran@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=srk@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).