From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7F34F3D6D; Thu, 15 Feb 2024 18:58:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708023529; cv=none; b=n1ZCfgD5JQuX0a+P60XUuY8uzsjuCkSI6rKVt1hQ5VYrQX4rLl2BEk5o9w+CbRQVJkMLzuGv1wgqH3fznepSlTGG/fdKegaYZvWjrSHGA74GYhpJv286YMYaZrTfZoKMLIVhGYlHhAspyiHIpqLhDbFJMVdkakUJTO9HaI02mh0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708023529; c=relaxed/simple; bh=hMviSDR7IR+GwWkZCHnOzDa9PpoRzyHBelNBMVSD3GE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=F0wkBC+puKrsYf2kzVzQPW5u7DrX9SsJJSY88dgDzRbJgdtjthHNwHS+2FHFXftGy5c/r6y63i7p7oSFMBajuScBSM/aiBLnfnvTquSRmF3ZOtZdhsrS0AAqsCLpn3gduCDcvNkWyqT7QzRnNmIc7MV4Rc072WMhL5CTfoR00JI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=gMANnlTF; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="gMANnlTF" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E038DC433C7; Thu, 15 Feb 2024 18:58:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708023528; bh=hMviSDR7IR+GwWkZCHnOzDa9PpoRzyHBelNBMVSD3GE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=gMANnlTFcL5eM9hIehGB9iWbnA1rJKQPb+9d96/PIXlWWoV6wF4rmRpq0orkAN2Xr wZjpnbehEbi8PkSdguJBOlvaI1N+vkUtYCMxi9EELVmX6MQpyVPC9IKs8loS/i72B0 xIagK6XErn2h0FDOyEVgts7zHDQeEY5i8ZMyKDh8eH+vWO7ROgU4zd4LTnCZ0HatOp tNxPhAeesMa+KhkZb1q2l8Xl2YLXxeSzcy8VZd/wfKgGM18gPhUwDJRdHA1T73LbGU Y4zWCpsQ4Lf80Bo7COn+NllJxbI1B//IDnGGZJgjamum1n60BijBeujtS9ZHsnrEIT kpZO2fztcNrSg== Date: Thu, 15 Feb 2024 10:58:46 -0800 From: Jakub Kicinski To: Kory Maincent Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Jonathan Corbet , Luis Chamberlain , Russ Weight , Greg Kroah-Hartman , "Rafael J. Wysocki" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Oleksij Rempel , Mark Brown , Frank Rowand , Andrew Lunn , Heiner Kallweit , Russell King , Thomas Petazzoni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, devicetree@vger.kernel.org, Dent Project Subject: Re: [PATCH net-next v4 05/17] net: pse-pd: Introduce PSE types enumeration Message-ID: <20240215105846.6dd48886@kernel.org> In-Reply-To: <20240215-feature_poe-v4-5-35bb4c23266c@bootlin.com> References: <20240215-feature_poe-v4-0-35bb4c23266c@bootlin.com> <20240215-feature_poe-v4-5-35bb4c23266c@bootlin.com> Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 15 Feb 2024 17:02:46 +0100 Kory Maincent wrote: > Introduce an enumeration to define PSE types (C33 or PoDL), > utilizing a bitfield for potential future support of both types. > Include 'pse_get_types' helper for external access to PSE type info. I haven't read the series, just noticed this breaks the build: error: ../include/uapi/linux/pse.h: missing "WITH Linux-syscall-note" for SPDX-License-Identifier but why the separate header? Is it going to be used in other parts of uAPI than just in ethtool? > This patch is sponsored by Dent Project side-note: no objections to the line but for accounting purposes (i.e. when we generate development stats) we use the Author / From line exclusively. So it'd be easier to compute stats of things funded by Dent if you used: From: Kory Maincent (Dent Project) but that's entirely up to you :)