From: Conor Dooley <conor@kernel.org>
To: Jonathan Cameron <jic23@kernel.org>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
puranjay12@gmail.com, lars@metafoo.de, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
thomas.haemmerle@leica-geosystems.com
Subject: Re: [RESEND PATCH 1/2] dt-bindings: iio: ti,tmp117: add vcc supply binding
Date: Fri, 16 Feb 2024 19:42:15 +0000 [thread overview]
Message-ID: <20240216-unlocking-cinnamon-54ab3d755cfd@spud> (raw)
In-Reply-To: <20240216112120.76a0c0ca@jic23-huawei>
[-- Attachment #1: Type: text/plain, Size: 832 bytes --]
On Fri, Feb 16, 2024 at 11:21:20AM +0000, Jonathan Cameron wrote:
> On Fri, 16 Feb 2024 11:28:19 +0100
> Marco Felsch <m.felsch@pengutronix.de> wrote:
>
> > From: Thomas Haemmerle <thomas.haemmerle@leica-geosystems.com>
> >
> > Add the binding to specify the vcc supply. We can't make it required
> > since this would break the backward compatibility.
>
> Given convention for supplies like this is to make them required in
> the dt-binding to reflect that providing power is not optional (unlikely
> some other supplies that might not be wired up) and not worry about the
> fact that we happily provide dummy supplies for them if they aren't in a
> particular dts, it should be fine to make it required here.
With the suggested change,
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>
Cheers,
Conor.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
prev parent reply other threads:[~2024-02-16 19:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 10:28 [RESEND PATCH 1/2] dt-bindings: iio: ti,tmp117: add vcc supply binding Marco Felsch
2024-02-16 10:28 ` [RESEND PATCH 2/2] iio: temperature: tmp117: add support for vcc-supply Marco Felsch
2024-02-16 11:29 ` Jonathan Cameron
2024-02-16 11:51 ` Marco Felsch
2024-02-16 11:21 ` [RESEND PATCH 1/2] dt-bindings: iio: ti,tmp117: add vcc supply binding Jonathan Cameron
2024-02-16 11:23 ` Marco Felsch
2024-02-16 15:50 ` Jonathan Cameron
2024-02-16 19:42 ` Conor Dooley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216-unlocking-cinnamon-54ab3d755cfd@spud \
--to=conor@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jic23@kernel.org \
--cc=kernel@pengutronix.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=puranjay12@gmail.com \
--cc=robh+dt@kernel.org \
--cc=thomas.haemmerle@leica-geosystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox