From: Gregory CLEMENT <gregory.clement@bootlin.com>
To: Paul Burton <paulburton@kernel.org>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-mips@vger.kernel.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "Vladimir Kondratiev" <vladimir.kondratiev@mobileye.com>,
"Tawfik Bayouk" <tawfik.bayouk@mobileye.com>,
"Alexandre Belloni" <alexandre.belloni@bootlin.com>,
"Théo Lebrun" <theo.lebrun@bootlin.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
"Gregory CLEMENT" <gregory.clement@bootlin.com>
Subject: [PATCH v8 04/14] MIPS: traps: Give more explanations if ebase doesn't belong to KSEG0
Date: Fri, 16 Feb 2024 18:42:13 +0100 [thread overview]
Message-ID: <20240216174227.409400-5-gregory.clement@bootlin.com> (raw)
In-Reply-To: <20240216174227.409400-1-gregory.clement@bootlin.com>
With the expanded support for placing the kernel in XPHYS rather than
just KSEG0, scenarios where ebase doesn't belong to KSEG0 are more
likely to occur. In such cases, we currently experience a substantial
and perplexing stack dump without any accompanying explanation. To
rectify this, we aim to replace the uninformative stack dump with a
warning that offers a clear explanation of the issue.
Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
---
arch/mips/kernel/traps.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/arch/mips/kernel/traps.c b/arch/mips/kernel/traps.c
index 075bb08543eca..a9644c5e7ef4d 100644
--- a/arch/mips/kernel/traps.c
+++ b/arch/mips/kernel/traps.c
@@ -2345,10 +2345,13 @@ void __init trap_init(void)
* EVA is special though as it allows segments to be rearranged
* and to become uncached during cache error handling.
*/
- if (!IS_ENABLED(CONFIG_EVA) && !WARN_ON(ebase_pa >= 0x20000000))
+ if (!IS_ENABLED(CONFIG_EVA) && ebase_pa < 0x20000000)
ebase = CKSEG0ADDR(ebase_pa);
else
ebase = (unsigned long)phys_to_virt(ebase_pa);
+ if (ebase_pa >= 0x20000000)
+ pr_warn("ebase(%pa) should better be in KSeg0",
+ &ebase_pa);
}
if (cpu_has_mmips) {
--
2.43.0
next prev parent reply other threads:[~2024-02-16 17:42 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-16 17:42 [PATCH v8 00/14] Add support for the Mobileye EyeQ5 SoC Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 01/14] MIPS: spaces: Define a couple of handy macros Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 02/14] MIPS: Fix set_uncached_handler for ebase in XKPHYS Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 03/14] MIPS: Allows relocation exception vectors everywhere Gregory CLEMENT
2024-02-16 17:42 ` Gregory CLEMENT [this message]
2024-02-16 17:42 ` [PATCH v8 05/14] MIPS: cps-vec: Use macros for 64bits access Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 06/14] dt-bindings: Add vendor prefix for Mobileye Vision Technologies Ltd Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 07/14] dt-bindings: mips: cpus: Sort the entries Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 08/14] dt-bindings: mips: cpu: Add I-Class I6500 Multiprocessor Core Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 09/14] dt-bindings: mips: Add bindings for Mobileye SoCs Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 10/14] MIPS: mobileye: Add EyeQ5 dtsi Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 11/14] MIPS: mobileye: Add EPM5 device tree Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 12/14] MIPS: Share generic kernel code with other architecture Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 13/14] MIPS: Add support for Mobileye EyeQ5 Gregory CLEMENT
2024-02-16 17:42 ` [PATCH v8 14/14] MAINTAINERS: Add entry for Mobileye MIPS SoCs Gregory CLEMENT
2024-02-20 13:44 ` [PATCH v8 00/14] Add support for the Mobileye EyeQ5 SoC Thomas Bogendoerfer
2024-02-28 11:44 ` Théo Lebrun
2024-03-01 9:39 ` Thomas Bogendoerfer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240216174227.409400-5-gregory.clement@bootlin.com \
--to=gregory.clement@bootlin.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=paulburton@kernel.org \
--cc=robh+dt@kernel.org \
--cc=tawfik.bayouk@mobileye.com \
--cc=theo.lebrun@bootlin.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=tsbogend@alpha.franken.de \
--cc=vladimir.kondratiev@mobileye.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).